topcoderinc / openmct Goto Github PK

An indicator is registered which provides some demo functionality for developers. This looks like it was brought over accidentally from example/notifications and should be removed.

Per Notebook UI v1.0.3 pg. 127 callout 3, the title of an embedded object in a Notebook entry should be linking to the live object, but is not. The thumbnail is correctly linking to the object's snapshot.

Delivery 10-10-17

Creating a new entry via an object's context menu should display a dialog as shown on Notebook UI v1.0.3 page 133, but instead looks like this:

Sources in example/notebook do not follow naming conventions from the contributing guide; specifically:

• Follow “Java-like” naming conventions. These includes:
• Classes should use camel case, first letter capitalized
  (e.g. SomeClassName).
• Methods, variables, fields, and function names should use camel case,
  first letter lower-case (e.g. someVariableName).
• Constants (variables or fields which are meant to be declared and
  initialized statically, and never changed) should use only capital
  letters, with underscores between words (e.g. SOME_CONSTANT).
• File names should be the name of the exported class, plus a .js extension
  (e.g. SomeClassName.js).

Delivery 10-10-17

While searching in the Notebook, the can't apparently create a new entry. What's going on is that a new entry is being created, but the user doesn't see it due to search filtering. This is why the Notebook UI v1.0.3 page 134 callout 6 specifies that clicking to create a new entry or dragging and dropping a domain object in the Start area should clear the search filter input and cease filtering.

Delivery 10-10-17

Reference Notebook UI v1.0.3 page 136.

Delivery 10-10-17.

The Notebook should never manifest in Edit mode. Creating a Notebook is more akin to creating a Folder: after selecting from the Create menu, the user would interact with a standard dialog initially, with the newly created blank Notebook appearing as shown on Notebook UI v1.0.3 Page 121. I don’t show this dialog in the UI document; if that would be helpful I can easily add and send a revised UI.

There is a related issue: creating a new entry in a Notebook that has been added to a Layout navigates the user away from the Layout and places the Notebook into Edit mode. Per Notebook UI v1.0.3 page 123, this should not be the case.

Delivery 10-10-17.

The developer has added a Recent, Shared with Me, etc. at the bottom of the tree. While these are shown in the UI doc, this is not part of the Notebook and should be removed.

Both notebookController and entryDnd modify domain object models directly. This will cause issues with persistence; should modify domain object models via mutation instead.

Delivery 10-10-17

Default mobile styles appear to be being overridden: the Create button is being displayed, but should not.

Delivery 10-10-17

Something is causing message dialogs to not display properly and get clipped in small screen resolutions, hiding the action buttons:

@charlesh88 has verified that this is unique to the Notebook code fork and can't be duplicated in the main code fork.

The lib directory of the notebook contains the painterro dependency; this dependency should be managed through npm instead for consistency. LICENSES.md should also be updated to reflect these changes.

Delivery 10-10-17.

Per Notebook UI v1.0.3 page 118 the search bar, controls and new entry area must not be included in the list scrolling region.

Delivery 10-10-17.

• When just going to the root URL http://nasa-mct-notebook.herokuapp.com/ the app sometimes takes a very long time to load in my iPhone 6 and in Chrome’s desktop browser mobile emulation. -
• When trying to go to a URL that includes an address for a Notebook (like http://nasa-mct-notebook.herokuapp.com/#/browse/mine/7dc94eb3-406f-4a19-ba28-2019ce1e331d?tc.mode=local&tc.timeSystem=utc&tc.startDelta=1800000&tc.endDelta=0&view=notebook.view), it sometimes never loads and throws this error:
  

Delivery 10-10-17

Notebook CSS styles appear to be placed in the Style Guide SCSS directory path. This is definitely not the right place for these to be held; new SCSS files specific to the Notebook should be within the Notebook plugin directory structure.

Delivery 10-10-17

The placement of the annotation toolbar in the markup ends up hiding controls for certain tool types, like text, making them unusable. Moving the toolbar out of the scrolling region will fix this.

The following changes to platform are undesired and in some cases may risk regressions of core functionality:

• Whitespace-only change in browse.html
• Unnecessary type checking in CreateWizard (this can be supported with composition policy instead)
• Search-related styles have been commented out for unclear reasons
• Changes to Layout tightly couple this component with the notebook

A $destroy listener is registered but not implemented in entryDnd; at minimum, should include $element.off calls for dragover/drop to avoid possible resource leaks.

Delivery 10-10-17

normalize.min.css is not being found is throwing 404 errors. This should be fixed asap so that any remaining work on styling will appear correctly.

10-18-17, during issue fix review.

When deleting a Notebook entry from a Notebook, the resulting dialog text is incorrect:

The message should appear as per Notebook UI v1.0.3 page 138.

Delivery 10-10-17.

Clicking a Snapshot thumb in an entry should display the Snapshot, same as choosing View Snapshot from the context menu. Notebook UI v1.0.3 Page 127 callout 2.

Build currently fails for this repository due to multiple linting and code style violations flagged by gulp verify:

• 21 test failures on gulp test
• 1 error on gulp lint
• 12 code style violations on gulp checkstyle

Deliver 10-10-17

The annotation toolbar should be placed at the top of the dialog's workspace, per Notebook UI v1.0.3 page 135.

10-18-17, during fixed issues review.

1. Create a Notebook.
2. Create a Timer, and in the dialog, save it into the Notebook.
   

This operation should not be allowed: the Notebook should only contain Notebook entries.

Delivery 10-10-17.

Adding a new entry to a Notebook must display an input textarea and place the user’s cursor in it. Notebook UI v1.0.3 Page 124.