Giter Club home page Giter Club logo

Comments (6)

dedywahyudi avatar dedywahyudi commented on September 26, 2024

@charlesh88 @kbowerma
Clear, i'm asking the edit

from openmct.

dedywahyudi avatar dedywahyudi commented on September 26, 2024

@charlesh88 @kbowerma
This is fixed now

from openmct.

charlesh88 avatar charlesh88 commented on September 26, 2024

Reviewed 11/07/17. Not accepted.

What's fixed: the Notebook can only contain Notebook entries, sort of.
What's not fixed: dragging an object to create a new Notebook entry is working as desired with respect to the Notebook entry UI itself, but it's also adding linked objects as composition children of the Notebook, which is very undesired and will become very problematic when a Notebook has a lot of entries with embedded objects. Additionally, removing the embed from an entry, or deleting an entry, fails to remove the embedded object from the Notebook.

screen-shot-2017-11-07-at-4 13 25-pm-annotated

What should be happening is that each entry should retain the thumb if included (which links to the snapshot) and the link (which navigates to the live object) but those elements should not be appearing as children of the Notebook in the tree. In fact, the Notebook would never display any child content in the tree.

from openmct.

dedywahyudi avatar dedywahyudi commented on September 26, 2024

@charlesh88 @kbowerma Ok, i'm asking more edits.

from openmct.

dedywahyudi avatar dedywahyudi commented on September 26, 2024

@charlesh88 @kbowerma This should be fixed now.
Please check the commits: 46d7c11

And updated heroku here: https://notebook-openmct.herokuapp.com/

from openmct.

charlesh88 avatar charlesh88 commented on September 26, 2024

Reviewed 11/13/17, fixed.

from openmct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.