Comments (6)
@charlesh88 @kbowerma
Clear, i'm asking the edit
from openmct.
@charlesh88 @kbowerma
This is fixed now
from openmct.
Reviewed 11/07/17. Not accepted.
What's fixed: the Notebook can only contain Notebook entries, sort of.
What's not fixed: dragging an object to create a new Notebook entry is working as desired with respect to the Notebook entry UI itself, but it's also adding linked objects as composition children of the Notebook, which is very undesired and will become very problematic when a Notebook has a lot of entries with embedded objects. Additionally, removing the embed from an entry, or deleting an entry, fails to remove the embedded object from the Notebook.
What should be happening is that each entry should retain the thumb if included (which links to the snapshot) and the link (which navigates to the live object) but those elements should not be appearing as children of the Notebook in the tree. In fact, the Notebook would never display any child content in the tree.
from openmct.
@charlesh88 @kbowerma Ok, i'm asking more edits.
from openmct.
@charlesh88 @kbowerma This should be fixed now.
Please check the commits: 46d7c11
And updated heroku here: https://notebook-openmct.herokuapp.com/
from openmct.
Reviewed 11/13/17, fixed.
from openmct.
Related Issues (20)
- [Performance] Loading issues HOT 2
- [UI] New Notebook Entry dialog incomplete HOT 5
- [UI] Can't apparently create a new entry while searching HOT 2
- [UI] Annotation toolbar should be above image HOT 2
- [UI] Annotation toolbar scroll hides controls HOT 7
- [UI] View Large Dialog not displaying "New Notebook Entry" button HOT 2
- [Styles] Message dialogs clipped HOT 2
- [Mobile] Create button displayed HOT 2
- [Dev] Notebook SCSS files not in the correct place HOT 8
- [Dev] normalize.min.css throwing 404's HOT 2
- [UI] Delete Entry dialog text not correct HOT 3
- [UI] Notebook Entry embed links not navigating to live objects HOT 3
- Failure to run gulp verify HOT 1
- Painterro dependency unnecessarily vendored
- Unnecessary changes made to platform
- Naming conventions not followed
- entryDnd directive has unimplemented $destroy listener
- Inappropriate modifications to domain object models
- NotificationLaunchIndicator registered unnecessarily
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openmct.