For regex groups, enclosed by parentheses, | is needed to separate expression 1 or expression 2 (ex. (a|b)). For bracketed expressions, this is not needed (ex. [ab] or [^ab]). These patterns therefore include | as a possible path separator. Seeing as this character will not show up in paths, this is benign.

When I call Edk2ToolsBuild.py without the -t option or pass a missing tool chain tag, the error message (exception) could be better...

Not really an extension issue, but related to building BaseTools the Pytool way.

On a system with multiple versions of Visual Studio and Build Tools, when I did not specify "-t":

(venv_edk2-pytools) C:\git\edk2-platforms-pytools\EDK2\BaseTools>python Edk2ToolsBuild.py
SECTION - Init SDE
SECTION - Loading Plugins
SECTION - Start Invocable Tool
Traceback (most recent call last):
  File "Edk2ToolsBuild.py", line 163, in <module>
    main()
  File "Edk2ToolsBuild.py", line 159, in main
    Edk2ToolsBuild().Invoke()
  File "c:\git\edk2-pytool-extensions\edk2toolext\base_abstract_invocable.py", line 141, in Invoke
    retcode = self.Go()
  File "Edk2ToolsBuild.py", line 120, in Go
    interesting_keys, 'x86', vs_version=self.tool_chain_tag.lower())
  File "C:\git\venv_edk2-pytools\lib\site-packages\edk2toollib\windows\locate_tools.py", line 175, in QueryVcVariables
    popen = subprocess.Popen('"%s" %s & set' % (vcvarsall_path, arch), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
  File "C:\Python\Python37\lib\subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "C:\Python\Python37\lib\subprocess.py", line 1178, in _execute_child
    startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified

Example when specifying an incorrect -t option

(venv_pytools_dev) C:\git\edk2_ovmf\BaseTools>python Edk2ToolsBuild.py -t VS2015x86
SECTION - Init SDE
SECTION - Loading Plugins
SECTION - Start Invocable Tool
Traceback (most recent call last):
  File "Edk2ToolsBuild.py", line 163, in <module>
    main()
  File "Edk2ToolsBuild.py", line 159, in main
    Edk2ToolsBuild().Invoke()
  File "c:\git\edk2-pytool-extensions\edk2toolext\base_abstract_invocable.py", line 141, in Invoke
    retcode = self.Go()
  File "Edk2ToolsBuild.py", line 120, in Go
    interesting_keys, 'x86', vs_version=self.tool_chain_tag.lower())
  File "c:\git\edk2-pytool-library\edk2toollib\windows\locate_tools.py", line 172, in QueryVcVariables
    raise ValueError("Bad VC")
ValueError: Bad VC

This code needs to be updated to support vs2022
https://github.com/tianocore/edk2-pytool-library/blob/master/edk2toollib/windows/locate_tools.py

The Base Parser does not support a DSC file conditional statement such as the following:

!if $(CRYPTO_SERVICES) IN "ALL NONE MIN_PEI MIN_DXE_MIN_SMM"

One of the arguments is a quoted string that needs to be parsed as a single argument.

The IN operator tests for membership. The Base Parser only looks for 'in' and
does not support 'IN', 'In', or 'iN'. Also, when the 'in' operator is present, the
argument to check against membership is converted to an integer. It should
be converted to a list or set to check for membership.

Should set license to "BSD-2-Clause-Patent"

If RunCmd() is used to execute a utility that produces non-UTF8 output, reader() raises UnicodeDecodeError:

File "C:\Development\Devices\Redacted.py", line 105, in Redacted
ret = RunCmd(StitchCmd, params, workingdir=workingDir)
File "C:\Development\VirtualEnv\Development\lib\site-packages\edk2toollib\utility_functions.py", line 186, in RunCmd
thread.join()
File "C:\Development\VirtualEnv\Development\lib\site-packages\edk2toollib\utility_functions.py", line 69, in join
raise self.exc
File "C:\Development\VirtualEnv\Development\lib\site-packages\edk2toollib\utility_functions.py", line 62, in run
self.ret = self._target(*self._args, **self._kwargs)
File "C:\Development\VirtualEnv\Development\lib\site-packages\edk2toollib\utility_functions.py", line 89, in reader
s = stream.readline().decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xae in position 154: invalid start byte

Since it is hard to force all possible things that might be run with RunCmd() to be sane in their output, I think reader needs to pass (errors='ignore') when attempting to decode output.

stuart_ci_build is working when I execute it from the workspace root, but fails when I run it from a subdirectory.

For example, the following works from the Mu_Plus repo workspace root:
mu_plus>stuart_ci_build -c .pytool\CISettings.py -p FirmwarePolicyPkg

But when I change to a subdirectory:
mu_plus\FirmwarePolicyPkg>stuart_ci_build -c ..\.pytool\CISettings.py -p FirmwarePolicyPkg

it fails with

ERROR - --->Test Failed: Compiler Plugin DEBUG returned 1
PROGRESS - --Running FirmwarePolicyPkg: Compiler Plugin RELEASE --
CRITICAL - EXCEPTION: [Errno 2] No such file or directory: 'FirmwarePolicyPkg/FirmwarePolicyPkg.dsc'
CRITICAL - Traceback (most recent call last):
   File "c:\git\venv_1911\lib\site-packages\edk2toolext\invocables\edk2_ci_build.py", line 226, in Go
    tc, plugin_output_stream)
   File "C:\git\FwPolicy\fw_policy\MU_BASECORE\.pytool\Plugin\CompilerPlugin\CompilerPlugin.py", line 80, in RunBuildPlugin
    dp.ParseFile(AP_Path)
   File "c:\git\venv_1911\lib\site-packages\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 259, in ParseFile
    f = open(os.path.join(filepath), "r")
 FileNotFoundError: [Errno 2] No such file or directory: 'FirmwarePolicyPkg/FirmwarePolicyPkg.dsc'

ERROR - --->Test Failed: Compiler Plugin RELEASE returned 1

Hello Developers,
When I use the lastest version of edk2-pytool-library to build Project mu, I meet the exception:

CRITICAL - Build Process Exception
ERROR - Traceback (most recent call last):
  File "d:\uefiworkspace\venv\lib\site-packages\edk2toolext\environment\uefi_build.py", line 152, in Go
    ret = self.Build()
  File "d:\uefiworkspace\venv\lib\site-packages\edk2toolext\environment\uefi_build.py", line 268, in Build
    ret = RunCmd("build", params)
  File "d:\uefiworkspace\venv\lib\site-packages\edk2toollib\utility_functions.py", line 187, in RunCmd
    thread.join()
  File "d:\uefiworkspace\venv\lib\site-packages\edk2toollib\utility_functions.py", line 70, in join
    raise self.exc
  File "d:\uefiworkspace\venv\lib\site-packages\edk2toollib\utility_functions.py", line 63, in run
    self.ret = self._target(*self._args, **self._kwargs)
  File "d:\uefiworkspace\venv\lib\site-packages\edk2toollib\utility_functions.py", line 90, in reader
    s = stream.readline().decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xbe in position 130: invalid start byte

I don't know about Python programming, but based on online search data, I think it might be caused by a string encoding format error.
My system language is Chinese, and the related compilation software is also installed in the Chinese environment. So I think this is the source of this error.
Expect this error to be fixed so that my work can continue.If you need more information, I can provide more logging and testing environments.

When logging level is higher than warning level, the ANSI handler from pytool will inject extra element to the message.

This is a problem when the incoming message is a list as is, since the input list will be updated by this statement and the next consumer using the same list will have an updated list with ANSI information inside.

The code logic in cat_generator.py/inf_generator.py under edk2toollib/windows/capsule don't support VS2015, and only VS2017 or later. This is a back compatibility issue, the code use these two files(previous version) doesn't work now.

Btw, 3 binaries(vswhere.exe, signtool.exe and inf2cat.exe) are touched at least. The first comes from VS2017, 2nd comes from Windows 10 Software Development Kit (SDK) which will be installed if Desktop development with C++ is selected during VS2017 installation. But the 3rd one comes from WDK which should be installed separately.
For the content on web link https://microsoft.github.io/mu/CodeDevelopment/prerequisites/#visual-studio-2017, the WDK may be missed.

After installation, both WDK and SDK will be installed in C:\Program Files (x86)\Windows Kits\10\bin.
Signtool.exe is located in C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x86 and C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64
Inf2cat.exe is located in C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x86 - Question1 - is it correct behavior or I miss something ? no inf2cat.exe under x64.
Question2 - Should SDK and WDK version be consistent (in the same10.X.X.X ) and/or in the top/highest version?

See https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc

DEBUG - Parse Active Platform DSC file: Platform\Intel\KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc DEBUG - Getting all build keys for build type DEBUG ERROR - <class 'edk2toollib.uefi.edk2.parsers.dsc_parser.DscParser'>: Unknown value: gMinPlatformPkgTokenSpaceGuid.PcdBootStage <class 'str'> CRITICAL - Build Process Exception ERROR - Traceback (most recent call last): File "c:\git\edk2-pytool-extensions\edk2toolext\environment\uefi_build.py", line 109, in Go ret = self.SetEnv() File "c:\git\edk2-pytool-extensions\edk2toolext\environment\uefi_build.py", line 378, in SetEnv ret = self.ParseDscFile() File "c:\git\edk2-pytool-extensions\edk2toolext\environment\uefi_build.py", line 492, in ParseDscFile dscp.ParseFile(dsc_file_path) File "c:\git\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 262, in ParseFile self.__ProcessDefines(file_lines) File "c:\git\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 247, in __ProcessDefines self.__ProcessDefines(add) File "c:\git\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 246, in __ProcessDefines (line, add) = self.__ParseDefineLine(l) File "c:\git\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 167, in __ParseDefineLine if(self.ProcessConditional(line_resolved)): File "c:\git\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\base_parser.py", line 310, in ProcessConditional con = self.ComputeResult(tokens[1].strip(), tokens[2].strip(), tokens[3].strip()) File "c:\git\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\base_parser.py", line 160, in ComputeResult raise ValueError("Unknown value") ValueError: Unknown value

Reference

The conditional "!if $(E1000_ENABLE)" fails the "if(len(tokens) < 4)" check because there are only 2 tokens and no conditional operator

It was asked that the parsing objects cache the results across steps. So basically, it would query if it had parsed a given object before and return the results if it had. We'll need to invalidate the hash if the environment has changed.

vswhere is used to locate windows VS tools.

For scenarios where both BuildTools and Visual Studio have been installed, library cannot always find vcvarsall.bat

venv_pytools_dev\lib\site-packages\edk2toollib\bin\vswhere.exe -latest -nologo -all -property installationPath -products *
returns
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools

But vcvarsall.bat is not under the BuildTools path, it is found:

dir /s "c:\Program Files (x86)"\vcvarsall.bat
 Volume in drive C is Local Disk
 Volume Serial Number is F000-B000

 Directory of c:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Auxiliary\Build

09/27/19  01:14 PM             9,889 vcvarsall.bat
               1 File(s)          9,889 bytes

 Directory of c:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build

10/24/19  05:24 PM             9,859 vcvarsall.bat
               1 File(s)          9,859 bytes

 Directory of c:\Program Files (x86)\Microsoft Visual Studio 14.0\VC

02/19/18  08:41 PM             3,600 vcvarsall.bat
               1 File(s)          3,600 bytes

How did I get here?

1. Install VS2017 & VS2019 Build Tools
2. Later install both Visual Studio 2017 Enterprise and 2019 Enterprise
3. Attempt to install VS2015 Build Tools, but it does not really install
4. Modify VS2017 Build Tools to include the VC2015 toolset

The actual, ugly error message is:

DEBUG - Calling 'C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Auxiliary\Build\vcvarsall.bat x86'
CRITICAL - Build Process Exception
ERROR - Traceback (most recent call last):
File "c:\git\edk2-pytool-extensions\edk2toolext\environment\uefi_build.py", line 127, in Go
ret = self.PreBuild()
File "c:\git\edk2-pytool-extensions\edk2toolext\environment\uefi_build.py", line 296, in PreBuild
rc = Descriptor.Obj.do_pre_build(self)
File "C:\git\edk2_py_platforms\Silicon\Intel\Tools\IntelSiliconTools.py", line 37, in do_pre_build
vs_vars = locate_tools.QueryVcVariables(interesting_keys, "x86")
File "c:\git\venv_pytools_dev\lib\site-packages\edk2toollib\windows\locate_tools.py", line 175, in QueryVcVariables
popen = subprocess.Popen('"%s" %s & set' % (vcvarsall_path, arch), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
File "C:\Program Files\Python37\lib\subprocess.py", line 775, in __init__ restore_signals, start_new_session)
File "C:\Program Files\Python37\lib\subprocess.py", line 1178, in _execute_child                                                                                                                                                                                                           startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified

The documentation should be accessible by web.

For example

!if ("GCC49" in $(TOOL_CHAIN_TAG)) OR ("GCC5" in $(TOOL_CHAIN_TAG))

Exception in parser:
CRITICAL - EXCEPTION: ('Invalid conditional', '!if FALSE')

This also will be for FDF parser

It generates several errors like this. It looks like it replaces something like $(MSFT_FAMILY_PKG) to 0 since it can't find it

ERROR - Override processing error FILE_NOT_FOUND in file 0/Override/_____SamplePkg/Library/PeiPolicyInitLib/PeiPolicyInitLib.inf.

Python code is not compliant with the specs defined at EDK II Python Development Process Specification

New support was added for quoted string conditionals as well as upper case IN. This code has no test coverage. Please add.

Results here:
https://lgtm.com/projects/g/tianocore/edk2-pytool-library?mode=list

Add this as a pr requirement once we get clean pass.

Currently, there are many implementations of moving and deleting files (multiple retries, shutil, etc). A standardized error-tolerant approach would be beneficial to many.

should be GetAbsolutePathOnThisSystemFromEdk2RelativePath

There are a few callers in the extensions. So need to figure out right way to fix this.

Is your feature request related to a problem? Please describe.
Remove the markdown logger. This logger isn't being used and just wastes time in the logging path.

Describe the solution you'd like
Remove it

The DEC parser looks for exactly 4 elements in a PCD declaration statement.

There is an optional 5th element that is an open brace '{' to provide a set of
additional lines for a structured PCD. Relax the DEC parser to support up to
5 elements and ignore the DEC file lines between the '{' and '}'

Try to build OvmfPkg.

The FDFs specify:

!if $(E1000_ENABLE)

Results in:

DEBUG - Parse Active Platform DSC file: C:\git\edk2_py_ovmf\OvmfPkg/OvmfPkgIa32X64.dsc
DEBUG - Getting all build keys for build type DEBUG
DEBUG - Parse Active Flash Definition (FDF) file
DEBUG - Getting all build keys for build type DEBUG
ERROR - !if conditionals need to be formatted correctly (spaces between each token)
CRITICAL - Build Process Exception
ERROR - Traceback (most recent call last):
File "c:\git\venv_pytools\lib\site-packages\edk2toolext\environment\uefi_build.py", line 109, in Go
  ret = self.SetEnv()
File "c:\git\venv_pytools\lib\site-packages\edk2toolext\environment\uefi_build.py", line 384, in SetEnv 
  ret = self.ParseFdfFile()
File "c:\git\venv_pytools\lib\site-packages\edk2toolext\environment\uefi_build.py", line 523, in ParseFdfFile 
   fdf_parser.ParseFile(pa)
File "c:\git\venv_pytools\lib\site-packages\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 262, in ParseFile 
   self.__ProcessDefines(file_lines)
File "c:\git\venv_pytools\lib\site-packages\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 246, in __ProcessDefines 
   (line, add) = self.__ParseDefineLine(l) 
File "c:\git\venv_pytools\lib\site-packages\edk2toollib\uefi\edk2\parsers\dsc_parser.py", line 167, in __ParseDefineLine  
   if(self.ProcessConditional(line_resolved)):  
File "c:\git\venv_pytools\lib\site-packages\edk2toollib\uefi\edk2\parsers\base_parser.py", line 271, in ProcessConditional  
   raise Exception("Invalid conditional", text)
Exception: ('Invalid conditional', '!if $(E1000_ENABLE)')

The expected usage is that this define is not present. If someone wants to add E1000 NIC support, the README advises:
'
Add "-D E1000_ENABLE" to your build command
'

The spec says, "When used with the !if or !elseif statements or in an expression used in a value field, a macro that has not been defined has a value of 0".

Continue cleaning up the code and get code coverage to at least 70%.

This issue was discovered as part of a hang observed while running a Project Mu LicenseCheck.

The LicenseCheck plug-in calls RunCmd as follows:

return_buffer = StringIO()
params = "diff --unified=0 origin/master HEAD"
RunCmd("git", params, outstream=return_buffer)

RunCmd was found to hang if the diff generates a large amount of text (in my case, greater than 770K).

The following article suggests why this might be the case:
https://thraxil.org/users/anders/posts/2008/03/13/Subprocess-Hanging-PIPE-is-your-enemy/

This conditional is broken with latest release:
!if ("GCC49" in $(TOOL_CHAIN_TAG)) OR ("GCC5" in $(TOOL_CHAIN_TAG))
...
!endif

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
John Schock had a great solution that we'd like to move to

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

./BasicDevTests.py:51:17: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/path_utilities_test.py:581:14: F541 f-string is missing placeholders
./edk2toollib/uefi/edk2/build_objects/dsc_translator.py:27:13: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/parsers/dsc_parser.py:247:17: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/parsers/base_parser.py:117:13: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/parsers/base_parser.py:601:28: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/parsers/base_parser.py:615:25: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/parsers/base_parser.py:710:28: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/parsers/base_parser.py:721:31: E741 ambiguous variable name 'l'
./edk2toollib/uefi/edk2/parsers/dsc_parser_test.py:62:22: F541 f-string is missing placeholders
./edk2toollib/windows/locate_tools.py:61:27: F541 f-string is missing placeholders

trigger around both master branches

Documentation should be accessible by web. Perhaps automated documentation engine?

According to a new updated spellchecker mtftp is not a word. This is blocking PRs and is most likely caused by a recent change in node/cspell and catching more words.

d:\a\1\s\edk2toollib\uefi\edk2\build_objects\dsc_translator_test.py:429:34 - Unknown word (Mtftp)
d:\a\1\s\edk2toollib\uefi\edk2\build_objects\dsc_translator_test.py:429:44 - Unknown word (Mtftp)

Hi,

I tried the setup as listed here:
https://github.com/tianocore/edk2/blob/master/EmulatorPkg/PlatformCI/ReadMe.md
on Ubuntu 18.04 LTS.

Sumanth@sumanth-VirtualBox:~/edk2$ stuart_setup -c EmulatorPkg/PlatformCI/PlatformBuild.py TOOL_CHAIN_TAG=GCC5
SECTION - Init SDE
SECTION - Loading Plugins
SECTION - Start Invocable Tool
PROGRESS - ## Syncing Git repositories: CryptoPkg/Library/OpensslLib/openssl ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 UnitTestFrameworkPkg/Library/CmockaLib/cmocka MdeModulePkg/Universal/RegularExpressionDxe/oniguruma MdeModulePkg/Library/BrotliCustomDecompressLib/brotli BaseTools/Source/C/BrotliCompress/brotli...
PROGRESS - Done.

PROGRESS - ## Checking Git repository: CryptoPkg/Library/OpensslLib/openssl...
PROGRESS - Done.

PROGRESS - ## Checking Git repository: ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3...
PROGRESS - Done.

PROGRESS - ## Checking Git repository: UnitTestFrameworkPkg/Library/CmockaLib/cmocka...
PROGRESS - Done.

PROGRESS - ## Checking Git repository: MdeModulePkg/Universal/RegularExpressionDxe/oniguruma...
PROGRESS - Done.

PROGRESS - ## Checking Git repository: MdeModulePkg/Library/BrotliCustomDecompressLib/brotli...
PROGRESS - Done.

PROGRESS - ## Checking Git repository: BaseTools/Source/C/BrotliCompress/brotli...
PROGRESS - Done.

SECTION - Summary
PROGRESS - Success

stuart_update -c EmulatorPkg/PlatformCI/PlatformBuild.py TOOL_CHAIN_TAG=GCC5**
SECTION - Init SDE
SECTION - Loading Plugins
SECTION - Start Invocable Tool
SECTION - Initial update of environment
UpdatingWARNING - [SDE] Failed to fetch NugetDependecy: [email protected]: [Nuget] We failed to install this version 2.14.02 of mu_nasm
. Done
SECTION - Second pass update of environment
UpdatingWARNING - [SDE] Failed to fetch NugetDependecy: [email protected]: [Nuget] We failed to install this version 2.14.02 of mu_nasm
. Done
ERROR - We were unable to successfully update 1 dependencies in environment
SECTION - Summary
ERROR - Error

How do i solve this issue on Ubuntu 18.04 LTS.

Regards,
Sumanth

If packages path contains

MU and MU_TIANO

Then when API tries to resolve a file in MU it might return a path in MU_TIANO due to substring matching for path resolution.

I think the order of items matters because there is the case that the later item override the former one. And the order effects the contents some generated files, for example autogen, makefile and build report. we need to keep those files content order same in each build. I think a list for val type will be better, dsc_list?

Originally posted by @BobCF in https://github.com/tianocore/edk2-pytool-library/diffs/2

Since windows is not case sensitive an error has been seen when a caller creates an Edk2Path object with a workspace path drive letter of uppercase and then calls GetContainingPackage with an absolute path with drive letter of lower case.

Python 3.8 RealPath caused drive letter to be uppercase
Python 3.8 AbsPath had drive letter lowercase

GetContainingPackage runs in an endless loop in this case because the exit criteria is never met.
https://github.com/tianocore/edk2-pytool-library/blob/master/edk2toollib/uefi/edk2/path_utilities.py#L134

Review Path Utilities for other case issues, loop conditionals, and assumptions.
Add unit tests for there parameters.

Python 3.8 has been out for a while. Need to update the build system to use 3.8 and resolve any issues.

Printing the returncode of the called command would ease debugging.

Issue A

Conditional looks like !if "XCODE5" not in $(TOOL_CHAIN_TAG) assume TOOL_CHAIN_TAG = VS2019. But it doesn't actually seem to matter what the value of TOOL_CHAIN_TAG is.

File "c:\src_2020_Q1\pytool\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\base_parser.py", line 477, in EvaluateConditional
raise RuntimeError(f"We didn't find an operator to execute in {expression}: {text}")
RuntimeError: We didn't find an operator to execute in ['"XCODE5"', False]: "XCODE5" not in VS2019

Issue B

Conditional looks like !if "IA32" in $(ARCH) || "X64" in $(ARCH)
If ARCH == X64 this works fine.
if ARCH == IA32 this fails to parse

File "c:\src_2020_Q1\pytool\edk2-pytool-library\edk2toollib\uefi\edk2\parsers\base_parser.py", line 145, in ComputeResult
return ivalue in ivalue2
TypeError: 'in ' requires string as left operand, not bool

!if $ (SECURE_BOOT_ENABLE) == TRUE
becomes
0!if $ (SECURE_BOOT_ENABLE) == TRUE
Which means we don't resolve it as a conditional