Giter Club home page Giter Club logo

Comments (4)

matthewfcarlson avatar matthewfcarlson commented on September 26, 2024

We already run flake8, I think the only thing missing is mypy, correct?

from edk2-pytool-library.

matthewfcarlson avatar matthewfcarlson commented on September 26, 2024

We also need to generate documentation

from edk2-pytool-library.

gahan9 avatar gahan9 commented on September 26, 2024

https://edk2-docs.gitbooks.io/edk-ii-python-development-process-specification/content/python_coding_guidelines_and_tools.html specifies guidelines to follow -> PEP 8, PEP 257, PEP 484, however it seems to follow only PEP 484

from edk2-pytool-library.

corthon avatar corthon commented on September 26, 2024

Thanks! Yeah, we know that there are some places that we'd like to add and improve the formatting, but this is currently a gradual effort (mostly as new PRs come in).

The official policy for Python coding style in the edk2-pytools repos can be found here:
https://github.com/tianocore/edk2-pytool-library/blob/master/docs/developing.md#comments

In general, we actively enforce coding style that can be checked programmatically. We'd love PRs that help expand this programmatic testing and would happily start moving the code to adhere to the test. We're also open to PRs that address underlying convention fixes.

from edk2-pytool-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.