Comments (4)
We already run flake8, I think the only thing missing is mypy, correct?
from edk2-pytool-library.
We also need to generate documentation
from edk2-pytool-library.
https://edk2-docs.gitbooks.io/edk-ii-python-development-process-specification/content/python_coding_guidelines_and_tools.html specifies guidelines to follow -> PEP 8, PEP 257, PEP 484, however it seems to follow only PEP 484
from edk2-pytool-library.
Thanks! Yeah, we know that there are some places that we'd like to add and improve the formatting, but this is currently a gradual effort (mostly as new PRs come in).
The official policy for Python coding style in the edk2-pytools repos can be found here:
https://github.com/tianocore/edk2-pytool-library/blob/master/docs/developing.md#comments
In general, we actively enforce coding style that can be checked programmatically. We'd love PRs that help expand this programmatic testing and would happily start moving the code to adhere to the test. We're also open to PRs that address underlying convention fixes.
from edk2-pytool-library.
Related Issues (20)
- [Bug]: fails to install when offline HOT 2
- [Bug]: Invalid reporting for Invalid package path error
- [Bug]: Loading EFiVariableAuthentication2 from Filestream results in exception
- [Feature]: Convert String Attributes (long and short) to Integer and back HOT 1
- [Feature]: Update utility_functions to print a C Array with hexdump to the side and clean up PrintByteList HOT 1
- [Feature]: Update authenticated_variables_structure_support and wincert HOT 2
- [Doc]: Update docs on path_utilities to indicate how slow it is to create this object
- [Bug]: Current capsule generation DestDir follows deprecated convention and needs to be updated to match latest guidance.
- [Bug]: HOT 2
- [Feature]: Add githooks to automate CI testing before the pipeline attempts it HOT 1
- [Bug]: Exception in locate_tools with specific environments HOT 8
- [Feature]: Update to pyproject.toml
- [Feature]: Add Advanced Logging
- [Bug]: Capsule Update broken from OS
- [Feature]: Utilize mkdocs-awesome-pages-plugin v2.9.2
- [Bug]: `base_parser.TargetFilePath` not reverted when exiting an !include parse
- [Bug]: Failed to fully remove ... [WinError 3] The system cannot find the path specified: ...
- [Bug]: Capsules are failing infverif validation HOT 3
- [Bug]: WinRcPath can't find correct path when VS2019 build
- [Feature]: stuart_report and NULL libraries for component-libs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edk2-pytool-library.