Giter Club home page Giter Club logo

Comments (6)

msespos avatar msespos commented on July 27, 2024

I can do this one. Do I need to comment further or should I just go ahead and do it? Thanks!

from javascript-exercises.

twalton83 avatar twalton83 commented on July 27, 2024

@msespos Go ahead, thank you :)

from javascript-exercises.

msespos avatar msespos commented on July 27, 2024

As I'm doing this, I'm noticing that the bullet points at the bottom of the README are somewhat confusing. It looks like there is an "If..." statement with no "then" followup. My proposed edit is below. Should I include it with this edit or make a separate PR? I'm guessing a separate PR.

Proposed edit:

If running npm test repeatString.spec.js returns results similar to the below, make sure you have enabled the rest of the tests, as described in the instructions above.
 Test Suites: 1 passed, 1 total
 Tests:       6 skipped, 1 passed, 7 total

What do you think?

from javascript-exercises.

twalton83 avatar twalton83 commented on July 27, 2024

It can be the same PR, it's just moving an existing bullet

from javascript-exercises.

msespos avatar msespos commented on July 27, 2024

OK thanks!

from javascript-exercises.

msespos avatar msespos commented on July 27, 2024

OK both are done and on the same PR. This is my first PR in response to an open issue (all others have been my own suggestions), so let me know if I need to do anything else on my end or if I'm done, please! Thanks! :)

from javascript-exercises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.