Comments (6)
I can do this one. Do I need to comment further or should I just go ahead and do it? Thanks!
from javascript-exercises.
@msespos Go ahead, thank you :)
from javascript-exercises.
As I'm doing this, I'm noticing that the bullet points at the bottom of the README are somewhat confusing. It looks like there is an "If..." statement with no "then" followup. My proposed edit is below. Should I include it with this edit or make a separate PR? I'm guessing a separate PR.
Proposed edit:
If running npm test repeatString.spec.js returns results similar to the below, make sure you have enabled the rest of the tests, as described in the instructions above.
Test Suites: 1 passed, 1 total
Tests: 6 skipped, 1 passed, 7 total
What do you think?
from javascript-exercises.
It can be the same PR, it's just moving an existing bullet
from javascript-exercises.
OK thanks!
from javascript-exercises.
OK both are done and on the same PR. This is my first PR in response to an open issue (all others have been my own suggestions), so let me know if I need to do anything else on my end or if I'm done, please! Thanks! :)
from javascript-exercises.
Related Issues (20)
- Bug - : 05_sumALL: Returning ERROR with negative numbers HOT 16
- Bug - 04_removeFromArray: missing test case HOT 8
- Bug - Exercises : Test expecting wrong result & typo found
- the sumAll exercise solution code HOT 1
- This is 2nd preview test. HOT 1
- Exercises : Change CommonJS to ESmodule format HOT 1
- Bug - 13_caesar: Test results appear correct but Fail HOT 4
- leapYears README.md HOT 1
- Bug - : tempConversion: Doesn't skip test cases HOT 2
- Feature: Split out exercises by lesson HOT 11
- Fundamentals Part 2, Exercise 3: Instructions Rewrite HOT 7
- Fix unclear functionality definition in 09_palindromes HOT 1
- 05_sumAll: Make clear that negative numbers and non-errors should return ERROR HOT 2
- Add disclaimer about not submitting personal solutions to PULL_REQUEST_TEMPLATE.md for all exercise repos HOT 10
- Foundations: Fix the given example on Fibonacci series in README.md of Javascript exercise(Fundamentals: Part 5) HOT 10
- 07_tempConversion: task needs rephrasing regarding module.exports HOT 5
- Bug - in the authentication basics at the bcrypt.hash function the first argument says "somePassword" which makes it seem like its for a string to name the hash or something when instead it should say req.body.password as that is how the tutorials index.ejs forms password input is setup with name passord : HOT 3
- 03_reverseString: Add alternative solution HOT 8
- Add Spanish translation HOT 3
- 05_sumAll - Add alternative solution using Gauss formula HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javascript-exercises.