Bug - 13_caesar: Test results appear correct but Fail about javascript-exercises HOT 4 CLOSED

I'm wondering if there's some quirk to the fromCharCode method. Maybe there are some invisible characters being added. Or perhaps the terminal is hiding something and making the results appear identical when they are actually different in some way.

After spending way too much time trying to figure this out and getting nowhere because I was doing it purely via the console (which lies) @nguyenlekhtn pointed out on Discord that your code also inserts a null character, so the tests are successfully failing

from javascript-exercises.

You are correct, In your loop, you’re iterating from 0 to string.length + 1, which means you’re going one index beyond the end of the string. probably this should be the correct version of code

const caesar = function(string, shiftValue) {
let encodedString = "";
for (let index = 0; index < string.length; index++) {
let letterUnicode = string.charCodeAt(index);
if ((letterUnicode >= 65 && letterUnicode <= 90) || (letterUnicode >= 97 && letterUnicode <= 122)) { // Alphabetic characters
let base = (letterUnicode < 97) ? 65 : 97;
letterUnicode = ((letterUnicode - base + shiftValue) % 26) + base;
}
encodedString += String.fromCharCode(letterUnicode);
}
return encodedString;
};

from javascript-exercises.

Lol

from javascript-exercises.

Closing as it seems to be resolved + lack of activity. @Jovanysfive if you'd like to elaborate on your comment please feel free, though

from javascript-exercises.