Comments (4)
I'm wondering if there's some quirk to the fromCharCode method. Maybe there are some invisible characters being added. Or perhaps the terminal is hiding something and making the results appear identical when they are actually different in some way.
After spending way too much time trying to figure this out and getting nowhere because I was doing it purely via the console (which lies) @nguyenlekhtn pointed out on Discord that your code also inserts a null
character, so the tests are successfully failing
from javascript-exercises.
You are correct, In your loop, you’re iterating from 0 to string.length + 1, which means you’re going one index beyond the end of the string. probably this should be the correct version of code
const caesar = function(string, shiftValue) {
let encodedString = "";
for (let index = 0; index < string.length; index++) {
let letterUnicode = string.charCodeAt(index);
if ((letterUnicode >= 65 && letterUnicode <= 90) || (letterUnicode >= 97 && letterUnicode <= 122)) { // Alphabetic characters
let base = (letterUnicode < 97) ? 65 : 97;
letterUnicode = ((letterUnicode - base + shiftValue) % 26) + base;
}
encodedString += String.fromCharCode(letterUnicode);
}
return encodedString;
};
from javascript-exercises.
Lol
from javascript-exercises.
Closing as it seems to be resolved + lack of activity. @Jovanysfive if you'd like to elaborate on your comment please feel free, though
from javascript-exercises.
Related Issues (20)
- leapYears README.md HOT 1
- Bug - : tempConversion: Doesn't skip test cases HOT 2
- Feature: Split out exercises by lesson HOT 11
- Fundamentals Part 2, Exercise 3: Instructions Rewrite HOT 7
- Fix unclear functionality definition in 09_palindromes HOT 1
- 05_sumAll: Make clear that negative numbers and non-errors should return ERROR HOT 2
- Add disclaimer about not submitting personal solutions to PULL_REQUEST_TEMPLATE.md for all exercise repos HOT 12
- Foundations: Fix the given example on Fibonacci series in README.md of Javascript exercise(Fundamentals: Part 5) HOT 10
- 07_tempConversion: task needs rephrasing regarding module.exports HOT 5
- Bug - in the authentication basics at the bcrypt.hash function the first argument says "somePassword" which makes it seem like its for a string to name the hash or something when instead it should say req.body.password as that is how the tutorials index.ejs forms password input is setup with name passord : HOT 3
- 03_reverseString: Add alternative solution HOT 8
- Add Spanish translation HOT 3
- 05_sumAll - Add alternative solution using Gauss formula HOT 1
- Move "Hints" section in all exercises to a separate file HOT 2
- Bug - : 03_reverseString - No test case having commas in the input string HOT 3
- Change number to integer in sumAll problem statement HOT 6
- Exercise 12_findTheOldest: Alternative solution HOT 4
- README.md hint doesn't match solution.js HOT 3
- Tests: Refactor Jest tests to Node.js test runner HOT 1
- Refactor existing issue templates the new YAML issue template format HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javascript-exercises.