Giter Club home page Giter Club logo

Comments (11)

codyloyd avatar codyloyd commented on July 27, 2024

The reason we've kept things like this, is because I like to think of them as somewhat removed from the curriculum.

Someone that wanted to brush up on or test their JS knowledge could just jump into this repo and do some practice without the context of the lessons where they're first introduced.

Having said that... i'm not entirely against the idea, if others think it would be useful.

I'm curious what @TheOdinProject/javascript @TheOdinProject/foundations has to say about it.

from javascript-exercises.

01zulfi avatar 01zulfi commented on July 27, 2024

I agree with @codyloyd

Another issue is that the lesson itself could change for multiple reasons. What if we decide to change the lesson title from fundamentals-part-4 to something more descriptive? We would have to echo that change in here. What if we decide to move the removeFromArray exercise to a different lesson? We would have to echo that change in here. There will be significant upkeep involved.

from javascript-exercises.

wise-king-sullyman avatar wise-king-sullyman commented on July 27, 2024

While I do agree with all of the negatives of this change I think it would be worthwhile. I have known several people that got tripped up on what exercises they needed to do and it was a significant impediment for them.

One idea that could alleviate some of these concerns, rather than nesting them in different directories for each lesson we could have a different branch for each lesson.

from javascript-exercises.

Asartea avatar Asartea commented on July 27, 2024

One idea that could alleviate some of these concerns, rather than nesting them in different directories for each lesson we could have a different branch for each lesson.

After all the various issues with the solutions branch, please no. Speaking as a learner Github's branching interface isn't intuitive enough to make branches as a way of separating content usable, especially as this repo also has and will continue to have branches meant to get merged into main, which drowns a "content branch" out

from javascript-exercises.

wise-king-sullyman avatar wise-king-sullyman commented on July 27, 2024

@Asartea From a repo maintenance POV it would be less than ideal, but unless I'm overlooking something from a learner standpoint it seems like branches would potentially be an ideal solution here?

The reason I say that is (at least with the current lesson structure) the fundamentals 4 exercises could live on main, and the remaining exercises are reached shortly after revisiting RPS where branches are introduced, so having those exercises on a separate branch could potentially be great practice with branching to help reinforce the concept. And of course it would likely prevent people from not being sure what exercises they should do during fundamentals 4.

Also, I'm unsure why learners would need to use GitHub's branching interface for this? Could you elaborate on that?

Admittedly though I'm not super familiar with the problems you mention with the solution branch, or at least don't remember them. If you would like to dive deeper into those issues they could sway my opinion.

from javascript-exercises.

codyloyd avatar codyloyd commented on July 27, 2024

I think branches would overcomplicate stuff... if we want things separated that much, we should just do different repos.

I don't think that's a good idea though. I wouldn't be too against organizing these in folders here.. but i don't think anything more convoluted would be helpful.

from javascript-exercises.

wise-king-sullyman avatar wise-king-sullyman commented on July 27, 2024

Yeah I considered different repos as well, but that seems like far more hassle than branches would be.

I'm not opposed to just having folders if we want to just keep things as simple as possible.

from javascript-exercises.

thatblindgeye avatar thatblindgeye commented on July 27, 2024

I feel no matter what there is going to be confusion. Whether we have different directories by lesson, different branches, etc. We try to be clear about what exercises you need to do in an assignment ("Do the following exercises..."). We could be a little clearer both in the initial lesson the exercises are introduced and the repo README ("There are several exercises in the repository that you'll complete over several lessons. Be sure you only complete the exercises assigned.").

The (or one) issue with the previous solutions directory is that it needlessly complicated a user being able to compare their solution to TOP's solution. Having it all in a single branch, but in a separate solutions directory, makes it easier to compare against. Personally I'd be against having separate branches for the different lessons and would prefer just separate directories between the two. I might be in the camp of not doing either for the aforementioned upkeep (updating a branch/directory if a lesson changes, moving an exercise if it's moved to a different lesson, updating all of the links in any lesson that redirects to the directory/branch), but we should also consider how often those kinds of changes happen with these exercises.

@Asartea is there anything about the verbiage used when exercises are assigned that isn't clear, could be improved, etc? I wouldn't be wholly against creating separate directories by lesson in this repo, but wondering if it's more a matter of us not being clear enough.

from javascript-exercises.

thatblindgeye avatar thatblindgeye commented on July 27, 2024

@Asartea checking in if this is something you still feel strongly about? Discussion has died down, but I don't think overall a way forward has been chosen.

from javascript-exercises.

Asartea avatar Asartea commented on July 27, 2024

I mean, its been close to a year since I've thought about this, until I got this ping, so no

from javascript-exercises.

thatblindgeye avatar thatblindgeye commented on July 27, 2024

Will close this for now then, but we can always reopen it to revisit it.

from javascript-exercises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.