Comments (6)
This question is a bit unclear. Are you asking if the test should pass in this case when you return an empty array? Or are you asking a hypothetical? If we aren't testing for it, then you can implement this functionality if you want to on your own, but otherwise as you found it will throw an error.
If there isn't an issue with the exercise itself, or you aren't suggesting we add this test case, I will be closing this issue. Otherwise feel free to expand upon what you meant.
from javascript-exercises.
Pull requests are to make changes to a repository, so that's not really appropriate either :)
I would definitely just discuss this on the Discord channel, but if your tests all pass it's fine. We didn't really intend for you to continue to make your own tests and extend the functionality outside of what was being asked. The tests were specifically structured that way for a reason and this is introductory, the spec is pretty simplistic for that reason.
The curriculum also revisits testing later on, if that's something you're interested in.
from javascript-exercises.
@twalton83 , I implemented an error check and added a test to pass. Maybe I can share my solution and test for more clarity (I did tests on my pc only and tested with downloaded Jasmine version, because I can't install any soft on a machine I'm currently using).
My solution:
const removeFromArray = function(...args) {
let array;
if (!Array.isArray(args[0])) {
array = [];
} else {
array = args[0];
}
const newArray = [];
array.forEach((item) => {
if (!args.includes(item)) {
newArray.push(item);
}
});
return newArray;
}
and a test added to check it:
it('check how it goes when no array passed into', function() {
expect(removeFromArray("1", 3)).toEqual([]);
});
I hope now it is more clear what I would like to say.
from javascript-exercises.
I see, but this isn’t the forum to share solutions. I’m glad you were empowered to extend our tests and the solution.
As this doesn’t appear to be an issue with the exercise itself, this will remain closed, but I encourage you to join the Discord server if you’d like to discuss your solutions further. Issues are more for “there’s a problem with this project”, not solution discussion.
from javascript-exercises.
Sorry if I posted this in the wrong place. I just trying to absorb new things and need confirmation that I'm going the right way. Maybe it would be better to post this in corresponding discord channel or make a pull request. Thanks for your patience.
from javascript-exercises.
Noted.
from javascript-exercises.
Related Issues (20)
- Bug - : 05_sumALL: Returning ERROR with negative numbers HOT 16
- Bug - 04_removeFromArray: missing test case HOT 8
- Bug - Exercises : Test expecting wrong result & typo found
- the sumAll exercise solution code HOT 1
- This is 2nd preview test. HOT 1
- Exercises : Change CommonJS to ESmodule format HOT 1
- Bug - 13_caesar: Test results appear correct but Fail HOT 4
- leapYears README.md HOT 1
- Bug - : tempConversion: Doesn't skip test cases HOT 2
- Feature: Split out exercises by lesson HOT 11
- Fundamentals Part 2, Exercise 3: Instructions Rewrite HOT 7
- Fix unclear functionality definition in 09_palindromes HOT 1
- 05_sumAll: Make clear that negative numbers and non-errors should return ERROR HOT 2
- Add disclaimer about not submitting personal solutions to PULL_REQUEST_TEMPLATE.md for all exercise repos HOT 10
- Foundations: Fix the given example on Fibonacci series in README.md of Javascript exercise(Fundamentals: Part 5) HOT 10
- 07_tempConversion: task needs rephrasing regarding module.exports HOT 5
- Bug - in the authentication basics at the bcrypt.hash function the first argument says "somePassword" which makes it seem like its for a string to name the hash or something when instead it should say req.body.password as that is how the tutorials index.ejs forms password input is setup with name passord : HOT 3
- 03_reverseString: Add alternative solution HOT 8
- Add Spanish translation HOT 3
- 05_sumAll - Add alternative solution using Gauss formula HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from javascript-exercises.