Giter Club home page Giter Club logo

Comments (2)

wyrfel avatar wyrfel commented on June 6, 2024

Nice spotting, thank you for reporting. We solve the same or similar problems in LastnameMapper and SuffixMapper by passing additional constructor options that slightly modify their behaviour. See e.g. here.

We could pass a $mapWithoutLastname option to the constructor here that lowers the count check to a minimum of 2 and changes the loop condition to $k < $length (without the - 1).

Would you like to try implementing this approach?

from name-parser.

francislavoie avatar francislavoie commented on June 6, 2024

Sure, I can give it a shot tomorrow. Thanks!

from name-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.