Giter Club home page Giter Club logo

Comments (3)

wyrfel avatar wyrfel commented on May 26, 2024

Hey @jpmschuler . Thanks for reporting this. Off the top of my head i see no issue in pulling initials that precede the firstname into the firstname parts. Although this could lead to Peter being interpreted as middlename, which i'm not sure if that's what you'd want.
The concept of primary name is interesting, too, and could be added as another property.
And finally, i could also imagine adding a position property to the parts that could enable reconstructing the name in the correct order?
I would love to see what you come up with in a pull-request. Let me know if you need any help.

from name-parser.

jpmschuler avatar jpmschuler commented on May 26, 2024

That's the same idea I had: Having Peter as middle name who adhere to the current architecture. However that would create an unintended result probably. But that depends on the definition of firstname. If one would use the lib for a greeting in a letter "Hello " should resolve to Peter and not to J.

I wondered if it would make sense in general to create a fullgivenname property defined as fullgivenname = fullname - salutation - lastnameprefix - lastname - suffix. Which would prevent a keen mapping, but support all languages.

Alternatively I'd try to make a special language definition which drops the distinguishment between firstname, middlename, initials and moves all parts in firstname.

The concept of primary name was dropped from German legislation, thus I don't think it should be implemented (Their replacement is: You can sort your given names anew as an adult if you want to - and that is no joke).

from name-parser.

jpmschuler avatar jpmschuler commented on May 26, 2024

After some testing it didn't seem reasonable to change the initial detection. The architecture of the mapping is quite keen and shouldn't be adapted and allows an easy adding of fullgivenname. Thus, I think simply adding that new feature will allow broader adoption and will also solve my special case.

from name-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.