Giter Club home page Giter Club logo

Comments (5)

ryancwalsh avatar ryancwalsh commented on May 26, 2024 1

@wyrfel Ahhh, you are right. I was mistaken. I apologize.

Everything works perfectly, and I really appreciate this library! Thanks!

Here is what I used:

class NameParserEnglishAddon extends \TheIconic\NameParser\Language\English {

    const SALUTATIONS = [
        'prof' => 'Prof.'
    ];

    public function getSalutations(): array {//My problem was that I'd neglected to create this function.
        return array_merge(self::SALUTATIONS, parent::SALUTATIONS);
    }

}

from name-parser.

wyrfel avatar wyrfel commented on May 26, 2024

@ryancwalsh Thanks for the compliments.
Yes, you can create your own language class, say RyansEnglish that either extends English or just implements LanguageInterface on its own. You can then instantiate the parser with that class instead of English, like so:

$languages = [
    new RyansEnglish(),
];
$parser = new Parser($languages);

If you want to extend more so than modify, you can also develop your class as an add-on (rather than a replacement) to the English defaults and pass both like so:

$languages = [
    new English(),
    new RyansEnglish(),
];
$parser = new Parser($languages);

Pease let me know if this is what you were after.

(Please note that I have dropped any namespaces in the code examples for brevity.)

from name-parser.

ryancwalsh avatar ryancwalsh commented on May 26, 2024

I'm excited to try this! Thank you!

from name-parser.

ryancwalsh avatar ryancwalsh commented on May 26, 2024

Reopening.

Are you sure this works? I've tried a bunch without luck and think there might be an issue here:

$parser = new Parser();

(and other lines like it) calls $parser = new Parser(); without the languages param.

from name-parser.

wyrfel avatar wyrfel commented on May 26, 2024

Hey @ryancwalsh . Nice spotting, there is indeed a bit of an issue there with the use of the parsers. But it should work, still, because the actual values for salutations etc. are acquired from the languages set on the original parser and then injected right into the mappers when configuring those sub-parsers (just a few lines below the one you quoted).

Can you elaborate or share the full code snippet for the case that doesn't work for you, please?

from name-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.