terraform-community-modules / tf_aws_alb Goto Github PK

Tests are in place, let's get this into CI.

principle is currently gathered statically as a variable, defaulting to us-west-2. Per this document create a variable map and do lookups to get this value.

Create tags on each of the taggable resources using the following pattern: https://github.com/terraform-community-modules/tf_aws_vpc/blob/master/variables.tf#L56

As grabbed from here: https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-security-policy-table.html

Hi @brandoconnor ,

Could you please migrate this module to https://github.com/terraform-aws-modules/terraform-aws-alb ?

Send pull-requests, and we discuss the process as we go. This module is a good candidate to be very feature-rich and powerful.

Thanks,
Anton.

This gives the user the ability to import or have this bucket created on their behalf rather than leaving that up to manual work.

Leveraging this project we should be able to write some tests for this module. It hasn't been attempted yet but a try should be made.

There would be an unsolved problem with CI in terms of cost for those resources... hopefully creating the necessary resources and deleting them immediately afterward is enough to fall within the free AWS tier.

The documentation says that log_prefix, certificate_arn are optional. If I don't set them I get the following:

| => tf validate && tf plan
1 error(s) occurred:

* module root: 
    module alb: required variable "certificate_arn" not set
    module alb: required variable "log_prefix" not set

Here's how I'm using the module

module "alb" {
  source = "modules/terraform-community-modules/tf_aws_alb/alb"

  //alb_is_internal = ""
  //alb_name
  //alb_protocols
  alb_security_groups = "${module.alb_sg.security_group_id_web}"
  aws_region  = "${var.region}"
  aws_account_id = "${var.account_id}"
  //backend_port
  //backend_protocol
  //certificate_arn
  //cookie_duration
  //health_check_path
  log_bucket = "${var.alb_logs_bucket}"
  //log_prefix
  //principal_account_id
  subnets = "${var.alb_subnets}"
  vpc_id = "${module.vpc.vpc_id}"
  //tags
}

Currently this module requires the user to set up S3 access logs (and bucket permissions manually) themselves. I'd like to remove this dependency and make access logging optional, ideally arriving at a way to also provide permissions to the bucket as necessary.