Giter Club home page Giter Club logo

Comments (4)

brandonjbjelland avatar brandonjbjelland commented on May 24, 2024

Hey @hasbro-ielo , thanks for the issue submission. Breaking them down:

re: log_prefix - I'll need to do some further testing to see if terraform is able to get around something like this. It might be that if log_bucket is given, log_prefix also needs to be provided, even if it's a blank variable. There are some real limitations around what can be done within an attribute (like the access_logs block). It might just be an opportunity to clarify the docs on what is actually required.

Re: certificate_arn - this is the issue: the module expects as the default behavior to use HTTPS but that requires a cert. A better out of the box experience (which is more in line with the docs and easier to do) would be defaulting to HTTP. That's a super easy fix I can submit in the next week.

from tf_aws_alb.

hasbro-ielo avatar hasbro-ielo commented on May 24, 2024

Thank you very much for explaining the bit about log_prefix needing to be blank.

from tf_aws_alb.

brandonjbjelland avatar brandonjbjelland commented on May 24, 2024

Sorry for letting this languish. I'm transitioning workplaces at the moment and will have the time to focus on this next week.

from tf_aws_alb.

brandonjbjelland avatar brandonjbjelland commented on May 24, 2024

I think there's a fix here that could be derived from the new locals feature. I'll migrate this issue over to the new repo and plan to look at it shortly.

from tf_aws_alb.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.