Giter Club home page Giter Club logo

Comments (5)

iranl avatar iranl commented on July 23, 2024 1

There ofcourse comes a point where sending the entire config becomes more logical than sending all the needed vars separately, but I'm not sure we are there yet with 2 added vars.

_firmwareVersion = std::to_string(_nukiConfig.firmwareVersion[0]) + "." + std::to_string(_nukiConfig.firmwareVersion[1]) + "." + std::to_string(_nukiConfig.firmwareVersion[2]);
_hardwareVersion = std::to_string(_nukiConfig.hardwareRevision[0]) + "." + std::to_string(_nukiConfig.hardwareRevision[1]);

You can reuse the above code from Nuki(Opener)Wrapper and add these strings (after converting to char*) to publishHASSConfig in Network, NetworkLock and NetworkOpener

from nuki_hub.

duhow avatar duhow commented on July 23, 2024

Additionally for the Nuki Hub, it is also possible to add an update entity:

https://www.home-assistant.io/integrations/update.mqtt/

from nuki_hub.

iranl avatar iranl commented on July 23, 2024

We already have a Home Assistant update entity.

// NUKI Hub update

Because HTTPS OTA is not implemented (yet, it is on my To-Do list) it only notifies you of new versions and links to the release notes. When HTTPS OTA is implemented you will also be able to update with one click from HA.

As to adding HW and SW version to device config I have no objection.
Seeing as you basically already have the code worked out (you would need to add hw/sw in the arguments of publishHASSConfig and call it with these values from Nuki(Opener)Wrapper) is this something you need us to implement or can you create a PR yourself?

from nuki_hub.

duhow avatar duhow commented on July 23, 2024

I can try copy the strings and pass them to the function, however I was expecting something more like "sending the whole device variable data", but the few attempts I did were not successful...

So I raised this issue more to have an agreement on, how would should we proceed best?

from nuki_hub.

mundschenk-at avatar mundschenk-at commented on July 23, 2024

I haven't been following all the recent PRs in detail, but one thing I wanted to change for some time is untangling Nuki Hub and the Nuki Smart Lock in HA. Ideally, there should be separate devices in HA for the Nuki Hub, the Smart Lock and the Opener (and maybe the Keypad and the Door Sensor, though I don't know if the BLE API includes enough information about those to warrant handling them as separate devices).

The Lock and Opener would be connected via the Hub. (I have it all written down on paper, but making a nice RFC about it was delayed all the time.), and each device could display its correct HW and FW version via the HA device registry. There's currently a draft PR for enabling a new device-based discovery schema for HA (it was merged already, but got pulled out of 2024.6.0 at the last minute), which would greatly reduce the number of discovery messages that need to be sent.

from nuki_hub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.