Giter Club home page Giter Club logo

Comments (25)

nicolaferraro avatar nicolaferraro commented on July 18, 2024

Don't know about the version, @valdar can help on that. AFAIK Camel K is now built in the pipeline and we should update that version field to whatever is built there.

There is an additional step to do to enable camel k that is:

  • adding/changing the value of controllers->integration to camel-k in the syndesis-server-config configmap
  • restarting syndesis-server

I don't know if it's better adding a script that does that or documenting it. Long-term I think that camel k should be configurable in the syndesis custom resource and the operator should configure the platform for using the right engine.

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

In CR1 it was this one: fuse7/fuse-camel-k:fuse-7.3-rhel-7-containers-candidate-81569-20190321124048 (See https://issues.jboss.org/browse/ENTESB-10310)

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

It's even worse: https://github.com/syndesisio/fuse-online-install/blob/master/install_ocp.sh#L602

It seems to pull community bits in fuse-online-install.

@valdar @nicolaferraro Can you update the scripts to work with prod versions?

from fuse-online-install.

valdar avatar valdar commented on July 18, 2024

There are others requirements:

  • All the maven artefacts must be reachable to camel-k so probably --camel-k-options "--repository https://$GA_REPO" --camel-version <syndesis_camel_version> (i.e. 2.21.0.fuse-730074) --runtime-version <camel-k-runtime_version> (i.e. 0.3.1) should be used.
  • Camel syndesis version catalog must be installed in the cluster, it is published as part of install of integration/runtime-camelk like:
    • mvn org.apache.maven.plugins:maven-dependency-plugin:copy -Dartifact=io.syndesis.integration:integration-runtime-camelk:<syndesis_version>:yaml:catalog -DoutputDirectory=./
    • oc apply -f ./integration-runtime-camelk-<syndesis_version>-catalog.yaml

from fuse-online-install.

valdar avatar valdar commented on July 18, 2024

@heiko-braun We had a chat with @orpiske and @djcoleman, asked to add kamel binary to the productized image so we can use that one, without the need of relaying to the upstream version. We had reviewed the image build script that now should properly generate and include the right version of the catalog sparing the need of installing it from maven (i.e. see the second item on my last comment).

Once the new image is generated and the install script updated to use it, we can have an install run and see if this is fixed.

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

Great, thanks for following up on this. If I understand you correctly, with those changes in place, both the kamel binary and the catalog will be delivered by the prod team? How to we get access to those artefacts?

from fuse-online-install.

valdar avatar valdar commented on July 18, 2024

That is the expectation. We should grab the image from the registry and use the kamel binary from there.

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

The catalog as well?

from fuse-online-install.

valdar avatar valdar commented on July 18, 2024

The catalog, if we envisioned everything correctly, should be "backed in to the camel-k operator".

from fuse-online-install.

valdar avatar valdar commented on July 18, 2024

@orpiske and @djcoleman given jboss-fuse/camel-k#1 and nicolaferraro@5ee832f can you give camel-k image creation another go?

from fuse-online-install.

orpiske avatar orpiske commented on July 18, 2024

@valdar I think we can. Looking at these patches, it seems to me we will need a new PNC build, right @djcoleman?

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

@valdar Cool, are we all set?

from fuse-online-install.

valdar avatar valdar commented on July 18, 2024

@nicolaferraro is doing last tests to check all the flow, but he needs the rebuilt image to actually test all the exact flow of installation...

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

ok, let's leave it open for the time being until @nicolaferraro confirmed that it's working as expected

from fuse-online-install.

nicolaferraro avatar nicolaferraro commented on July 18, 2024

Yeah, this needs to be backported to 1.6.x and I'm still having some issues. It's still using camel 2.23.1 inside..

from fuse-online-install.

avano avatar avano commented on July 18, 2024

@nicolaferraro

local image_sha=$(docker inspect $image --format='{{index .RepoDigests 0}}' | sed 's/.*\://')

just a note, this will parse nothing until you have the image pulled locally

@heiko-braun do we want to require the users to have docker installed? Currently when you run install_ocp.sh, the script will pull the camel-k docker image to your pc to copy the kamel binary from it. Can't we release the binary as a separate artifact? 🤔 @orpiske ?

cc @tplevko

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

A dependency on docker should be prevented, but since this is TP, I would say it's ok this time around

from fuse-online-install.

nicolaferraro avatar nicolaferraro commented on July 18, 2024

Thanks @avano, will fix.
Agree, we need to simplify this a bit in 7.4.

from fuse-online-install.

mmuzikar avatar mmuzikar commented on July 18, 2024

I used @avano's fork and were able to get the camel-k operator running, but I got these errors on the camel-k operator:

E0412 12:31:08.876235 1 reflector.go:134] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers_map.go:126: Failed to list *v1alpha1.IntegrationPlatform: v1alpha1.IntegrationPlatformList.Items: []v1alpha1.IntegrationPlatform: v1alpha1.IntegrationPlatform.Spec: v1alpha1.IntegrationPlatformSpec.Build: v1alpha1.IntegrationPlatformBuildSpec.Registry: ReadString: expects " or n, but found {, error found in #10 byte of ...|egistry":{},"reposit|..., bigger context ...|-88f2-52540063a234"},"spec":{"build":{"registry":{},"repositories":["https://origin-repository.jboss| ...

from fuse-online-install.

avano avatar avano commented on July 18, 2024

Martin used the branch test from my fork where I cherry-picked the two commits from #95 to 1.6.9 tag

from fuse-online-install.

orpiske avatar orpiske commented on July 18, 2024

...

@heiko-braun do we want to require the users to have docker installed? Currently when you run install_ocp.sh, the script will pull the camel-k docker image to your pc to copy the kamel binary from it. Can't we release the binary as a separate artifact? thinking @orpiske ?

cc @tplevko

I don't think we have time for that on this release, @avano. I think we could discuss about that for 7.4, though.

from fuse-online-install.

nicolaferraro avatar nicolaferraro commented on July 18, 2024

Martin used the branch test from my fork where I cherry-picked the two commits from #95 to 1.6.9 tag

I see, it seems a mismatch between the go struct and the actual resource, but I don't experience it.
Can you check if the image of the camel-k-operator deployment is the one coming from brew and also provide the output of oc get integrationplatform -o yaml?

from fuse-online-install.

mmuzikar avatar mmuzikar commented on July 18, 2024

@avano I just noticed I forgot to checkout the Test branch (which is not working) I was able to get the camel-k operator running on master.

@nicolaferraro > oc get integrationplatfrom -o yaml
error: the server doesn't have a resource type "integrationplatfrom"

from fuse-online-install.

heiko-braun avatar heiko-braun commented on July 18, 2024

@avano @orpiske @nicolaferraro I have created a separate issue to remove the need to have docker available: #107 it's scheduled for 7.4

from fuse-online-install.

nicolaferraro avatar nicolaferraro commented on July 18, 2024

I think this can be closed, as issues related to camel k have been solved.

from fuse-online-install.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.