Giter Club home page Giter Club logo

Comments (13)

nicolaferraro avatar nicolaferraro commented on August 17, 2024 1

Ok, let's workaround that on fuse-online-install and I'll fix it completely on syndesis master only.

from fuse-online-install.

lgarciaaco avatar lgarciaaco commented on August 17, 2024 1

I find discrepancies in the content of the roles, in the following files:

fuse-online-install/install_ocp.sh
fuse-online-install/templates/fuse-online-operator.yml
syndesis/install/generator/05-syndesis-security.yml.mustache
syndesis/install/operator/deploy/syndesis-operator.yml

We have to keep those 4(and mb I am forgetting some other files ) files always aligned, ideally with rules in the same order so we can spot different in the future.

from fuse-online-install.

heiko-braun avatar heiko-braun commented on August 17, 2024

@avano Which tag did you use?

from fuse-online-install.

avano avatar avano commented on August 17, 2024

1.7.17

from fuse-online-install.

heiko-braun avatar heiko-braun commented on August 17, 2024

@avano Does it work as expected on 3.11?

from fuse-online-install.

avano avatar avano commented on August 17, 2024

yes, on 3.11 it seems to work ok

from fuse-online-install.

lgarciaaco avatar lgarciaaco commented on August 17, 2024

I will add the permissions independently of ./install_ocp.sh targeting 3.11 and not 4.x, just to keep things even @heiko-braun ? I suspect those permissions were added for some camelk related things, @nicolaferraro?

from fuse-online-install.

nicolaferraro avatar nicolaferraro commented on August 17, 2024

No it's not camel-k related. The standard ocp 3.11 edit clusterrole (from which the permissions have been taken) has ["get" "list" "watch"] on "deployments/rollback", but it has been removed on ocp 4.

We can remove the full entry about deployments/rollback since we don't use it at all. That can be done on master + 1.7.x.

If we don't plan to do another Fuse build, we can also patch fuse-online-install to grant that permission on the install user ("--grant" option).
Do we plan to do another build?

from fuse-online-install.

heiko-braun avatar heiko-braun commented on August 17, 2024

@nicolaferraro It's not clear if we rebuild. If it can be solved in fuse-online-install, that might be preferrable.

from fuse-online-install.

nicolaferraro avatar nicolaferraro commented on August 17, 2024

Ok, let's workaround that on fuse-online-install and I'll fix it completely on syndesis master only.

Only problem is the eval cluster. If we don't rebuild, we should remove the "deployments/rollback" entry manually from the template we provide to users. Btw, is that template created manually?

from fuse-online-install.

nicolaferraro avatar nicolaferraro commented on August 17, 2024

Oh, if the eval cluster is not OCP4 that's not an issue...

from fuse-online-install.

heiko-braun avatar heiko-braun commented on August 17, 2024

Eval is still on 3.11

from fuse-online-install.

avano avatar avano commented on August 17, 2024

works ok now when cherry-picking the commit to 1.7.17 tag

from fuse-online-install.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.