[Upgrade] Upgrade never completes as it is missing the komodo image stream about fuse-online-install HOT 14 CLOSED

@heiko-braun fyi

from fuse-online-install.

@avano thanks

from fuse-online-install.

We stopped doing few things the update_ocp.sh script relies on:

• We shouldn't call docker images with - as part of the name, ideally they are called with a simple word, like server, meta and so on. When we start using wordings like komodo-server or postgres-exporter it all gets nasty. We need a simpler name for these images. I would suggest to call komodo just komodo, and postgres exporter pexporter.
• The script assumes that docker images are called $PREFIX + $NAME, where prefix is fuse-ignite and name is meta, server AND komodo, the docker image should be called: fuse-ignite-meta, fuse-ignite-server AND fuse-ignite-komodo (which is called data-virtualization-server-rhel7:$tag, and for postgres exporter fuse-postgres-exporter:$tag). We need the same image prefix for komodo and postgres exporter than the rest of the images.

I could work around these issues without changing the image names. We have to go back to the mentioned standards.

from fuse-online-install.

We need the same image prefix for komodo and postgres exporter than the rest of the images.

I am afraid this is not possible at this stage, and I don't think we should make assumption about the image name prefixes in the script. Why no simply call them out fully?

from fuse-online-install.

We need the same image prefix for komodo and postgres exporter than the rest of the images.

I am afraid this is not possible at this stage, and I don't think we should make assumption about the image name prefixes in the script. Why no simply call them out fully?

Sure it wont be possible at this stage, but why not give things simple names like the ones I recommended? That shouldn't be an issue for next release or so.

There is a relation between name and few other elements: for name server, the image tag is tag_server here ), and the the name of the ImageStream (fuse-ignite-server) and the image itself (registry/repo/fuse-ignite-server) are build based on that prefix and the name here

from fuse-online-install.

No objection for simple names

from fuse-online-install.

@avano can you please test ^^

from fuse-online-install.

After thinking and talking about this, we don't include external bits in the upgrade process. Removing komodo and the exporter should fix the problem

from fuse-online-install.

@lgarciaaco @heiko-braun removing the datavirt image stream now causes the upgrade pod to wait indefinitely, as it is waiting for komodo-server to be scaled to 1:

=== * Restart all deployments (upgrade_60_restart_all)
deploymentconfig.apps.openshift.io/komodo-server scaled
deploymentconfig.apps.openshift.io/syndesis-db scaled
deploymentconfig.apps.openshift.io/syndesis-meta scaled
deploymentconfig.apps.openshift.io/syndesis-oauthproxy scaled
deploymentconfig.apps.openshift.io/syndesis-prometheus scaled
deploymentconfig.apps.openshift.io/syndesis-server scaled
deploymentconfig.apps.openshift.io/syndesis-ui scaled
Waiting for komodo-server to be scaled to 1

and obviously since there is no image stream for komodo, it waits forever and the upgrade never completes.

also leaving out the datavirt server from the upgrade means that user can't use datavirt when upgrading from 7.3.1 to 7.4

from fuse-online-install.

@lgarciaaco I guess this means we need to include komodo at least. Maybe we can add a new section to the scripts for new images, that need to be added during the update procedure?

from fuse-online-install.

#180 removes some code that was needed for previous upgrade, but not needed anymore. It was creating the IS for komodo. I think the upgrade pod wont be trying for it anymore.

from fuse-online-install.

@avano can you cherry pick and try? I don't think you need to do a release for it.

from fuse-online-install.

fixed on 1.7.x branch

from fuse-online-install.

Good work, thanks guys!

from fuse-online-install.