Comments (7)
Would you mind submitting a PR with your fixes?
from spree_product_zoom.
Hi Jeff,
What is a PR?
Venlig hilsen / Kind regards
Thomas K. Schmidt
Kruby
+45 40 19 68 81
www.kruby.dk
Den 25/11/2014 kl. 17.33 skrev Jeff Dutil [email protected]:
Would you mind submitting a PR with your fixes?
—
Reply to this email directly or view it on GitHub.
from spree_product_zoom.
❤️ Pull Request ❤️
from spree_product_zoom.
Ok. New at this particular thing with GitHub.
I am just tying up a few ends.
Trying to DRY up things a bit.
Will update my first post as well.
from spree_product_zoom.
I did the Pull Request. Disregard my very first solution.
I boiled it down to changing just one file.
Hope you agree.
from spree_product_zoom.
Hi, the modal is not showing up. Also when the mouse its over the image then the label "zoom" at the image bottom it is replaced by another image similar, and the result it is two similar images.
On click the image, the app it is opening the image in the current tab.
My app it is running:
- rails 4.1.8
- spree 2.4.1
from spree_product_zoom.
@alanalvespi I was having the exact same problems as you. I did a fresh install of spree 2.4.5 and then added spree_product_zoom before installing any other extensions. Then I installed the spree_fancy theme and it continued to work.
Update:
I tracked down my problem by reinstalling everything piece by piece from scratch. My jssor slider setup js file was interfering with the zoom extension.
from spree_product_zoom.
Related Issues (20)
- Variant images not zooming HOT 4
- Clicking on Image brings up dialogue box to download HOT 3
- CSS styles trampled after installing spree_product_zoom HOT 1
- Duplicate product image HOT 3
- uninitialized constant Spree::ProductZoomConfiguration (NameError) HOT 1
- Clicking on Image or zoom button always brings up the 'main' image HOT 13
- Method to change default style HOT 5
- SystemStackError in Spree/products#show => After updating to latest spree Stable 1.2 HOT 3
- Not working after upgrade to latest spree 1.3-stable (1.3.3 beta) HOT 2
- NoMethodError when rendering product page with variants HOT 5
- zoom links to image rather than opening lightbox HOT 2
- out of date with spree, should create a 2-1-stable branch and bump master to 2.2.0.beta HOT 2
- Not work with spree_front_end and spree_fancy HOT 1
- Zoom clicked image in gallery HOT 2
- In Spree-2.1 arrows are not shown in production
- Licensing of fancyBox HOT 2
- make it work with spree master HOT 1
- Does this gem works with spree 3.0.0 HOT 1
- Does this gem works with Spree 3.1?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spree_product_zoom.