Giter Club home page Giter Club logo

Comments (7)

JDutil avatar JDutil commented on July 25, 2024

Would you mind submitting a PR with your fixes?

from spree_product_zoom.

kruby avatar kruby commented on July 25, 2024

Hi Jeff,

What is a PR?


Venlig hilsen / Kind regards
Thomas K. Schmidt

Kruby
+45 40 19 68 81
www.kruby.dk

Den 25/11/2014 kl. 17.33 skrev Jeff Dutil [email protected]:

Would you mind submitting a PR with your fixes?


Reply to this email directly or view it on GitHub.

from spree_product_zoom.

futhr avatar futhr commented on July 25, 2024

❤️ Pull Request ❤️

from spree_product_zoom.

kruby avatar kruby commented on July 25, 2024

Ok. New at this particular thing with GitHub.
I am just tying up a few ends.
Trying to DRY up things a bit.
Will update my first post as well.

from spree_product_zoom.

kruby avatar kruby commented on July 25, 2024

I did the Pull Request. Disregard my very first solution.
I boiled it down to changing just one file.
Hope you agree.

from spree_product_zoom.

alanalvespi avatar alanalvespi commented on July 25, 2024

Hi, the modal is not showing up. Also when the mouse its over the image then the label "zoom" at the image bottom it is replaced by another image similar, and the result it is two similar images.

On click the image, the app it is opening the image in the current tab.

My app it is running:

  • rails 4.1.8
  • spree 2.4.1

from spree_product_zoom.

crystalized avatar crystalized commented on July 25, 2024

@alanalvespi I was having the exact same problems as you. I did a fresh install of spree 2.4.5 and then added spree_product_zoom before installing any other extensions. Then I installed the spree_fancy theme and it continued to work.

Update:
I tracked down my problem by reinstalling everything piece by piece from scratch. My jssor slider setup js file was interfering with the zoom extension.

from spree_product_zoom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.