Giter Club home page Giter Club logo

Comments (5)

kotesh avatar kotesh commented on August 28, 2024

@cameel
I just removed 'if v.available?' and one 'end' from spree_product_zoom/app/views/spree/products/_thumbnails.html.erb now both zoom and variant functionalities are working fine

from spree_product_zoom.

cameel avatar cameel commented on August 28, 2024

Yeah. That check seems to be superfluous. Variants are selectable on the product page even when they're unavailable (I assume this means out of stock) and I don't see any advantage to hiding their photos in that situation.

from spree_product_zoom.

marrax avatar marrax commented on August 28, 2024

I've just come across the same error, runing spree 2.1.3. I'm new to git , how do it get this fixed ?
I can manually apply the fixes but every time I bundle update/install it reoccurs.

from spree_product_zoom.

JDutil avatar JDutil commented on August 28, 2024

should be fixed now by #27 let us know if you continue having problems.

from spree_product_zoom.

artemaminov avatar artemaminov commented on August 28, 2024

spree 2-0-stable, replace "v.available?" with "v.in_stock?"

from spree_product_zoom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.