sonnylazuardi / react-native-credit-card Goto Github PK

Hi @sonnylazuardi,

I would like to play with your library, can you please share your sample implementation (as shown in the gif on your README)? It would come highly in handy, nice work by the way.

Thanks

not support and catch error
ViewPropTypes has been removed

Hi there,

I installed normally using yarn and noticed that the npm package is outdated. By specifically using the github repository works fine.

It would be good to update the npm version to the latest.

The extra space used by VALID THRU often causes the card holder name to be displayed in two lines. This don't match what is printed in the actual card.

Given that the current design already have a self explanatory text Month\Year I recommend removing the valid thru text.

There should be a prop to change the text of 'VALID THRU' and 'MONTH/YEAR' because of i18n.

Amex CVV is located in the front, ideally the card should not flip this UI is only expected in Visa and MasterCard cards

https://github.com/facebook/react-native/releases/tag/v0.36.0

We need to remove some flex: 1 to make it work again

I'm unable to change/remove the card labels such as "FULL NAME", "MONTH/YEAR", even if I try to use a frontImage the text will still be displayed

Found this, after click on description's link:
Could u update expo version to 23+ ?

Visa and MasterCard images logos are outdated, both card schemes introduced new simpler Logos.

I tried to use it like this:

<CreditCard
style={{
marginVertical: 10,
marginHorizontal: 10,
marginBottom: 0,
elevation: 3,
alignSelf: "center"
}}
type={this.state.type}
imageFront={require("./images/card-front.png")}
imageBack={require("./images/card-back.png")}
shiny={true}
bar={false}
focused={this.state.focused}
number={this.state.number}
name={this.state.name}
expiry={this.state.expiry}
cvc={this.state.cvc}
/>

But nothing is showing.

https://github.com/sonnylazuardi/react-native-credit-card/blob/master/index.js#L39-L41