sirinapha88 / galvanize-reads Goto Github PK

Comments on General Best Practices:

You checked in your node modules, don't do that. Instead just make sure all your dependencies are in your package.json.
Also make sure to have a .gitignore file!

CRUD && Knex:

You don't have any server-side validations- you should always check to see whether or not someone has filled out all of the required fields, and that they're valid (ie, URLs are actually URLs). Also check to make sure that foreign keys actually exist if you're inserting them.

SQL Schema:

Your schema didn't contain any foreign keys, which are used to associate rows with other rows. Books with authors, or authors with books. Normally we use a join table for this- creating an entire table with a reference to both an author and a book, like so:

id author_id book_id
1   1           2
2   1           3

Then we could figure out that the author with an ID of 1 has written books with ids 2 and 3.

Login & user vs admin:

You didn't include login, but you did include it in your project so I'm aware you know how to do it.

Frontend: Interactions and Style

Good linking the books and authors list pages, but we did want to have a link between a book and it's actual author. I think what stopped you here was figuring out how to make a join table, and write the associated knex.