galvanize-reads's Introduction
galvanize-reads's People
galvanize-reads's Issues
Comments on Project
Comments on General Best Practices:
You checked in your node modules, don't do that. Instead just make sure all your dependencies are in your package.json.
Also make sure to have a .gitignore file!
CRUD && Knex:
You don't have any server-side validations- you should always check to see whether or not someone has filled out all of the required fields, and that they're valid (ie, URLs are actually URLs). Also check to make sure that foreign keys actually exist if you're inserting them.
SQL Schema:
Your schema didn't contain any foreign keys, which are used to associate rows with other rows. Books with authors, or authors with books. Normally we use a join table for this- creating an entire table with a reference to both an author and a book, like so:
id author_id book_id
1 1 2
2 1 3
Then we could figure out that the author with an ID of 1 has written books with ids 2 and 3.
Login & user vs admin:
You didn't include login, but you did include it in your project so I'm aware you know how to do it.
Frontend: Interactions and Style
Good linking the books and authors list pages, but we did want to have a link between a book and it's actual author. I think what stopped you here was figuring out how to make a join table, and write the associated knex.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.