simverge / pdal-c Goto Github PK

Is your feature request related to a problem? Please describe.
The pdal-c build in Travis CI currently analyzes code coverage with gcov but the results are not retrieved. SoundCloud provides a way to import gcov reports.

Describe the solution you'd like
Incorporate the gcov results generated in Travis CI to SoundCloud by following the instructions in the SonarCFamily wiki page.

Describe alternatives you've considered
Set the sonar.cfamily.gcov.reportsPath value in sonar-project.properties to the location of the gcov reports. According to tests/travis/script.sh, these should be located in build/$DISTRO-$ARCH-$BUILD_TYPE, where $DISTRO can be either alpine or ubuntu and $BUILD_TYPE can be either Debug or Release. $ARCH is determined from uname -m and will likely be x86_64 for both the Alpine and Ubuntu Docker containers.

Additional context
You can use environment variables in sonar-project.properties in this form: ${env.VAR_NAME}. See SonarQube Scanner CLI issue SQSCANNER-9.

Edit - Fixed Markdown formatting

Describe the bug
Coverity Scan reported 35 faults on its scans from 30-Apr-2019 and 09-May-2019. These faults are all reported in the unit tests and include:

• 6 instances of Argument cannot be negative (CWE-687)
• 4 instances of Ignoring number of bytes read (CWE-252)
• 26 instances of Resource leak (CWE-404)

To Reproduce
Refer to the Coverity Scan report to see where each fault is reported.

Expected behavior
Coverity Scan should report no faults. Faults may be marked as Ignored on a case-by-case basis if warranted.

Create a Travis CI configuration file (.travis.yml) for building the pdal-c master branch.

Refer to the existing GitLab CI configuration file (.gitlab-ci.yml) for an example. If possible, use the Docker images at simverge/pdalc-build-deps for the builds, since they simply extend pdal/pdal Docker images. Dockerfiles for Alpine and Ubuntu images are in the pdal-c repository's tests/docker directory.

Update the root README.md to report the status of the pdal-c build on a badge.