Dynamic method called as static about simpletest HOT 5 CLOSED

Hey Guillaume, thank you for bug-reporting. We will look into the issue.

• fixed simpletest/extensions/coverage related issues - 4566ea3
• fixed simpletest/test/site/ related issues

from simpletest.

Hello jakoch,

You're welcome ;)

Any news regarding the issues on simpletest/test/sites/*?
If you wish I can make a pull requests.

Thanks,

Guillaume

from simpletest.

Hey Guillaume,

yes, there are some news: i've re-enabled the acceptance tests for simpletest/test/sites/*
and removed some errors and notices along the way.
We could now also remove the static calls, e.g. PostRequest:get().

It would be very helpful, when you find the time to send some pull requests.
I really appreciate any help.

Thanks, Jens

from simpletest.

Hello jakoch,

Methods get() and post() of the PostRequest class are now static methods since your last commit bec40cc. So I think the problem is resolved? I do not understand the benefits of removing the static calls.

Thanks,

Guillaume

from simpletest.

Yes, its resolved.

I've added static to solve the initially reported E_STRICT issue: calling dynamic method statically.
Now "static" itself is often problematic, because it introduces global state and makes things hard(er) to test, but (sometimes) faster. The benefits of removing static calls is to improve test-ability in the long run. But as you can see: i've used the simple fix for the problem.. ;)

Thank you for raising the issues and providing feedback.
Best, Jens

from simpletest.