[Peggy] Static Analysis (Med) - CosmosBridge.newProphecyClaim is an uninitialized local variable about sifnode HOT 6 CLOSED

Slither recommends local variables to always be explicitly initialized. We usually treat this as a false positve

from sifnode.

@ElliotFriedman and @stbeyer do you believe this to be a false positive in this instance?

from sifnode.

yes, it's a false positive, because it is assigned in 2 out of 3 branches in the code and the third one reverts.
Slither is opinionated here in that it recommends always initializing this type of variable to 0 explicitly, instead of relying on the default values (which is address(0)).
I personally don't agree with this, since default values are clearly defined for all variable types in Solidity.

from sifnode.

I personally don't agree with this, since default values are clearly defined for all variable types in Solidity.

Based on this, I'll exclude uninitialized-local detector warnings in the slither config file. That will prevent this warning appearing in the future.

from sifnode.

from sifnode.

This has been fixed in Slither config.

from sifnode.