HAL-07 downcasting of 64-bit integer about sifnode HOT 4 CLOSED

According to the go doc, Atoi is equivalent to ParseInt(s, 10, 0). I don't see there is necessity to use ParseInt. We can close it after one more agreement from @Brando753 @smartyalgo @banshee

from sifnode.

So the issue is:
AtoI outputs int32/int64 depending on the machine.
This could be an issue if downstream expects int32, and we're passing int64
e.g.
In cli/tx.go

func GetCmdUpdateWhiteListValidator() *cobra.Command {
...
188 power , err := strconv . Atoi ( args [2])

power is type int, aka int64 depending on the machine. Later on, it is cast as uint32 to updateWhiteListValidator, thus downcasting.
if caller tries to update validator power to 4294967296 (max uint32 + 1), the uint32 cast results in 0

ParseInt returns an err, which will tell us when string input is out of range, thus preventing input beyond int32 range

	var power64string string = "9223372036854775807"

	power32, err := strconv.ParseInt(power64string, 10, 32)
	if err != nil {
		fmt.Println("Errored", err)
	}
	fmt.Println(power32)

Gives

Errored strconv.ParseInt: parsing "9223372036854775807": value out of range
2147483647

from sifnode.

I agree, ParseInt can avoid this downcasting error. will create a PR to fix it.

from sifnode.

close it after #3287 merged.

from sifnode.