Comments (3)
juniuszhou
commented on September 14, 2024
I don't understand why not panic, if there is a serous issue, we really need to stop the node, even the chain. then we should panic, in some context, return an error and continue doesn't make sense and chain will be messy situation.
from sifnode.
juniuszhou
commented on September 14, 2024
I prefer we still use panic and won't fix.
from sifnode.
pandaring2you
commented on September 14, 2024
@smartyalgo asked for clarification from halborn on the appropriate time to panic since panics are used in cosmos sdk as well. michael to follow up. remaining item: review areas to determine if we actually need a panic.
from sifnode.
Related Issues (20)
- HAL-03 lack of validation on setblacklist message HOT 2
- HAL-04 sensitive information in environment variables HOT 2
- HAL-05 lack of validation of ethereum address formats HOT 7
- HAL-06 iteration over map source of non-determinism HOT 10
- HAL-07 downcasting of 64-bit integer HOT 4
- HAL-09 hardcoded mnemonic phrases in the repository HOT 1
- HAL-10 use of outdated solidity version HOT 4
- HAL-12 open todos HOT 2
- HAL-14 unused variables HOT 2
- Add peggy2 test case for a token that does a reentrant lock/burn
- Peggy2 protobuf files need to be compatible with peggy1 HOT 2
- saw in the validator logs `module=x/ibc/channel sequence="marshaling error: json: unsupported type: func() uint64"`
- Add missing integration test to github action
- Enhance Non-Rowan Yield Reward Functionality with Optional Duration Feature HOT 3
- Enhance Non-Rowan Yield Reward Functionality with Optional Duration Feature
- Enhance Non-Rowan Yield Reward Functionality with Optional Duration Feature HOT 1
- Enhance Non-Rowan Yield Reward Functionality with Optional Duration Feature HOT 2
- Enhance Non-Rowan Yield Reward Functionality with Optional Duration Feature HOT 1
- The SifChain website should be revamped
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sifnode.