sf-wdi-labs / tunely-angular Goto Github PK

Seeing problems pop up when scripts/stylesheets are loaded from a relative path, e.g. /example (/example/vendor/scripts/jQuery.js)

"Rememeber"

tunely:

<script src="scripts/controllers/AlbumsIndexController.js"></script>

styleguide: https://github.com/SF-WDI-LABS/angular_style_guide#filenames-identify-component-separated-by-

The above should be:

<script src="scripts/controllers/AlbumsIndex.controller.js"></script>

Not sure about the caps

The shorthand

{templateUrl: '/templates/albums'}

is not as clear as the longhand

{templateUrl: '/templates/albums.html'}

and can lead to infinite-recursion problems when running alternate servers (i.e. budo).

All of the readmes for the original tunely are still populating the docs folder. To get to the tunely-angular documentation, you ned to go one directory deeper to the angular folder.

Lots of confusing bugs emerge due to the catchall/wildcard/splat route serving HTML. The most common example is /wrong/path/to/some.js raising "SyntaxError: unexpected token <" in the client.

Recommendation:

• limit catchall to only known route patterns (e.g. /albums, /albums/:id, /albums/:id/songs, etc).
• but add a final catchall that responds with a status 404.

data-ng-app should be come ng-app now.

Change in sprint3.md and solutions

Pass in album object instead of id for easy searching:

var index = vm.albums.indexOf(album);
vm.albums.splice(index,1)

Saw a couple examples where students mistakenly pass a config object with a data property to the shorthand:

$http.put("/foo", { data: {name: "foo", artistName: "bar"}})

Instead of the actual data (the album):

$http.put("/foo", {name: "foo", artistName: "bar"})

(or the recommended longhand):

$http({url: "/foo", method: "put", data: {name: "foo", artistName: "bar"}} )