Giter Club home page Giter Club logo

undopro's People

Contributors

seneral avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

undopro's Issues

Some issue in generic

My usage is like this:
image

then it gives me an error on here:
image

error is:
ArgumentException: The number of generic arguments provided doesn't equal the arity of the generic type definition.
Parameter name: instantiation

System.RuntimeType.MakeGenericType (System.Type[] instantiation) (at :0)
UndoPro.SerializableActionHelper.SerializableObjectOneLevel.Serialize () (at Assets/UndoPro/SerializableAction/SerializableObject.cs:282)
UndoPro.SerializableActionHelper.SerializableObject.Serialize () (at Assets/UndoPro/SerializableAction/SerializableObject.cs:41)
UndoPro.SerializableActionHelper.SerializableObjectOneLevel..ctor (System.Object srcObject) (at Assets/UndoPro/SerializableAction/SerializableObject.cs:254)
UndoPro.SerializableActionHelper.SerializableObject..ctor (System.Object srcObject) (at Assets/UndoPro/SerializableAction/SerializableObject.cs:25)
UndoPro.SerializableActionHelper.SerializableAction.SerializeAction (System.Action srcAction) (at Assets/UndoPro/SerializableAction/SerializableAction.cs:92)
UndoPro.SerializableActionHelper.SerializableAction..ctor (System.Action srcAction) (at Assets/UndoPro/SerializableAction/SerializableAction.cs:45)
UndoPro.UndoProRecord..ctor (System.Action PerformAction, System.Action UndoAction, System.String Label, System.Int32 stackPosition) (at Assets/UndoPro/UndoProRecords.cs:150)

Errors after assembly reload

Hi! First of all let me thank you for solving such a pain as unity's Undo system.
But I've got errors after assembly reload.
How to reproduce:

  1. Window->SerializableActionTest
  2. Create some actions
  3. Create script in the project view (to force assembly reload). Got about 52 errors after deserializing.

Regards,
Mikhail

Bug with Add/Undo

Hi,

Thank you for your Undo/redo system.
I think i find a bug, when i do :

  • Add Record
  • Add Record
  • Undo
  • Undo
  • Add
  • Undo

The last Undo create 2 action identical

I join a text file with the relativeStackPos :
RelativeStackPos.txt

Cheers,

Fully

GetRecordsInternal has been changed in 2021.2.0b

Unity has updated their internal methods for the Undo class in the newest iteration of their engine (2021.2.0b).

It appears that the internal method that UndoPro relies on 'GetRecordsInternal' has been renamed to 'GetTimelineRecordsInternal'.
image

Changing the keyword does appear to work in the latest version of unity, However a new bug has appeared when you perform an Undo operation using Undo Pro.
image

"ArgumentException: method arguments are incompatible" on Unity 2021.2.x

Hi, first of all thanks for the awesome work !

I have an issue with Unity 2021.2.x. As soon as the project opens, I have error endlessly thrown in the console. The error is :

ArgumentException: method arguments are incompatible
System.Delegate.CreateDelegate (System.Type type, System.Object firstArgument, System.Reflection.MethodInfo method, System.Boolean throwOnBindFailure, System.Boolean allowClosed) (at <00c558282d074245ab3496e2d108079b>:0)
System.Delegate.CreateDelegate (System.Type type, System.Reflection.MethodInfo method, System.Boolean throwOnBindFailure) (at <00c558282d074245ab3496e2d108079b>:0)
System.Delegate.CreateDelegate (System.Type type, System.Reflection.MethodInfo method) (at <00c558282d074245ab3496e2d108079b>:0)
UndoPro.UndoProManager.EnableUndoPro () (at Library/PackageCache/com.seneral.undopro@6a77de2ea6/UndoProManager.cs:83)
UndoPro.UndoProManager..cctor () (at Library/PackageCache/com.seneral.undopro@6a77de2ea6/UndoProManager.cs:64)
Rethrow as TypeInitializationException: The type initializer for 'UndoPro.UndoProManager' threw an exception.
UnityEditor.EditorApplication.Internal_CallUpdateFunctions () (at <948074e677924ec29383d02747cdda34>:0)

Issue occured on :

  • 2021.2.4f1
  • 2021.2.0f1

But is not present on :

  • 2021.1.15f1

Capture

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.