seanmiddleditch / gha-setup-ninja Goto Github PK
View Code? Open in Web Editor NEWGitHub Action to install the ninja build tool to PATH
License: MIT License
GitHub Action to install the ninja build tool to PATH
License: MIT License
I noticed, that it doesn't put full path to binary into PATH, but rather just a filename.
Here is my path after "Setup Ninja" step:
PATH=ninja_bin:/Users/runner/.cargo/bin:/usr/local/lib/ruby/gems/2.6.0/bin:/usr/local/opt/ruby/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/usr/local/go/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Users/runner/Library/Android/sdk/ndk-bundle:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools:/Users/runner/.ghcup/bin:/Users/runner/hostedtoolcache/stack/2.3.1/x64
Thanks!
I think when you add it to path, for Posix OSs you should use something like (quotes matter):
export PATH="$PWD/ninja_bin:$PATH"
With
- name: install ninja
uses: seanmiddleditch/gha-setup-ninja@v4
we got github action warning:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: seanmiddleditch/gha-setup-ninja@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
https://github.com/seanmiddleditch/gha-setup-ninja/blob/master/index.js#L10
This code shows an IP for a proxy... it seems unused right?
Recent changed in GH actions appear to have broken this action:
Run seanmiddleditch/gha-setup-ninja@v2
downloading https://github.com/ninja-build/ninja/releases/download/v1.10.0/ninja-linux.zip
extracted 'ninja' to '/home/runner/work/graphia/graphia/ninja-build/ninja'
Error: Unable to process command '::add-path::/home/runner/work/graphia/graphia/ninja-build' successfully.
Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
added '/home/runner/work/graphia/graphia/ninja-build' to PATH
$ ninja --version
1.10.0
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
On arm64 Linux, this installs an x86 build of Ninja.
https://github.com/seanmiddleditch/gha-setup-ninja/blob/master/index.js#L12 and https://github.com/seanmiddleditch/gha-setup-ninja/blob/master/index.js#L24 say selectPlatforn
. Is this deliberate, or is it just a typo and the function should actually be called selectPlatform
?
First of all, thanks for this great action.
When using it (e.g. here), I lately started to see the following warnings:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: seanmiddleditch/gha-setup-ninja
The
set-output
command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
It would be great to get a new release, that works both with the updated Node.js as well as without any warnings.
A connection error occurred when using this action behind a network proxy,
error log here:
Run seanmiddleditch/gha-setup-ninja@master
downloading https://github.com/ninja-build/ninja/releases/download/v1.10.0/ninja-win.zip
D:\github-runners\_work\_actions\seanmiddleditch\gha-setup-ninja\master\dist\index.js:310
request.on('error', error => { throw error })
^
Error: connect ECONNREFUSED 52.216.30.68:443
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14) {
errno: 'ECONNREFUSED',
code: 'ECONNREFUSED',
syscall: 'connect',
address: '52.216.30.68',
port: 443
}
}
Thanks.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.