seanmiddleditch / gha-setup-ninja Goto Github PK

View Code? Open in Web Editor NEW

37.0 3.0 14.0 91 KB

GitHub Action to install the ninja build tool to PATH

License: MIT License

JavaScript 100.00%

gha-setup-ninja's Introduction

setup-ninja

GitHub Action for installing ninja into the PATH for the job.

This downloads the official binaries from the ninja-build repository rather than using a package manager.

Supports Windows, Linux, and macOS.

Inputs:

version: Version of ninja to install (default: 1.10.2)
platform: Override platform detection logic
destination: Target directory for download, added to PATH (default: ${GITHUB_WORKSPACE}/ninja-build)
http_proxy: Optional proxy server hostname

License

MIT License. See LICENSE for details.

Usage Example

jobs:
  publish:
    - uses: actions/checkout@master
    - uses: seanmiddleditch/gha-setup-ninja@master
    - run: |
      mkdir build
      cd build
      cmake -G Ninja ..
    - run: cmake --build build

gha-setup-ninja's People

Contributors

Stargazers

Watchers

Forkers

vita-development-suite mondradiko ewouth mattjohnsonpint abdes methanepowered eliasku symmetryinvestments riscure cclauss teo-tsirpanis li3zi3han2 remarkable

gha-setup-ninja's Issues

Does not work on arm64 Linux

On arm64 Linux, this installs an x86 build of Ninja.

Pre-defined proxy in code?

https://github.com/seanmiddleditch/gha-setup-ninja/blob/master/index.js#L10

This code shows an IP for a proxy... it seems unused right?

Connect refused behind proxy

A connection error occurred when using this action behind a network proxy,
error log here:

Run seanmiddleditch/gha-setup-ninja@master
downloading https://github.com/ninja-build/ninja/releases/download/v1.10.0/ninja-win.zip
D:\github-runners\_work\_actions\seanmiddleditch\gha-setup-ninja\master\dist\index.js:310
    request.on('error', error => { throw error })
                                   ^

Error: connect ECONNREFUSED 52.216.30.68:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14) {
  errno: 'ECONNREFUSED',
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '52.216.30.68',
  port: 443
}
}

Thanks.

Node.js 16 actions are deprecated.

With

    - name: install ninja
      uses: seanmiddleditch/gha-setup-ninja@v4

we got github action warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: seanmiddleditch/gha-setup-ninja@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Broken because the 'add-path' command has been disabled

Recent changed in GH actions appear to have broken this action:

Run seanmiddleditch/gha-setup-ninja@v2
downloading https://github.com/ninja-build/ninja/releases/download/v1.10.0/ninja-linux.zip
extracted 'ninja' to '/home/runner/work/graphia/graphia/ninja-build/ninja'
Error: Unable to process command '::add-path::/home/runner/work/graphia/graphia/ninja-build' successfully.
Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
added '/home/runner/work/graphia/graphia/ninja-build' to PATH
$ ninja --version
1.10.0

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Update for Ninja 1.10

Migrate to Node.js 16

First of all, thanks for this great action.

When using it (e.g. here), I lately started to see the following warnings:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: seanmiddleditch/gha-setup-ninja

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

It would be great to get a new release, that works both with the updated Node.js as well as without any warnings.

Function typo?

https://github.com/seanmiddleditch/gha-setup-ninja/blob/master/index.js#L12 and https://github.com/seanmiddleditch/gha-setup-ninja/blob/master/index.js#L24 say selectPlatforn. Is this deliberate, or is it just a typo and the function should actually be called selectPlatform ?

Wrong record in PATH variable.

I noticed, that it doesn't put full path to binary into PATH, but rather just a filename.
Here is my path after "Setup Ninja" step:

PATH=ninja_bin:/Users/runner/.cargo/bin:/usr/local/lib/ruby/gems/2.6.0/bin:/usr/local/opt/ruby/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/usr/local/go/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Users/runner/Library/Android/sdk/ndk-bundle:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools:/Users/runner/.ghcup/bin:/Users/runner/hostedtoolcache/stack/2.3.1/x64

Link to my YAML file (frozen)

Thanks!

I think when you add it to path, for Posix OSs you should use something like (quotes matter):

  export PATH="$PWD/ninja_bin:$PATH"