import SwiftUI
import SAPFiori
// https://github.com/SAP/cloud-sdk-ios.git
// exact 8.0.2

struct FUIButtonWrapper: UIViewRepresentable {
    let title: String
    let foregroundColor: Color
    let action: () -> Void

    func makeCoordinator() -> Coordinator { Coordinator(self) }

    class Coordinator: NSObject {
        var parent: FUIButtonWrapper

        init(_ actionButton: FUIButtonWrapper) {
            self.parent = actionButton
            super.init()
        }

        @objc
        func action(_ sender: Any) {
            self.parent.action()
        }
    }

    func makeUIView(context: Context) -> UIButton {
        let button = SAPFiori.FUIButton(style: .secondary)

        button.setTitle(self.title, for: .normal)
        button.setBackgroundColor(UIColor.preferredFioriColor(forStyle: .primaryFill), for: .normal)
        button.setBackgroundColor(UIColor.preferredFioriColor(forStyle: .primaryFill).withAlphaComponent(0.4), for: .highlighted)
        button.setTitleColor(UIColor(foregroundColor), for: .normal)
        button.setTitleColor(UIColor(foregroundColor).withAlphaComponent(0.4), for: .highlighted)
        button.isPersistentSelection = false
        button.isAccessibilityElement = true
        button.addTarget(context.coordinator, action: #selector(Coordinator.action(_ :)), for: .touchUpInside)
        return button
    }

    func updateUIView(_ uiView: UIButton, context: Context) {}
}

struct ContentView: View {
    var body: some View {
        VStack {
            FUIButtonWrapper(title: "title 1", foregroundColor: .red, action: {})
            FUIButtonWrapper(title: "title 2", foregroundColor: .blue, action: {})
        }
            .padding()
    }
}

Observed: glitch with shifted highlighted area in top left for dark mode:

Expected: no glitch with shifted highlighted area in top left for dark mode

DataFetcher and BaseBaseCard should be configured to execute an asynchronous Request, which may load data from a local or remote resource. When JSON data is fetched, it should be sent to the Request publisher.

The URL of the Request may be parameterized, using the configuration.destinations object of the card. See spec.

The URL of the Request may also be parameterized using the app.dataSources object. See spec.

The URL of the request itself may be fully-qualified or relative. According to the spec:

If the URL is relative, it is going to be resolved based on the page instead of the manifest base path.

However, since in this case there is no page, we need to evaluate the long-term behavior. In the meantime, we should resolve either to the location of manifest.json on the remote host, or, for local bundles, relative to the manifest.json data.

Describe the bug
When add .accessibilityElement(children: .combine) modifier VoiceOver doesn't pronounce grouped children elements, only visually selects them.

To Reproduce
For Examples.xcodeproj replace content of the ContentView.swift with following code:
`
import FioriCharts
import SwiftUI
import FioriCharts
import FioriSwiftUICore
import FioriCharts
import FioriSwiftUICore
import SwiftUI

struct ContentView: View {
var body: some View {
ObjectHeader {
Text("Some title text explaining something")
.font(.fiori(forTextStyle: .title3))
.foregroundColor(.preferredColor(.primaryLabel))
.fontWeight(.black)
} subtitle: {
Text("Some author name")
.font(.fiori(forTextStyle: .body))
.foregroundColor(.preferredColor(.secondaryLabel))
.fontWeight(.regular)
} footnote: {
Text("2 days ago")
.font(.fiori(forTextStyle: .subheadline))
.foregroundColor(.preferredColor(.tertiaryLabel))
.fontWeight(.regular)
}
.padding()
.accessibilityElement(children: .combine)
}
}
`

1. Enable Accessibility -> Voice Over
2. Launch the app
3. Observe that header children text is not pronounced when .accessibilityElement(children: .combine) added, only visual grouping is visible.
   Note: when no .accessibilityElement(children: .combine) added elements pronounced separately, but I need .accessibilityElement(children: .combine) so they are grouped.

Expected behavior
Expected all grouped elements are pronounced by VoiceOver with this modifier.

Screenshots

Mobile (please complete the following information):

Device: iPhone 8
OS: iOS 15.5
Swift Package Product: FioriSwiftUICore
Swift Package Version: 2.1.0, main branch, commit a82de93
Xcode Version: Version 13.4 (13F17a), toolchain Xcode Version 13.4 (13F17a)
FioriSwiftUI / cloud-sdk-ios-fiori 2.1.0

Additional context
Add any other context about the problem here.

Proposed renaming:

BaseBaseCard -> BackingCard

e.g SonarCloud (or competitive product)

Describe the bug
Button stay pressed if slightly pressed while scrolled on iPad
https://github.com/dianadanylova/ButtonBug

To Reproduce
Steps to reproduce the behavior:

1. Launch the app
2. Scroll down
3. While button is still moving back scroll again by slightly touching the button (but only when button is still moving)
4. See that button stay visually in pressed state

Expected behavior
Button go back to "not pressed" state

Screenshots

Mobile (please complete the following information):

• Device: iPad pro 11" 3rd gen
• OS: iOS 15.3.1
• Swift Package Product: FioriSwiftUICore
• Swift Package Version: 2.1.0 main branch
• Xcode Version: Xcode 13.3
• FioriSwiftUI / cloud-sdk-ios-fiori 2.1.0

Integration Cards handlebar replacement should support JS transformations with sap.ui.core.format.NumberFormat options.

https://openui5.hana.ondemand.com/#/api/sap.ui.core.format.NumberFormat

Supported per specification:
https://openui5.hana.ondemand.com/test-resources/sap/ui/integration/demokit/cardExplorer/webapp/index.html#/learn/formatters

It is impossible to override the color definitions of an existing color palette. SAP BTP SDK for iOS customers are used to override individual color definitions, e.g tintColor , either programmatically or through a style sheet.

This will become problematic for customers who built an app with SAP Fiori UIKit and SwiftUI components, download theme information from SAP Mobile Services and those downloaded color information can only be applied to the UIKit-based components provided by the SAPFiori.xcframework.

Out-of-scope for this feature request is to introduce style classes

Using shell script setupForCollaborators.sh will cause corrupt file FioriSwiftUI.xcodeproj

The project ‘FioriSwiftUI’ is damaged and cannot be opened due to a parse error. Examine the project file for invalid edits or unresolved source control conflicts.

To increase package visibility register FioriSwiftUI in

• https://swiftpackageregistry.com/
• https://swiftpackageindex.com/ (a.k.a SwiftPM Library)

Adding the package to GitHub package registry is pending until it is finally supported :) hopefully soon

maxWidth in SwiftUI frame setting is not working as expected. Should calculate based on inner text width.

subTitle should be optional.

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Describe the bug
KPIItem for VoiceOver accessibility always pronounced as button, .accessibilityRemoveTraits([.isButton]) has no effect

To Reproduce

1. Enable Accessibility -> Voice Over
2. Run Examples.xcodeproj app and navigate to Core Elements -> KPI
3. Observe that KPI pronounced as button, even no action is available, .accessibilityRemoveTraits([.isButton]) doesn't help

Expected behavior
I expect API to provide accessibility traits to work (e.g. .accessibilityRemoveTraits([.isButton])), or option to control via initializer (e.g. nil action handle means no button trait)

Mobile (please complete the following information):

Device: iPhone 8
OS: iOS 15.5
Swift Package Product: FioriSwiftUICore
Swift Package Version: 2.1.0, main branch, commit a82de93
Xcode Version: Version 13.4 (13F17a), toolchain Xcode Version 13.4 (13F17a)
FioriSwiftUI / cloud-sdk-ios-fiori 2.1.0

Additional context
Add any other context about the problem here.

Describe the bug

I took a look at the translations and noticed some differences:

In German translations the infinitive is used exclusively:
e.g. "Tap to Sign" = "Zum Signieren tippen";
But in Serbian and Croatian translations is used imperative instead of infinitive and even worse there is a mix in way of addressing someone.
e.g. "Tap to Sign" = "Dodirnite da biste potpisali"; and "Tap to Sign" = "Dodirni za potpis";

I will compare it to the German so it is easier to unterstand. There is no big difference in addressing an older person and a friend in English:
e.g.
to friend: "How are you?"
to older person: "How are You?"

but in German there is a difference:
to friend: "Wie geht es dir?"
to older person: "Wie geht es Ihnen?"

The same case is in Serbian and Croatian
to friend: "Kako si?"
to older person: "Kako ste?"

The first issue is not using of infinitive:
"Dodirni za potpis" would be in German "Tipp zum Signieren"
And the second issue is mixing of way of addressing someone (Croatian and Serbian are almost identical):
"Dodirnite da biste potpisali" would be in German "Tippen Sie zum Signieren"

I could create a Pull Request, but I need to know what convention do you use?
Most likely there is the same issue with other languages, but I noticed this in Serbian and Croatian.

e.g. .darkConstant for preferredStyle. Needs to validate and fix some issues with FioriThemeManager.

Check the usage print statements in FioriIntegrationCards artifacts and delegate errors to consumer

Example: Manifest.swift; public init(withCardBundleAt path: URL) throws

Describe the bug
ObjectItem detailImage view VoiceOver accessibility is broken. For Image(systemName: "headphones") system image not announced, For Image("pdfIcon", label: Text("Some text")) label not announced, detailImageModifier doesn't solve issue with modifiers.accessibilityLabel() or .accessibilityValue()

To Reproduce
For Examples.xcodeproj replace content of the ContentView.swift with following code:
`
import FioriCharts
import SwiftUI
import FioriCharts
import FioriSwiftUICore
import FioriCharts
import FioriSwiftUICore
import SwiftUI

/*
Image(systemName: "headphones") // system image label not announced
Image("pdfIcon", label: Text("Some text")) // some text not accounced
*/

struct ContentView: View {
var body: some View {
ObjectItem(title: "Some title 1", subtitle: "Some subtitle 2", footnote: "Some footnote", status: .text("Some status"), detailImage: Image(systemName: "headphones"))
.padding([.leading, .trailing], 16)
.accessibilityElement(children: .combine)
.environment(.horizontalSizeClass, .compact)
}
}
`

1. Enable Accessibility -> Voice Over
2. Launch the app
3. Observe that image label is not pronounced, both options below handled by system correctly when used alone, but not when inside ObjectItem.

• Image(systemName: "headphones") // system image label not announced
• Image("pdfIcon", label: Text("Some text")) // some text not accounced

Expected behavior
Image element labels are pronounced correctly by VoiceOver as Image element used alone.

Screenshots

Mobile (please complete the following information):

Device: iPhone 8
OS: iOS 15.5
Swift Package Product: FioriSwiftUICore
Swift Package Version: 2.1.0, main branch, commit a82de93
Xcode Version: Version 13.4 (13F17a), toolchain Xcode Version 13.4 (13F17a)
FioriSwiftUI / cloud-sdk-ios-fiori 2.1.0

Additional context
Add any other context about the problem here.

Describe the bug
The title row on the table card doesn't align with the card.

To show proof of high quality in our OS project we shall participate in the Linux Foundation (LF) Core Infrastructure Initiative (CII) Best Practices badge program

Target

• Request and earn "passing" CII Best Practices Badge
• add to README after badge was earned
• Prepare roadmap to earn higher levels, see criteria

Describe the bug
ObjectHeader footnote text is cut when user changes dynamic text size

To Reproduce

1. For Examples.xcodeproj replace content of the ContentView.swift with following code:
   `
   import FioriCharts
   import SwiftUI
   import FioriCharts
   import FioriSwiftUICore
   import FioriCharts
   import FioriSwiftUICore
   import SwiftUI
   struct ContentView: View {
   var body: some View {
   BrokenObjectHeader()
   }
   }

struct BrokenObjectHeader: View {
var body: some View {
NavigationView {
NavigationLink("Open details") {
ScrollView {
VStack(spacing: 30) {
ObjectHeader {
Text("Some title text explaining something")
.font(.fiori(forTextStyle: .title3))
.foregroundColor(.preferredColor(.primaryLabel))
.fontWeight(.black)
} subtitle: {
Text("Some author name")
.font(.fiori(forTextStyle: .body))
.foregroundColor(.preferredColor(.secondaryLabel))
.fontWeight(.regular)
} footnote: {
Text("2 days ago")
.font(.fiori(forTextStyle: .subheadline))
.foregroundColor(.preferredColor(.tertiaryLabel))
.fontWeight(.regular)
}
}
}
}
}
}
}
`

2. Launch the app
3. Press "Open details" button and increase dynamic text size to extra extra large size using environment overrides
4. Press "Back"
5. Press "Open details" and decrease dynamic text size to extra extra small size using environment overrides
6. Observe footnote clipped

Expected behavior
The text should be fully rendered with matching dynamic size

Screenshots

Mobile (please complete the following information):

• Device: iPhone SE - 2nd generation (Simulator)
• OS: iOS 15.4
• Swift Package Product: FioriSwiftUICore
• Swift Package Version: 2.1.0, main branch, commit 0786a13
• Xcode Version: Version 13.3 (13E113), toolchain Xcode 13.3
• FioriSwiftUI / cloud-sdk-ios-fiori 2.1.0

In Xcode 12 it's possible to add custom views and modifiers to Xcode Library (https://developer.apple.com/videos/play/wwdc2020/10649) which improves API discoverability.

Currently, there is only one generic ChartView with a generic ChartModel to handle all kinds of chart types. Nevertheless, it is possible to define different entries for Xcode Libraries to serve code snippets for chart-specific ChartView+ChartModel implementations

Example

#if swift(>=5.3)
@available(iOS 14.0, *)
struct LibraryContent : LibraryContentProvider {
    @LibraryContentBuilder
    var views: [LibraryItem] {
        LibraryItem(
            ChartView(ChartModel(chartType: .stock, data: [[16.52, 15.50, 18.67, 16.70, 16.90]], titlesForCategory: [["2020-01-06 10:00:00", "2020-01-06 10:30:00", "2020-01-06 11:00:00", "2020-01-06 11:30:00", "2020-01-06 12:00:00"]])),
            title: "Stock Chart"
        )
    }
}
#endif

From an API consumer perspective, we probably want to offer chart-type specific convenience Chart Views in the future. This is not the scope of this feature request. If so then the custom views added to Xcode Library can easily be updated.

Motivation

As most of the current code (Charts, IntegrationCards) are UI components it shall be possible to write tests which verify the correctness of the UI

Concept

Record reference images of UI artifacts and then compared those against current UI artifacts

Pro:

• Reference image changes provide an opportunity for designers to give feedback on pull requests
• Snapshot tests are a very broad-strokes confirmation that your UI is “correct.”
• Testing across devices, iOS versions, and size classes becomes trivial

Cons

• iOS versions often include changes to text antialiasing, so your tests need to be tied to specific iOS versions. Updating reference images when you update your iOS versions introduces a lot of churn in reference image files

How-to

• Use swift-snapshot-testing swift package as technical foundation
• Reference images shall be stored in a submodule to mitigate repo bloat
• Tests shall be written in the repo
  • not as part of the repo's swift module due to the use of submodule
• Tests shall be executed in a test app (./Apps)
• Tests shall be executed in CI landscape
  • not necessarily on PR but as part of a scheduled job

Describe the bug
When using the Donut type chart in a Table View, the chart appears left aligned rather than centred. All other charts seem to with fill the cell width so appear to be centred.

To Reproduce
You can just use the sample code from the Chart Plot example in the Fiori Mentor and set the chart type to .donut

I have used both 5.1.x and 6.0.x versions of the SDK for this with the same result.

Expected behaviour
Chart is centre aligned - so the behaviour is the same as when using the Chart Floorplan

Screenshots
Testing using the cloud-sdk-ios-fiori examples shows the same behaviour. That said, if you up the length ratio with the slider in the example app it does finally align once the Diameter == cell width.

Example from Floorplan

Example from Table Cell

Additional context
I did see that the charts in both the latest 5 and 6 releases were SwiftUI based - is the codeline the same as in the github repo? Very cool stuff!

Please let me know if you need any more info - I have a sample project if that would help?

Al Templeton

DataFetcher and BaseBaseCard should be configured to load json: Data and optional path: String, in-line from manifest.json.

The implementation should support the 3 locations of data object:

1. card
2. header
3. content

According to the spec, if data is located in the header or content region, this should be prioritized. It also appears from the samples, that it should be support that the data is at the card level, and the path property at the header or content level should mask the card data.

Hi All

Great library - really having fun with this!

Was trying some of the Charts in various size widgets. Found that the micro charts worked well but the more complex Charts wouldn't render - see screen grab - .line, .column etc.

Found that in the GridLinesAndChartView.swift file there is a view called Background that is using UIViewRepresentable - this won't render as a widget - I have tested this by removing the Background view from the ZStack created in createBody.

Not sure how easy this will be to fix as there are a bunch of gestures attached to Background - but prob don't need these for a widget version?

Let me know if you need any more information

Al T.

Prerequisites:

• Swift package dependencies have to support macOS
  • adopt recent 1.2.0 release of github.com/sstadelman/observable-array
• declare support for macOS in Package.swift
• fix build issues for macOS (due to usage of UIKit)

Example of conditional handling of color

#if os(iOS) || os(tvOS) || os(watchOS)
    import UIKit
    public typealias Color = UIColor
#elseif os(OSX)
    import Cocoa
    public typealias Color = NSColor
#endif

Another area of work is the use of UIViewRepresentable vs. NSViewRepresentable, see here for details

As you may or may not be aware, the United States is undergoing a period of acute focus on racial and ethnic relationships in society. This is certainly not the first of such times in our country which has a history of African slavery and modern segregation, and, sadly, will likely not be the last. While the issues being fought are worlds more significant than the details of our development operations, one small idea introduced and put into practice by the latest release of Xcode 12 is to default the name of the primary branch of git repositories to ‘main’, rather than ‘master’.

This resonates with us. There is a good blog here: https://www.hanselman.com/blog/EasilyRenameYourGitDefaultBranchFromMasterToMain.aspx which outlines how to make the change and handle some of the side effects for remote developers.

Our project has some issue with compile time, it takes around 12-13 sec for compilation (clean and build) and the project doesn't have big code base.

I found some problem parts in your sdk. For example func columnsView(in: ) -> some View in ColumnMicroChart.swift, this method needs ~7 sec for compilation, I guess, it's hard for compiler to calculate a final type of the expression.

What do you think about it? Could you do some refactoring these methods/expressions?

1. and 2) points from this article could be helpful.

Hi All

Found some odd behaviour when running the Examples app under iOS 14 beta. There must be something different happening in Swift when it handles the onTapGesture closure - meaning that the currentModel is not being set (or not in the correct self?) when the ChartDetailView is called. I tried using [self] in for the closure but made no difference. Fixed it briefly using a global but this is just a dodgy work around :)

Works perfectly under iOS 13 - so bit of an odd one.

iOS 14 error attached below

Thx!

A 3-digit hex color value, when passed to ThemeManager.setHexColor(_:for:variant:) or present in a stylesheet and then loaded with loadStylesheetByURL(url:), is not parsed correctly within FioriThemeManager module.

Running examples requires the manual prerequisite step of creating an Xcode project for a workspace. This is inconvenient for non-collaborators and hinders exploration.

The goal is to add the package as a local dependency to Xcode project which still allows contributors to easily test local changes

Use new SwiftUI features for new hierarchical List API and DisclosureGroup (iOS 14+ / Xcode 12+) in demo app

To support embedded JS in cards.

Needs support for definition of custom component styling for KPI text.

In ColorStyle.swift, the suffix Background is frequently mis-spelled as Backgrond. Can these be fixed?

As discussed with @billzhou0223, based on current MVP version, I will complete the following tasks going forward:

• Add custom styling protocol (similar to Button) to handle background style based on tap state.
• Add similar styling protocol to allow developer customize the style change for chevron in section header.
• Research the way of supporting navigation view customization.

Describe the bug
Infinite flickering of timeline card when running with Xcode 12 / iOS 14.

Works fine with Xcode 11 and iOS 13

Screenshots

Mobile:

• Device: iPhone 8
• OS: iOS 14
• Xcode: 12
• Swift Package: FioriIntegrationCards
• Version: 0.5.5 (current main)

Additional Information
Caused by TimelinItemView.swift as alignmentGuide modifier is called endlessly. One solution (might impact design) is to remove line 32 which adds -30 bottom padding to icon

 var body: some View {
        HStack(alignment: .top) {
            VStack {
                SafeView(self.model.icon)
                    .frame(width: iconWidth, height: iconWidth, alignment: .top)
                    //.padding(.bottom, -30)

Result:

Describe the bug
CollectionView in the Integration Cards was created multiple times.

To Reproduce
Steps to reproduce the behavior:
Please build and run the example app with iPhone.

1. Go to ‘Integrations Cards’
2. Click on ‘list_dataInCardLevel’

Expected behavior
On iPad, you will see an endless print statements in the console.

Screenshots
If applicable, add screenshots to help explain your problem.

Mobile (please complete the following information):

• Device: iPad Pro 11
• OS: iOS 14
• Swift Package: Integration Cards
• Version master branch

Describe the bug
CollectionView in the Integration Cards is flashing.

To Reproduce
Steps to reproduce the behavior:
Please build and run the example app with iPhone.

1. Go to 'Integrations Cards'
2. Click on 'Collection View' tab

Expected behavior
You will see the collection view screen is flashing.

Screenshots
If applicable, add screenshots to help explain your problem.

Mobile (please complete the following information):

• Device: Phone 11
• OS: iOS 14