samvloeberghs / kwerri-oss-bu Goto Github PK

The current build on npm logs the minify options on EVERY SINGLE ROUTE. Redeploy the latest master where the log doesn't exist, please.

• the picture of my head is the least optimized image of all it seems
  

• The JSON LD output should be able to be done on request

A stats-es2015.json is required for the 'disableAngular' plugin.
Please run 'ng build' with the '--stats-json' flag
 The render plugin "disableAngular has thrown the below error,
              while trying to render route "/blog"
              Scully will exit
Error: A stats-es2015.json is required for the 'disableAngular' plugin.
Please run 'ng build' with the '--stats-json' flag

I ran npm run build -- --prod --stats-json as the readme instructs, but that generates a file called stats.json instead of stats-es2015.json.

If I rename that file then run scully, everything seems to work fine.

I have "target": "es2015", in my tsconfig.json, and in my dist folder I see my main, polyfille, and runtime js files built for es5 and es2015.

What's happening here? Did ng build change how it outputs stats files? Is it a config thing on my part?

🐞 Bug report

Description

The plugin does not automatically ignore image files and will instead error out and print an error message to the console during Scully build. The plugin handler is skipped so this does not result in build failure, but the generated error messages are noise in the console.

The ideal behaviour here would be to just skip processing image files

🔬 Minimal Reproduction

Any Scully project using the scully-plugin-minify-html plugin in defaultPostRenderers of the Scully config with a fileHandler plugin registered e.g. registerPlugin('fileHandler', 'png', imageFilePlugin);.

💻Your Environment

Angular Version:

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 11.0.5
Node: 14.8.0
OS: darwin x64

Angular: 11.0.5
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.5
@angular-devkit/build-angular   0.1100.5
@angular-devkit/core            11.0.5
@angular-devkit/schematics      11.0.5
@angular/cdk                    11.0.3
@angular/material               11.0.3
@schematics/angular             11.0.5
@schematics/update              0.1100.5
rxjs                            6.6.3
typescript                      4.0.5

Scully Version:

"@scullyio/init": "^1.0.1"
"@scullyio/ng-lib": "^1.0.0"
"@scullyio/scully": "^1.0.0"
"scully-plugin-minify-html": "^5.0.0"

🔥 Exception or Error

Error during content generation with plugin "minifyHtml" for ./projects/website/blog-posts/images/banner.jpg. This hander is skipped.

Please help with what I am missing on the below meta tags as the social sharing is not working.
Is it something to do with the page not being crawled yet?

I'd appreciae any suggestion

• check navigation on mobile, should be visible without JS
• homepage should be reachable via links from deeper pages

The README of 'scully-plugin-minify-html' still mentions it depends on the html-minifier package not the html-minifier-terser one.
See Use html-minifier-terser? #41

In NX 10 the tsconfig.app.json file has been renamed to tsconfig.base.json

Fix:

• Check for tsconfig.base.json if tsconfig.app.json is not present

When a route is ignored and entered, it is enabled for the entire application again when moving between the routeLink

I have this issue when i add seoService in my contructor :
"Strict mode code may not include a with statement"
Can you solve this problem for us please.

I use last angular version 8.2.14 of Angular

As title, minifyHtml doesn't seem to work with latest Scully

I'm not sure if this is always the case, but for me currently, the plugin only works if I include this minify html option removeComments: false. It looks like scully depends on <!--scullyContent-begin--> and <!--scullyContent-end-->.

Latest scully shows a warning when using plugin:

scully-plugin-minify-html does not work with tslib 2.0

Hi,

It appears https://www.npmjs.com/package/scully-plugin-disable-angular is broken in the latest release of Scully. getPluginConfig should be replaced with getMyConfig. I've made the necessary changes and would like to request permission to open a pull request.

replace icons with their SVG alternative

Angular 10
tsconfig.app.json has been moved from the src folder to the root folder

ng build --prod --stats-json
create stats.json

npm run scully

 ☺   new Angular build imported
Background servers already running.
Finding all routes in application.

----------------------------------
Using stored unhandled routes!.
   To discover new routes in the angular app use "npm run scully -- --scanRoutes"
----------------------------------
Pull in data to create additional routes.
Finding files in folder "./blog"
Route list created in files:
  "./dist/static/assets/scully-routes.json",
  "/home/kerron/Projects/website/dist/kerrongordon/assets/scully-routes.json",
  "/home/kerron/Projects/website/src/assets/scully-routes.json"

Error reading tsConfig at path src/tsconfig.app.json
Error: ENOENT: no such file or directory, open 'src/tsconfig.app.json'
    at Object.openSync (fs.js:458:3)
    at Object.readFileSync (fs.js:360:35)
    at disableAngularPlugin (/home/kerron/Projects/website/node_modules/scully-plugin-disable-angular/bundles/scully-plugin-disable-angular.umd.js:216:38)
    at Object.wrap (/home/kerron/Projects/website/node_modules/@scullyio/scully/lib/pluginManagement/pluginWrap.js:45:24)
    at wrapper (/home/kerron/Projects/website/node_modules/@scullyio/scully/lib/pluginManagement/pluginRepository.js:57:47)
    at /home/kerron/Projects/website/node_modules/@scullyio/scully/lib/renderPlugins/executePlugins.js:34:30
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async /home/kerron/Projects/website/node_modules/@scullyio/scully/lib/renderPlugins/executePlugins.js:29:22
    at async Object.wrap (/home/kerron/Projects/website/node_modules/@scullyio/scully/lib/pluginManagement/pluginWrap.js:45:18)
    at async Object.asyncPool (/home/kerron/Projects/website/node_modules/@scullyio/scully/lib/utils/asyncPool.js:29:13) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: 'src/tsconfig.app.json'
}
 The render plugin "disableAngular has thrown the below error,
              while trying to render route "/projects/2020-07-22-blog"
              Scully will exit
Error: Error: ENOENT: no such file or directory, open 'src/tsconfig.app.json'

Hey,

first question. Is this package still maintained?
The problem is since it's not compatible with Ivy #76

Here is the error message from angular:

'JsonLdModule' does not appear to be an NgModule class.

136     JsonLdModule,
        ~~~~~~~~~~~~

  node_modules/ngx-seo/lib/json-ld/json-ld.module.d.ts:1:22
    1 export declare class JsonLdModule {
                           ~~~~~~~~~~~~
    This likely means that the library (ngx-seo) which declares JsonLdModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Hope to get a reply

Upon initializing the project with the configuration outlined by the README file, I got the following error:

---------
 We encountered an error executing the config file. "/Users/ccrutchley/git/Linkd/linkd-web/scully.linkd-web.config.js"
 Check the error below, and try again later
--------- 
{ Error: Cannot find module 'html-minifier'

I would either update the README to include this in the npm i commands, or make the dependency a full dependency instead of a peerDep

The meta tags itemprop are not updated but duplicated.

This is probably due to the fact that the method _parseSelector inside @angular/platform-browser is not checking the itemprop? (see links below) + an issue is opened but not 100% related to itemprop. angular/angular#19606

https://github.com/angular/angular/blob/2c757591ee334ced115bc93ba1b944803bb0c07e/packages/platform-browser/src/browser/meta.ts#L188

private _parseSelector(tag: MetaDefinition): string {
    const attr: string = tag.name ? 'name' : 'property';
    return `${attr}="${tag[attr]}"`;
}

Proposed fix:
@samvloeberghs here a fix: https://github.com/samvloeberghs/kwerri-oss/pull/56

Please help with what I am missing on the below meta tags as the social sharing is not working.
Is it something to do with the page not being crawled yet?

I'd appreciae any suggestion

In the scully-plugin-minify-html plugin the json inside json script is not minified

Example json script:

`

`

Would be viable to use html-minifier-terser instead of html-minifier? It is actively maintained and would allow to minify ES6.

Regards!

thank you for all your efforts

Please update to Angular 13 to make it compatible with Ivy.

Please add this tag in setImage method.
this.metaService.updateTag({ name: 'image', content: image });