ryant26 / masterrank Goto Github PK

Oversmash runs in the browser?? We need it to run on node.

The current threshold for updating player data from the OW api is hardcoded at 6 hours. This time should be pulled from the config file in case we want to change it easily.

Implement the front end of the landing page. As per @andylin's designs.

Tasks:

• Style subscribe button (on click)
• Implement scrollspy logic for learn more icon
• Implement email validation logic (and styles to show pass/fail)
• Implement email submit (AJAX)
• Implement email submit feedback (Request pass/fail)

Display an icon for each hero, which acts as a toggle. 0 to n heroes can be selected at any time, where n is the total number of heroes.

We need to be able to dispatch an action that adds a hero to the meta list

• If possible a single travisCI build for all microservices in the project
• Slack integration for build passing / failing

If the group is deleted at the same time as a pending player accepts an invite they could be inserted into the "deleted" group.

Need to add a transaction that watches the "leader" key. A change in this key will indicate that the group leader has either left or the group has been deleted.

An early assumption made with the socket server was that everyone used Battle.NET this is not the case for PSN or XBox users.

Need to add additional namespaces to accommodate for other platforms

As is the case with most scraping libraries they need frequent updates as the web page changes.

Someone opened a PR 19 days ago that has not been merged (we need the PR fix). I reached out to the owner to see if I could become the maintainer of the project. If I don't hear back from him we will have to fork it and maintain it ourselves.

In the case that the scraper becomes out of date, when updating a player's data we should check that we aren't overwriting a good value with a value of 0, null or Nan

Currently this url is hard coded, will break when no longer using localhost.

• Schema should be able to support fast queires for hero stats
• Should also support fast queries for producing "percentile" of certain hero stats

In order to horizontally scale we need to add multi-node support, in the passed this has been challenging. Socket.io has a plugin for this.

Ensure we add sub pages for:

• Server architecture diagram
• Socket API

• replace getPlayerRank
  • create endpoint on heroAPI that looks for 1 hero and returns SR
    • create tests for said endpoint
  • update existing unit tests for socketServer
  • update existing functional tests for socketServer
  • update existing multiNode tests for socketServer
    • Create mockAPI that can launch or use resolver to mock PlayerClient
• replace getHeroStats
  • add getHeroStats to PlayerApi unit test mocking helper
  • update existing unit tests for socketServer
  • update existing functional tests for socketServer
  • update existing multiNode tests for socketServer
    • Create mockAPI that can launch or use resolver to mock PlayerClient

Create endpoint for validating tokens

We will want to know the capacity of the socket server and the effects of degraded performance.

Artillery has support for socket.io out of the box.

Atm the server is the only place the groupID is stored, if the server crashes (or terminated due to autoscaling) there is no way to re-insert the hero into the group on reconnect. Thus we need to:

• Store the group ID in the heroInfo key (or make a new key for it)
• Retrieve this information on connect and send it as part of the 'initialData' event
• Update the API docs to show this change

• Create dir
• Add necessary build info to travis.yml
• Create initial dir layout
• Add a dummy test for the build to run
• Set up build/pipeline (gulp, linting, etc)

Lets create skeleton for this as well:

Install Redux and refactor the current MasterRank App to use Redux's store

• also add this to dependency resolver for ease of testing

Although the client should have AFK handling. The server should not rely on that.

We need to make all the Redis keys expire after some time limit:

• Groups: 2-6hrs?
• Heros: 1.5 hrs?

• hero object
• hero name
• groupId

HeroGroup should take a list of HeroCards and display them in a column

• Start with an info page describing the project

Create the basic skeleton component for housing character roles with some fake data.
For now, just be sure to include:

• Proper characters per role
• Basic logic for ranking by win percentage

Out of scope:
-Ranking based on current users SR

Hero API should redirect http -> https. In production we will terminate TLS/SSL at the load balancer level.

Need a simple back end that accepts POST requests with email addresses.

I use a lot of events and promises in the socket server. Do a memory analysis to make sure all of those closures are being cleaned up properly

On groupLeave, the groupController does not get its groupId set to null.

When the socket disconnects the controller will try to remove the hero from the last group it was a part of

Right now I'm not sure how the ALP routes websocket requests. We want to verify that we don't support insecure websocket connections.

• Create Directory
• Setup tooling for building the project

We need to design a rest API and document it on github