rxswiftcommunity / rxreachability Goto Github PK

Overview

We have test files, but no real tests in them.

Hello everyone,

I've been granted the great honor of administrating this project.

In the past, I've used RxReachability because despite the fact Reachability isn't particularly diffucult to impliment on one's own, and I lean on the side of not adding dependencies for such small code bases, I make exceptions for communities I know I can trust.

I'm grateful to have that trust of the community, and I look forward to keeping this small but vital code base useful and reliable.

Cheers,
Joe

Various gems are out of date causing security warnings.

Update gems.

Overview

Sometimes a PR is out of sync with develop. A rebase command can be much faster than manually checking out a branch and force pushing a rebase. I've had success before adding a /rebase comment command to PRs.

Example

https://github.com/HeroTransitions/Hero/blob/develop/.github/workflows/rebase.yml

Overview

GitHub actions run on docker and are much faster than a Travis VM.

Examples

https://github.com/HeroTransitions/Hero/blob/develop/.github/workflows/test.yml

RxReachability works fine with ReachabilitySwift 4.3.0

On the other hand, 4.3.1 introduces dependency on Swift5,

see comment in https://github.com/awslabs/aws-mobile-appsync-sdk-ios/blob/master/Podfile

Dependency "RxReachability" has no shared framework schemes for any of the platforms: iOS

Overview

SPM Support

Reasons

RxReachability is one of the very few Rx dependencies that do not support SPM.

Overview

Jazzy is a tool for creating Apple doc style pages from source code comments and markdown files.

Requirements

1. Add config file
2. Add an action to auto create and publish new docs on merge to master
3. Host as a GitHub page by publishing in /docs

Examples

Config

https://github.com/HeroTransitions/Hero/blob/develop/.github/workflows/rebase.yml

Actions sample

TODO

Add a GitHub action to run SwiftLint on pull requests

Requirements

1. Print in-line warnings on PRs that violate rules
2. Use the Ubuntu docker image for faster performance (support swift/ruby out of the box)

Optional

1. swift lint --autocorrect and auto commit changes on PRs as a new commit

Considerations

1. Autocorrect may be controversial to some. If done as a new commit, easier to review what the bot added

Examples

1. https://github.com/Provenance-Emu/Provenance/blob/develop/.swiftlint.yml
2. https://github.com/HeroTransitions/Hero/blob/develop/.swiftlint.yml

Hey @bmoliveira .
Thanks for RxReachability!
I have a question about using RxReachability with Carthage. As I see, original Reachability class from SwiftReachability is declared with public visibility. As I am using RxReachability as a Carthage module, I assume that it should be open instead. As a result, I'm able to import RxReachability in my swift file but Reachability.swift itself is not accessible. Would be glad to receive an advice on the topic.

Thanks in advance,
Alex

Hey All! Great library.
It seems that the podspec is not updated and also lacks maintenance in the past few months.

I wondered if you considered moving the project to https://github.com/RxSwiftCommunity so its possibly maintained by an entire community, instead of just a single contributor - thus increasing its visibility and surrounding community.

Thanks for your consideration :)
Shai.

Can you please upgrade to support the newly released RxSwift 6.0

For me, I'd like to get the current networking status in the majority of cases rather than the change events.
How about this?
reachabilityChanged .map { $0.connection }.startWith(base.connection)

This library is requiring RxSwift 4 specifically preventing projects using it to upgrade to RxSwift 5. Please make a major version bump to this library and upgrade it to support RxSwift 5

Overview

Currently, everything is merged to master. This is considered bad form imho.

I intend to use a standard git-flow branch naming scheme

Requirements

1. Create a develop branch
2. Change the default branch to develop (required to Pull Requests automatically are set to said branch as the base)
3. Lock pushes to master for everyone
4. Lock pushes to develop for everyone, require PR checks to pass for merge, allow admins to force push over-ride

2-4 requires I get admin control of this repo, waiting on @freak4pc or whomever else is a current admin to upgrade my ownership rights on this project.

Add the new syntax of supported swift versions on the podspec and remove the .swift_version file.

Describe the bug

While moving all of our dependencies from CocoaPods to SPM, the only library that won't build at the moment is RxReachability, therefore blocking us from moving all of our Rx related dependencies to the SPM.

Problem lies in the underlying dependency to Reachability.swift which does not specify the minimum version. Xcode 12 is now treating iOS8 Target as a warning, so all of SPM modules without clearly defined minimal version is resolving to iOS 9.0.

At the same time, RxReachability have a requirement still pointing to iOS 8 as a minimal version, creating an error while building:

The package product 'Reachability' requires minimum platform version 9.0 for the iOS platform, but this target supports 8.0

To Reproduce

Try to use RxReachability via SPM on Xcode >= 12.4

Expected behavior

I want to use RxReachability via SPM on newest Xcode.

Overview

isConnected and isDisconnected are Observable<Void>, events to assist observing when these events occur.

They are not bool, since they are not to be read as variables, rather as participants in event flow.

I would argue the naming should reflect that fact better by removing is prefix, which ObjC/Swift devs conforming to best practices reserve for bool return types.

Requirements

1. Create new functionally identical public interfaces with the 'is' prefix removed
2. Remain backwards public API compatibility (for the time being)

Considerations

1. Removing them all together would be an api breaking change, requiring a new major version 2.0
2. Adding a distinctUntilChanged between isReachable and the filter

Discussion

Most likely I will want to see these vars renamed, and convenience legacy vars that transparently return the newly renamed observables.

The current vars should be marked deprecated for a future major version release using swifts @Availability renamed metadata markers.

Describe the bug

Can you please change the small syntax error while installing pod it should be -> pod 'RxReachability', '~> 1.2.1' you misplaced symbol. Thank you!

To Reproduce

Expected behavior

Screenshots/stack traces/Logs

Version

Additional context

• Cartfile
  github "RxSwiftCommunity/RxReachability" ~> 1.2.1

• Terminal Log

*** Skipped building RxReachability due to the error:
Dependency "RxReachability" has no shared framework schemes for any of the platforms: iOS

Add a Dangerfile to improve PR quality control automation

Samples from some of my other projects,
https://github.com/Provenance-Emu/Provenance/blob/develop/Dangerfile
https://github.com/HeroTransitions/Hero/blob/develop/Dangerfile

Can you please release 1.1.0 to cocoa pods? Currently cocoa pods still depends on ReachabilitySwift 4.3.1
Thanks in advance

Adding the pod lint to the test phase to make sure when a release build is run it will pass that at least.

In readme.md: print("Reachability changed: \(reachability.currrentReachabilityStatus)")

Extra r in current.

I have a branch ready for the fix if needed 👍

The iOS minimum version on Carthage is 12.0. Shouldn't it be 8.0 just like on Cocoapods?