rubjo / victor-mono Goto Github PK

This is a suggestion where I'm quite unsure about how much others would like it, I often see the ":" aligned more lower, but it always looks a little off to me at least.
If wanted, this change would be neat to have :)

Current alignment examples:

Hi everyone,

I don't get the font + ligatures working on my vs code (windows). Do I have to put the files in a specific folder on my pc? I made font to Victor Mono & enabled the ligatures.
Any suggestions?

Kind regards,
Brecht

Hey,

I got a notification that v1.2.6 was released. To build the AUR package I was using VictorMonoAll.zip archive located in public/ directory.

This time this file was not updated. I assume it's just a simple mistake, yet wanted to let you know. Could you update this archive so I can build the AUR archive with the newest version?

Thanks!

More of a FYI, but feel free to add the link to your website / README. Also helpful if you want more screenshots.

https://marketplace.visualstudio.com/items?itemName=tomByrer.nord-city-theme

PS, hope you don't mind I borrowed your website code for a demo ;)

Hey,

just wanted to let you know that I've created an AUR package for Archlinux distros.
https://aur.archlinux.org/packages/font-victor-mono/

You can include this link in the installation notes (if there are any), or not. The choice is yours :)

Great work with the font!

Why is it happening?
Victor mono font:

Other monospace fonts:

Hi there,

I'm attempting to install the TTF (Also tried OTF) fonts onto my work windows 10 machine. When I select the font files, right-click and select "install" - it simply states that "the file does not appear to be a valid font".

Any suggestions?

Having a variant that has the star character (*) higher up like in the Consolas font would be nice, though I'm unsure of how inconvenient it would be to provide multiple variants

First of all I love the font, great work 👍

Can I suggest changing the <= and >= to be with a flat bottom line?

And maybe changing the 'I' and 'T' in italics?

Windows 10
JetBrains PyCharm

The code is

image-id="...

Hello! Have any package of this amazing font without the italic part?

Tks!

Many thanks for the super quick reaction to issue #2
Unfortunately, this is embarrassing, I think I was not clear in my text, I meant that "greater or equal" (> followed by =) and "smaller or equal" (< followed by =) should be handled as ligatures.
Here an example on how it is handled in Fira Code:

Sorry for the confusion.

When executing brew cask install font-victor-mono I get the following error

Error: Cask 'font-victor-mono' is unavailable: No Cask with this name exists.

➜ brew cask install homebrew/cask-fonts/font-victor-mono 11:42:46 PM
==> Satisfying dependencies
==> Downloading https://rubjo.github.io/victor-mono/VictorMonoAll.zip
######################################################################## 100.0%
==> No SHA-256 checksum defined for Cask 'font-victor-mono', skipping verification.
==> Installing Cask font-victor-mono
==> Purging files for version latest of Cask font-victor-mono
Error: It seems the Font source '/usr/local/Caskroom/font-victor-mono/latest/OTF/VictorMono-ItalicBold.otf' is not there.

~/Development/workcation-splash via ⬢ v11.10.0
➜ brew cask install caskroom/fonts/font-victor-mono 11:47:36 PM
==> Satisfying dependencies
==> Downloading https://rubjo.github.io/victor-mono/VictorMonoAll.zip
Already downloaded: /Users/evansparkman/Library/Caches/Homebrew/downloads/43b6f0d85f1a05524cab0ba69b5100f5a94726ed197cdb3d8d17d024da9d7b35--VictorMonoAll.zip
==> No SHA-256 checksum defined for Cask 'font-victor-mono', skipping verification.
==> Installing Cask font-victor-mono
==> Purging files for version latest of Cask font-victor-mono
Error: It seems the Font source '/usr/local/Caskroom/font-victor-mono/latest/OTF/VictorMono-ItalicBold.otf' is not there.

Thank you for this amazing font! I'm curious if you've considered, or would consider, adding a ligature for :: with tighter spacing between the two colons (like Fira Code does)?

I think the ampersand looks a bit odd, it does not follow the same nice style as the rest of the font. "&&" style of writing code is quite common in any language and making them nicer would be worth it.

Example:

But maybe that's only me?

Maybe some smoother italic-specific ones for the cases where the glyphs just about connect anyway

Currently, there are word not match with the font.

Example:

This only happens in some font size, I'm using this in VS Code, hope that it isn't VSC causing the issue. If further info is needed, I'll be happy to give them!

See also: tonsky/FiraCode#405

First of all thank you for that beautiful font!
Would it be a big issue for you to add some spacing information?
My terminal is kitty and it does not accept fonts without the spacing information in its metadata. You can find details more here: #486 #1372

Hey,

I just updated my Mac and the font stopped working all together.
As of now I have tried the following:

• reinstall the font
• reinstall VSCode
• reset my machine( I had to do it anyway because Catalina update broke some of my other utilities as well).

I don't know if this is something because of Homebrew.
So, it would be great if you could look into it.

Cherrs,

Sohil

I for one would love to install the font from homebrew. Makes keeping it up to date so much easier. Don't really know what it involves and if it's too much work to keep up to date in brew, tho.

https://github.com/Homebrew/homebrew-cask-fonts

Very nice font btw, good work!

I love this font, but I can't get myself to get over this alignment of brackets for some reason, and it's the only thing really holding me back from using this font :(

An example of this is:

Would it be possible to remove this alignment or make it less strong?

for what it's worth, mathematical angle brackets do not render well. E.g. in |Ψ⟩⟨Ψ|, the brackets should match the size and position of the vertical line.

Lovely font. Great job. But those ligatures stand out like a sore thumb.

font is tooooo thin almost unreadable, need to set it bold so it is readable.

The Greek capital letter 'Θ' has the middle bar rendering above the character. This is using the OTF version of the font, on macOS High Sierra (10.13.6). This is an issue that appears to be in every font variation.

Hey there,

I've been trying to figure out why some capital italic letters are cut off or render smaller, eg. see letter 'Q' here:

I opened an issue on kitty (the terminal I use): kovidgoyal/kitty#2028 - but it seems like the problem is with the font.

Quoting from the kitty docs:

The number of cells a unicode character takes up are controlled by the unicode standard. All characters are rendered in a single cell unless the unicode standard says they should be rendered in two cells. When a symbol does not fit, it will either be rescaled to be smaller or truncated (depending on how much extra space it needs). This is often different from other terminals which just let the character overflow into neighboring cells, which is fine if the neighboring cell is empty, but looks terrible if it is not.

Some programs, like powerline, vim with fancy gutter symbols/status-bar, etc. misuse unicode characters from the private use area to represent symbols. Often these symbols are square and should be rendered in two cells. However, since private use area symbols all have their width set to one in the unicode standard, kitty renders them either smaller or truncated. The exception is if these characters are followed by a space or empty cell in which case kitty makes use of the extra cell to render them in two cells.

I'm not sure why this happens, but in my Windows Terminal this happens to some of the entries. Any ideas?

Windows Terminal (Preview)
Version: 0.3.2142.0

Windows 10
JetBrains Pycharm

The first line of code is

@register(...

Thank you very much for font. But I would like to be able to write comments in the code in Russian.
P. S. Where I can download Glyphs project file?

Esperanto support requires just a dozen glyphs with diacritics: ĉ, ĝ, ĥ, ĵ, ŝ (circumflex) and ŭ (breve), plus the uppercase variants.

Not 100% happy with all the italic glyphs yet, so at some point, alternative solutions should be explored.

With lowercase letters it seems somewhat fitting, but then it won't match the parentheses either.
Moving them up would seem more fitting :)

I found this font via your recommendation on thread open-source-ideas/ideas#10

I love the font, I really want to use it, but I just can't get it to work well with any dark theme in VS Code. I usually use Fira Code so this is what I can compare with, and I really prefer dark themes like most developers do.

I have tried a ton of different Color Themes, the one in the screenshot below is markskelton.one-dark-pro-italic which supports italics for comments and keywords.

With Victor Mono:

With Fira Code:

You can see how easy it is to read Fira Code, and while Victor Mono looks great it just isn't legible for some reason. It's like it is too thin for this dark background.

I am using default font smoothing (subpixel rendering), default font weight, I installed the .TTF files, I am using a Mac. I have tried different smoothing and it just makes things worse.

Sad fact is that this font is more legible on light themes 😢

So I guess I would like you to try VS Code, see if you can get Victor Mono to work well with a Dark Theme and then share your findings and screenshots. This would help me a lot.

Not an issue, more of a question. How did you achieve the terminal look in the screenshot on your website and in the readme? When I set Victor mono as my font in iTerm2 with Oh my ZSH none of the icons work.

I do not agree about the little twist of the ff, fl and fi ligatures (part understandably) bothering (#1) some, but hey, that's your font and it should stay like that.

But , <= and >= missing ligatures are a pain in the ass and wayyyy more important :-D :-D

btw, thanks a lot for that great work, this instantly became my PhpStorm font!

Background

hello! since switching from terminal Vim to MacVim, I've noticed that fl and fi render improperly, making text such as fixme, fluid, and config illegible and messing up the rest of the line.

within MacVim, a similar issue has been raised for a different font, albeit for different characters: macvim-dev/macvim#841

I have been unable to replicate this issue with any other font on my machine that uses ligatures, so I'm curious as to whether this is not a MacVim-specific rendering problem, whether similar behavior can be replicated, and whether this is the correct place to make note of it.

given the discussion on whether the ligatures in question should be included at all, this issue slightly relates to: #1

thanks!

Screenshots

set macligatures

set nomacligatures

As title.

Is there any plan to publish webfont with font-face stylesheet to npm registry?

I tried to install the font via brew cask but it throws an error saying
"Cask 'font-victor-mono' is unavailable: No Cask with this name exists."
Below is screenshot:

@rubjo Can you please point out if anything have to do prior to downloading the font?

I have installed the font on a Windows 10 system and cannot get the cursive to show in ether code or the insiders build. both IDE's are up to date and using the default dark theme