Giter Club home page Giter Club logo

Comments (10)

klippx avatar klippx commented on May 13, 2024 11

Looks great now. Reinstalled fonts using brew, using

  "editor.fontFamily": "Victor Mono",
  "editor.fontLigatures": true,
  "editor.fontWeight": "600",
  "editor.fontSize": 16

Selecting "Victor Mono Medium" does not work at all if you have installed the font via Homebrew. At least not for me.

from victor-mono.

aeadedoyin avatar aeadedoyin commented on May 13, 2024 6

@klippx
I had the same issue too.
Here's what I did and it became legible.

"editor.fontFamily": "Victor Mono Medium", //i.e. add "Medium"
"editor.fontLigatures": true,
"editor.fontWeight": "700",  //To make it even bolder (Though optional) 

from victor-mono.

rubjo avatar rubjo commented on May 13, 2024 1

Hi, and thanks for the kind words.

This issue is familiar from my sporadic attempts to try to like VS Code.

The fix is either to wait for either:

  • VS Code to render fonts on Mojave more like other apps do (there's some recent activity there, so might happen pretty soon. See here, for example: microsoft/vscode#59887)
    or
  • Me to release the font with heavier weights – it is, after all, very thin in its only version so far, but that's because it just follows my personal preference in how it appears on ST3 / macOS. Don't know when this will happen, just loose plans for now.

😄

from victor-mono.

rubjo avatar rubjo commented on May 13, 2024 1

I don't think it matters.

I had a look at how much work adding some more weights entails. It shouldn't be a massive job, but will take some time. Check again in a few weeks :)

from victor-mono.

rubjo avatar rubjo commented on May 13, 2024 1

Can you give the new version with multiple weights a go and post back what you think?

I typically found that VS Code needs ~ two higher levels of weight than Sublime Text (or any browser) for the font to appear roughly the same. Weird stuff.

😃

from victor-mono.

rubjo avatar rubjo commented on May 13, 2024 1

Closing this one now, more weights are added to make VS Code rendering a little more agreeable. TTF hinting might arrive later at some point.

from victor-mono.

klippx avatar klippx commented on May 13, 2024

To anyone else experiencing the same issue.

I found out that to make a decent workaround you currently have these options:

  • Change theme in vs code (just need to find one that has the italics you want for keywords/comments/etc AND is to your liking)
  • Tweak screen settings; mainly increasing brightness and tuning contrast. Try quick "mode" changes (Gaming, Movie, etc)

In the end I still managed to use the theme in the original screenshots, so I fixed by tweaking monitor.

I think that a slight heavier font weight would be another workaround but means more work for you. I have no idea between 100-900 what would be a good choice.

Btw, it doesn't matter on Mac which file I use to install? TTF, WOFF, WOFF2, OTF or EOT?

from victor-mono.

necmettin avatar necmettin commented on May 13, 2024

This is not a problem specific to Victor Mono actually. All 'light' fonts are pretty much unreadable or unusable in dark color schemes. Sublime and VSCode use different antialiasing (VSCode calls this font aliasing) techniques by default, you might try changing them (if the new weight rubjo provided don't work for you).

from victor-mono.

kurtextrem avatar kurtextrem commented on May 13, 2024

Maybe adding a TTF hinted version could also help (at least on Windows, for ClearType)

from victor-mono.

akrsnr avatar akrsnr commented on May 13, 2024

"editor.fontFamily": "Victor Mono",
 "editor.fontLigatures": true,
 "editor.fontWeight": "500", // italic comment calligraphy support starts from 500 as far as I explore
 "editor.fontSize": 16

from victor-mono.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.