rodmax / factory-t Goto Github PK

When call buildList with only count param which equal to 0 method throws error

factory.buildList({ count: 0})

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: .github/renovate.json
Error type: The renovate configuration file contains some invalid settings
Message: Configuration option 'ignorePaths' should be a list (Array)

changelog bump, etc

This issue provides visibility into Renovate updates and their statuses. Learn more

Other Branches

These updates are pending. To force PRs open, click the checkbox below.

• chore(deps): update dependency semver-regex to 3.1.3 [security]
• chore(deps): update dependency tmpl to 1.0.5 [security]

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency @types/jest to v27.0.2
• chore(deps): update dependency jest to v27.2.5
• fix(deps): update dependency typescript to v3.9.10
• chore(deps): update commitlint monorepo (@commitlint/cli, @commitlint/config-conventional)
• chore(deps): update dependency eslint-plugin-jest to v24.7.0
• chore(deps): update typescript-eslint monorepo to v4.33.0 (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• chore(deps): update actions/setup-node action to v2
• chore(deps): update dependency eslint to v8
• chore(deps): update dependency eslint-plugin-jest to v25
• chore(deps): update typescript-eslint monorepo to v5 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• fix(deps): update dependency typescript to v4
• Click on this checkbox to rebase all open PRs at once

• Check this box to trigger a request for Renovate to run again on this repository

It seems sonar has its own coverage ability. if it is suitable, we need use it and remove codecov service from CI flow

Hi @rodmax,

First, I wanted to thank you for this great library. Lightweight, with strong typings, and it has covered all my use cases so far. Awesome job!

I found an issue when working with optional properties, though. Usually, optional properties are not included in the factory definition (that's why they are optional, right?). However, at this point, it's not possible to add a value for an optional property using the partial param of .item(..) for example.

The only workaround I found is to set the property in the factory definition as undefined. But IMHO, I think that defies the purpose of an optional property, and it's also a little cumbersome to add undefined for all optional properties to avoid this issue.

Here's an example in a small playground I created: https://codesandbox.io/s/factory-t-playground-r9ueq?file=/src/index.ts

Let me know if this makes sense to you. Also, I'll be happy to help out with a PR if you point me in the right direction.

Cheers!

TODO: explain reason and new approach