Optional properties cannot be added with partial param unless defined in the factory about factory-t HOT 4 CLOSED

Hi @JoseLion. Thank You for feedback.
First. Yes. It makes sense for this library because of one of the base requirement: strongly follow to target type

I quickly look into implementation and see that approach for optional already exists:

import { factoryT, FactoryT, fields } from 'factory-t';

interface WithOptional {
  password?: string;
}
const factory = factoryT<WithOptional>({
  password: fields.optional('default'),
});

BUT it is not working properly and just makes typing trick, not really makes field optional 😞

I believe it's needed to enhance fields.optional() approach something like so:

const factory = factoryT<{key?: string}>({
  key: fields.optional(fields.NOT_SET_VALUE)
  // or
  key: fields.optional(), // empty argument means that by default key is missing in generated item
  key: undefined, // this last not appreciable due to not recognizes {key: string | undefined} with {key?: string}
})

console.log(factory.item())
// {} instead of {key: undefined}
console.log(factory.item({key: 'hello'}))
// {key: 'hello'}

I see some difficulties with typing of such an approach

I play with it evening and reply

from factory-t.

Usually, optional properties are not included in the factory definition

Oh, I missed one point provided by you 🤔. Right now I am not sure it may be implementable but I promise think about it too

from factory-t.

@JoseLion look at this solution: #111
Will it solve the problem?

if something confuses you or you have ideas for improvement(semantic/API), then do not hesitate, and let me now

from factory-t.

@rodmax awesome! Yep, I think that solves the issue. Thanks a lot for looking into it 🎉

from factory-t.