More elegant solutions to copying repo to container/image...? about binder HOT 3 CLOSED

Right, I think we should just have the block

COPY . ${HOME}
USER root
RUN chown -R ${NB_UID} ${HOME}
USER ${NB_USER}

built into the rocker/binder Dockerfiles here to begin with. I believe that's what the default Dockerfile already does in binder, so it makes sense we copy that behavior. @yuvipanda is there a reason we haven't done this with the Dockerfiles here?

(of course it's a pity Docker doesn't support a more elegant handling of this / of non-root user permission model in general, but that issue is above my pay grade)

from binder.

pinging @yuvipanda Should we add the above to these Dockerfiles? This is necessary to get the install.R behavior shown on https://github.com/binder-examples/dockerfile-rstudio to actually work, right? Should we also add the RUN call to run any install.R script it finds?

Thanks!

from binder.

Not sure what I was thinking, clearly COPY has to be done in the repo's Dockerfile and not here. Sent a PR to add it to the binder-examples/dockerfile-rstudio, which was missing the chown commands.

from binder.