Giter Club home page Giter Club logo

Comments (3)

cboettig avatar cboettig commented on July 24, 2024

Right, I think we should just have the block

COPY . ${HOME}
USER root
RUN chown -R ${NB_UID} ${HOME}
USER ${NB_USER}

built into the rocker/binder Dockerfiles here to begin with. I believe that's what the default Dockerfile already does in binder, so it makes sense we copy that behavior. @yuvipanda is there a reason we haven't done this with the Dockerfiles here?

(of course it's a pity Docker doesn't support a more elegant handling of this / of non-root user permission model in general, but that issue is above my pay grade)

from binder.

cboettig avatar cboettig commented on July 24, 2024

pinging @yuvipanda Should we add the above to these Dockerfiles? This is necessary to get the install.R behavior shown on https://github.com/binder-examples/dockerfile-rstudio to actually work, right? Should we also add the RUN call to run any install.R script it finds?

Thanks!

from binder.

cboettig avatar cboettig commented on July 24, 2024

Not sure what I was thinking, clearly COPY has to be done in the repo's Dockerfile and not here. Sent a PR to add it to the binder-examples/dockerfile-rstudio, which was missing the chown commands.

from binder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.