digitalWriteFast would be nice to have about opencr HOT 6 CLOSED

I also hacked up a version of ReadFast. I have not had much time testing to see if it speeds up much...

But included zip file so you can take a look.
opencr_gpio_speed_test-180430b.zip

from opencr.

Hi, @KurtE,

I checked your code and it is run well.
We have basically worked on the basic API compatibility of Arduino. However, from a performance standpoint, we thought it would be better to add more optimized APIs to the ARM core.

Therefore, I am pleased about your suggestion.
So, do you want us to add about the features of this issue? Or, do you want PullRequest as mentioned in #85 ?

If there are any improvements in the future, please leave an issue or PullRequest at any time.

Again, thanks for your contributions.

from opencr.

Right now, it would probably be better if you did the merge as it is unclear where/how you would like it.

As I mentioned on AVR, you have to include a library for this.

On Teensy it is integrated into Core. If I remember correctly it was in same header file that also declares digitalWrite and digitalRead. Also probably needs a standardized set of comments. I can do this if desired, but I usually prefer to do PR on simple fixes or extensions.

from opencr.

As I answered #85, you can PR to develop branch. (from develop branch based)
As you mentioned about the Teensy board, we also like to be integrated into Core.

I may merge myself into the .zip file you uploaded, but I think it would be better to leave your contribution.

Comments can be added or modified after PR, so please feel free to PR as you like.

Thanks :)

from opencr.

I put up first version of a Pull request in:
#90

Note: the user still has to include: #include <digitalWriteFast.h>
On the Teensy boards it is automatic, so I am torn between simply adding the stuff to
digital_wiring.h or add include of this file to digital_wiring.h

Let me know if you would like me to change anything

from opencr.

merged #90

from opencr.