Customising logger with winston erroring out in v19 about express-zod-api HOT 17 CLOSED

Need to check prototype in isBuiltinLoggerConfig.

Confirmed, @boarush
Thank you for reporting this.

from express-zod-api.

No-no, it does not interfere in their operation. It's just a check of the object shape.

from express-zod-api.

I think you misunderstood me, I am agreeing with what you suggested.

from express-zod-api.

@RobinTail I had also been using it in production with Winston specifically with v18. Didn't really face any issue or crashes.

from express-zod-api.

🚀 Should be fixed in v19.1.2 , @boarush
I tested it on your repo.
Thank you once again for your contribution!
I highly appreciate it.

from express-zod-api.

Thanks for the speedy fix!

from express-zod-api.

You need to set both levels and level.
Last one acts as a filter (ignores what's below it), @boarush

from express-zod-api.

@boarush , configuring winston is not easy, so I moved from it.
But you can check out how it was configured in v17 for inspiration

from express-zod-api.

Yep, it works, thanks a lot again!

from express-zod-api.

Seems to be similar to #1605 , @boarush

Trying to figure out why

from express-zod-api.

Was trying to figure it out myself, couldn't really narrow it down 😅

from express-zod-api.

The issue comes from the the problem of distinguishing a built-in logger config from an instance of actual logger.
I think I'm going to apply an inverted logic there, instead of isBuiltinLoggerConfig() it will be isActualLogger(), and use expression like this to check for the presence of a logging method both in the supplied argument and its prototype (class instance case).

"debug" in logger || "debug" in Object.getPrototypeOf(logger)

from express-zod-api.

I think this is general enough to not break popular logging libraries.

from express-zod-api.

Ok, thank you.
I checked the documentation:
in on the logger itself should actually be enough, since it does check the prototype chain.

from express-zod-api.

Checked this statement

worked as expected in v18

The issue is present in v18.

from express-zod-api.

Trying it my example repo with the latest v18 release, it worked. Not sure about other cases though.

from express-zod-api.

@RobinTail Another question, with winston, I'm only able to use 4 severity (debug, info, warn and error), all others don't work. How do I enable those for it? Have tried setting the levels config in winston.createLogger, and then using the generic logger.log with different levels, but it straight up ignores the logs for any severity other than these four.

from express-zod-api.