Giter Club home page Giter Club logo

Comments (11)

bobgubko avatar bobgubko commented on July 28, 2024 1

It did fix the issue! 0 errors during build.

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024 1

Awesome, thank you for letting me know.
I'm going to release it then, @bobgubko

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024

Could you please provide the complete text of the error messages, @bobgubko ?

——
Continuation of the issue #952

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024

However in my case declarations cannot be disabled. Is there a way to make it work with declarations enabled or my only option is to stay on 9.* version?

No, I can fix it by exposing the types needed for you to keep the declarations, but I need to know which ones are missing.
For that I'd like to ask you to provide the complete error messages so I could help you, @bobgubko

from express-zod-api.

bobgubko avatar bobgubko commented on July 28, 2024

Here are the errors I'm getting:

Errors
error TS4023: Exported variable '[..]' has or is using name 'BasicSecurity' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'BearerSecurity' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'CommonConfig' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'CookieSecurity' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'CustomHeaderSecurity' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'InputSecurity' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'MiddlewareDefinition' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'OAuth2Security' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'OpenIdSecurity' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4023: Exported variable '[..]' has or is using name 'ResultHandlerDefinition' from external module "[...]/node_modules/express-zod-api/dist/index" but cannot be named.
error TS4094: Property 'descriptions' of exported class expression may not be private or protected.
error TS4094: Property 'handler' of exported class expression may not be private or protected.
error TS4094: Property 'methods' of exported class expression may not be private or protected.
error TS4094: Property 'middlewares' of exported class expression may not be private or protected.
error TS4094: Property 'mimeTypes' of exported class expression may not be private or protected.
error TS4094: Property 'resultHandler' of exported class expression may not be private or protected.
error TS4094: Property 'schemas' of exported class expression may not be private or protected.
error TS4094: Property 'scopes' of exported class expression may not be private or protected.
error TS4094: Property 'siblingMethods' of exported class expression may not be private or protected.
error TS4094: Property 'statusCodes' of exported class expression may not be private or protected.
error TS4094: Property 'tags' of exported class expression may not be private or protected.

Isn't it easier to simply export all types used in the library so there's no need to worry about those errors?

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024

Thank you for elaborating, @bobgubko .

Isn't it easier to simply export all types used in the library so there's no need to worry about those errors?

I'm trying to be careful with what I export, because making backwards incompatible changes to the exposed entities is a breaking change requiring next major version according to SemVer.

TS4023

Ok. This is clear how to fix, exactly by exposing those types.

TS4094

This is weird. Need to do a research.

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024

What is your version of Typescript, @bobgubko ?

Question withdrawn.
I think I found a way to fix TS4094.

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024

Dear @bobgubko ,

could you please try version 12.1.0-beta2 and tell me if it fixes the issue?

from express-zod-api.

alindsay55661 avatar alindsay55661 commented on July 28, 2024

I am getting the same error for a different type (Metadata):

error TS4023: Exported variable '[...]' has or is using name Metadata from external module '[...]node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_exp_ul3mzpgqwyhnfja3iatztge55q/node_modules/express-zod-api/dist/index' but cannot be named.

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024

You should have created an issue for that, @alindsay55661 .
I may have not noticed your comment.

from express-zod-api.

RobinTail avatar RobinTail commented on July 28, 2024

Fixed in version 14.0.3, @alindsay55661

from express-zod-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.