winston detetction not sufficient about express-zod-api HOT 10 CLOSED

I think I'm getting now what's happening there.
Please stand by....

from express-zod-api.

how do you use that function createLogger that you made?
Please provide more context for reproducing the issue, @daniel-white

Please also read the corresponding article in Readme:
https://github.com/RobinTail/express-zod-api?tab=readme-ov-file#customizing-logger

from express-zod-api.

so createLogger is just a factory to encapsulate all the logging options - essentially the usage is like this

const logger = createLogger('info');
const config = createConfig({ logger }); // from express-zod-api, infers that it needs winston!

from express-zod-api.

I made a test for the function isSimplifiedWinstonConfig() against the pino instance as pino({level: "info"})

#1607

And that test passes. The function basically tells whether or not should winston be loaded instead.
Can not reproduce that behaviour so far.

What is your actual version of pino, @daniel-white

Could you run yarn why pino and tell me what is says?

from express-zod-api.

hm interesting i'm using 8.19.0 as well. looks like a good test to have and ill keep playing on my end.

also, fwiw, i'm using typescript's strict mode, should that matter.

from express-zod-api.

Are you sure you're supplying "info" to createLogger()?
Not one of these: "silent", "warn", "debug" , @daniel-white

from express-zod-api.

Since when it's "debug", the test fails and that's I believe exactly the case, @daniel-white

from express-zod-api.

@RobinTail i was doing a bit more. i'm getting that value from envvars, i opened it up to more levels. it might have been on debug yesterday

I'm allowing

['error', 'warn', 'info', 'debug', 'trace']

from express-zod-api.

Thank you @daniel-white , the issue confirmed.
I'll do my best to fix it ASAP.

from express-zod-api.

@daniel-white ,
🚀 the issue fixed in the recently released version 17.2.1 .
Thank you for the contribution!

from express-zod-api.