Giter Club home page Giter Club logo

git-mob-vs-code's Introduction

Hi πŸ‘‹

On the mind

My blog post about understanding Veganism. IMO, the best thing we can do is to go Vegan. Veganism is to achieve the goal of abolishing animal exploitation.

Animals killed for meat every year

Huge amounts of resources like water, crops, land, antibiotics and more go into keeping farm animals alive instead of humans directly consuming those essential resources. This is a very wasteful way to produce food. See global land use for food production.

Animal agriculture is the leading cause of deforestation creating a massive negative impact on our environment.

πŸ“Ί Eating Our Way to Extinction πŸ“Ί Milked πŸ“Ί Dominion (2018) πŸ“Ί Fish feel pain πŸ“Ί Milk: make your own mind up

πŸ“Ί Every Argument Against Veganism

πŸ–₯ Viva! Vegan charity πŸ–₯ Kindness project πŸ–₯ Challenge 22

Vegan books

πŸ“š This is Vegan Propaganda πŸ“š The sexual politics of meat πŸ“š Animal liberation

Projects

Git Mob cli (Git Mob npm) Co-author commits via your terminal

Git Mob Git Mob VS Code Co-author commits with ease! Visual Studio Marketplace Installs

Git ease Git Ease VS Code Helpful git log view in panel Visual Studio Marketplace Installs

🌱 I’m currently learning more TypeScript and started Svelte

πŸ“’ Check out my tech blog

git-mob-vs-code's People

Contributors

dependabot[bot] avatar r15ch13 avatar regisbsb avatar rkotze avatar viperet avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

git-mob-vs-code's Issues

Reload gitmob when a repository is created

Summary

When starting a new project, a user might initialise a new Git repo and Git Mob should become active then.

Currently when there is no repo detected then Git Mob displays nothing.

Motivation

If user want's to co-author initial commit they would have to restart vs code.

Notes

Look to use onDidOpenRepository

Watch for commit failed ENOENT: no such file or directory \.git\COMMIT_EDITMSG

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

Watch for commit failed!: ENOENT: no such file or directory '[project-folder].git\COMMIT_EDITMSG'

Steps to Reproduce

  1. Clone new project from GitHub
  2. Setting "Post commit: Solo" is checked - prior to opening VS Code
  3. Open VS Code
  4. Git Mob panel does not load
  5. Can see an error message in dev tools console

Expected behaviour: Git Mob panel should load in as usual. Error message should show if something has gone wrong

Actual behaviour: Fails silently and Git Mob panel does not render anything

Reproduces how often: 100%

Versions

  • operating system and version: Windows 10
  • git-mob-vs-code version: 1.10.1
  • git-mob version (git-mob --version): 1.1.0
  • git version (git --version): 2.21.0.windows.1

git-mob as dev dependency

Implement / allow to use git-mob from package.json / project devDependencies.

Summary

Allow the user to toggle a setting to use Git Mob cli as a devDependencies or as a global package.

By default, it should use global git mob.

Global command is git mob <initials>

Local command is npx git mob <initials>

Reminder to change co-authors

Summary

You might rotate pairs or mob in your team and forget to update Git Mob list. Trigger an alert when a certain amount of time has passed to prompt a change.

Provide a configuration option to specify the amount of time to wait before the alert is triggered.

Another option is to also run the solo command to reset the git mob to just the author after a certain amount has passed.

Motivation

Prevent accidental commits with the wrong pair attributed

UI: Make it more obvious what happens when you click on somebody's name in the search list

Summary

When you click on Search next to More co-authors and you click on somebody's name, it puts that person in the Unselected group. However, that is not obvious. It would be good to add some help text in the list like "Select a person to move to the Unselected list." I have been using for a while before I figured that out. Alternatively, filter the "More co-authors" list in the "More co-authors" pane.

Motivation

Make the application more intuitive.

Describe alternatives you've considered

Display a message after someone is selected "Added to unselected list".

Additional context

Reload Git Mob action

Git mob stores the co-authors in memory after the first load.
If the .git-coauthors file changes, those updates are not reflected in the list.

Tasks:

  • Provide a reload action in the main title bar next to open .git-coauthors file.
  • Watch for changes to this file to trigger a reload of the list.

Select multiple authors to co-author

Summary

Be able to select multiple "unselected" co-authors to move into "co-authoring" section.

Should be able to press shift or control to select multiple co-authors.

Motivation

Helpful when mob programming it would be move convenient to select a group and add than adding one at a time.

Describe alternatives you've considered

Additional context

Add option to clear co-authors after commit

Summary

After a commit, the co-authors are automatically added to the next commit. This makes sense in the context of a mob session. However, for more sporadic collaboration where you have only a few commits that are shared with others its more convenient to remove the coauthors after a commit.

Motivation

see above

Describe alternatives you've considered

Additional context

Given the scope of this extension, I wouldn't change the default behavior and only add an option that toggles the clearance of authors after a commit.

Can't handle private email address and special chars in initials key

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

The extension can't read private email addresses from the .git-coauthors file. (e.g. [email protected])
If the initials key of a user contains special characters like č or ß then it also fails to load the file.

Steps to Reproduce

  1. Add user with private mail to .git-coauthors file
{
  "coauthors": {
    "toßč": {
      "name": "Tony Stark",
      "email": "[email protected]"
    }
  }
}
  1. Try using the extension

Expected behaviour: [What you expect to happen]
Should list the Author

Actual behaviour: [What actually happens]
Fails with list is not iterable error.
image

Versions

  • operating system and version: Windows 10
  • git-mob-vs-code version (can be found in the Extensions tab): 1.1.1
  • git-mob version (git-mob --version): 1.0.1
  • git version (git --version): 2.20.1.windows.1

Additional Information

const regexList = /^([a-zA-Z0-9_\-\.]+)\s(.+)\s([a-zA-Z0-9_\-\.]+@[a-zA-Z0-9_\-\.]+\.[a-zA-Z]{2,5})/;

Simply changing the regex to /^([\S]+)\s(.+)\s([a-zA-Z0-9_\-\.\+]+@[a-zA-Z0-9_\-\.]+\.[a-zA-Z]{2,5})/ should fix these two issues. Changing the first part to [\S]+ will match everything until the whitespace that separates the name from the key.

UI Proposal: Replace Unselected and More with Favorites

Intention: Make it easier to remove and add items from the different sections, and change titles of sections to make it more obvious

  • Change the title Unselected to Favorites.

  • Change the title More to Current Repo Users

  • In Co-author section, add two buttons next to each name

    • a heart to add a person to Favorites. Greyed out if already in favorites
    • an x to remove a co-author without adding to Favorites
    • add a search icon at the top which brings up the List dialog
  • In Favorites (previously titled Unselected) section, add two buttons next to each name
    - a + to add a person to the Co-authors section without removing from favorites. Greyed out if already selected.
    - an x to remove a person from the Co-authors section

    • add a search icon at the top which brings up the List dialog
  • In Repository Users section (previously titled More), add two buttons to each user:
    - a + to add a person to the Co-authors section. Greyed out if not applicable.
    - a heart to add a person to the favorites section. Greyed out if not applicable.

    • add a search icon at the top which brings up the List dialog

Show a select list of valid GitHub emojis

Summary

Using emojis on commit messages provides an easy way of identifying the purpose or intention of a commit with only looking at the emojis used.

See Gitmoji

Provide a select list which can be filtered. Selecting an emoji will prepend it to the source control input field.

Motivation

Emojis help makes identifying commits easier but is annoying search for these on a website away from VS Code. This will save time looking up GitHub emojis and make writing commits quicker.

Solo fails when "selected" view is collapsed

Description

When running the solo command and the "selected" item is collapsed it then the authors selected are not removed from the input box.

Steps to Reproduce

  1. Add a co-author to the selected list
  2. Collapse the selected item
  3. Click the solo icon on the selected item

Expected behaviour: Git input field is cleared of all co-authors and those authors are moved to the "unselected" list

Actual behaviour: Co-authors are in the git input field, authors are removed from selected list but not added back into the unselected list.

Reproduces how often: 100%

Versions

  • operating system and version:
  • git-mob-vs-code version 1.5.2
  • git-mob version 1.1.0:
  • git version 2.21.1:

Additional Information

Above image represents the actual behaviour description.

Optimistic update: toggling between selected and unselected

Summary

Instead of waiting for the command line to successfully execute the command. It could be assumed the command will be successful and the UI can update straight away. This will communicate the action better to the user as there won't be a delay.

Motivation

It can look like the app is frozen because of the wait on the command line. This has a negative affect on the user experience. (Probably affects windows user the most as GitMob does seem to be the slowest there)

End to end testing

Summary

Enable end to end testing to check Git Mob loads in and features are available to interact with.

Motivation

  • Prevent top user flows from regressing
  • Learn how to e2e VS code extensions

Additional context

Already started integrating e2e tests with jest as the test runner.

b9299eb

View the last 10 commits in the SCM view

Summary

Providing a view of the latest 10 commit messages will help provide at glance information useful for the next commit. e.g. a commit code or context of what was finished.

Can be part of the Git Mob list in SCM view as the first item above the author.

Motivation

Help the committer have information about the latest commit with no effort.

See primary Git Mob actions on other title bars

Description

You can see Git Mob actions (icons) on other title bars which don't belong to the extension.

Steps to Reproduce

  1. Open output view
  2. you see open .git-coauthors file, reload and tweet

Expected behaviour: Not be visible and icons belong only on Git Mob title bar

Actual behaviour: Visible icons

Reproduces how often: 100%

Versions

  • operating system and version: Windows
  • git-mob-vs-code version 1.4.0
  • git-mob version 1.1.0
  • git version 2.21.0.windows.1

Additional Information

Currently happening:

image

Prerequisites

  • [Checked that your issue isn't already filed][git-mob-vs-code issues]
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

See git-mob actions on other extension title bars

Description

You can see the git-mob actions open git-coauthors and reload on other extensions like git-lens.

Steps to Reproduce

  1. Open the git view in VS Code and open the git-mob title
  2. Then navigate to another extension like git lens
  3. Hover mouse over a title bar and you should see git mob actions

Expected behaviour: [What you expect to happen]

You should not see the git mob actions

Reproduces how often: 100%

Versions

  • git-mob-vs-code version v1.0.1
  • git-mob version v0.6.0

Actions should not be there

On selecting co-author: Failed to update input: Cannot read property 'inputBox' of undefined

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version
  • Tried upgrading to the latest git version

Description

Fresh install, vs code version 1.52.1. Clicking on a user to add them as co-authors results in dialog with error message:

Failed to update input: Cannot read property 'inputBox' of undefined

Steps to Reproduce

see above

Expected behaviour: User gets added to selected co-authors.

Actual behaviour: Error message appears, user stays unselected.

Reproduces how often: Every time until now.

Versions

  • operating system and version: Ubuntu 19.10
  • git-mob-vs-code version: v1.11.0
  • git-mob version (git-mob --version): 1.1.0
  • git version (git --version): 2.28.0

List authors in repository and include an add function

Summary

To make it easier for users to add co-authors list existing authors in the repository and include an add to co-authors function.

Motivation

It will make it super easy to get started and adding existing authors to the co-author file.

Error message if Github PAT not entered or if no results

Summary

When you try to search an entire github repository, give an error if the Personal Access Token has not been set. "Personal Access Token has not been set. Create a Personal Access Token with User:Read access, if not already done. Set the Personal Access Token for Github Co-authors."

If no records returned, display error message
"No records found. Check the name and confirm the Personal Access Token setting is correct and the token has User:Read privilege."

Motivation

Better user experience

Describe alternatives you've considered

Checking if the Personal Access token has User:Read privileges if no users found and tailor message based on that. I don't think that is worth the effort.

Additional context

Open git-coauthors file from sidebar doesn't work on Windows

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

Clicking the Open git-coauthors file button in the sidebar results in an error.
The replace regex in git-mob-coauthors-file.js#L13 removes the drive letter which results in wrong path.
file:///Users/r15ch/.git-coauthors or \Users\r15ch\.git-coauthors

Steps to Reproduce

  1. On Windows 10 using VSCode Portable
  2. Click Open git-coauthors file button

Expected behaviour: [What you expect to happen]
Should open .git-coauthors file

Actual behaviour: [What actually happens]
image

Versions

  • operating system and version: Windows 10
  • git-mob-vs-code version (can be found in the Extensions tab): 1.1.1
  • git-mob version (git-mob --version): 1.0.1
  • git version (git --version): 2.20.1.windows.1

Additional Information

Handle VS Code Live share co-author attribution

Summary

When pair programming using VSCode liveshare Git Mob panel guess view should sync up with host.

As a guest user of the live session
When viewing the git mob panel
Then I see I am selected as a co-author
And I see the host user as the author

As a host user of the live session
When viewing the git mob panel
Then I can see participates
And can add them as co-authors in the commit

Motivation

The guest can see they will be attributed in the commit as a co-author.

Makes it easy for the host user to include the guest as a co-author.

Additional context

VS Code live share Github issues

Related issues:

Investigations

Looks like npm package vsls is used for integrating extensions.

Example extensions using it: https://github.com/vsls-contrib/pomodoro, https://github.com/hbenl/vscode-test-explorer-liveshare

Add Search to Unselected list.

Summary

Add a search option for the Unselected list, like the More Authors option.

Motivation

Make it easier to use when lots of people in the Unselected List.

Change the primary author

Summary

You might want to change the primary author to match different GitHub profiles a user might own.

Motivation

Git mob CLI makes this easy and should be an available feature here as well

Add new co-authors to list through VS Code

Currently the only way to add new co-authors to Git Mob is to open the .git-coauthors file in your user directory and update the JSON object. See example in Git Mob repo

This does mean there is a dependency on updating Git Mob command line package to support this feature.

Search list of repository authors

Summary

If repository has a lot of contributes it can be frustrating to scroll through all repository authors. A basic search/filter by name functionality would help quickly find an author.

Selecting a user will add them to the selected list in the user and update the co-author file.

Motivation

Make it easy for a user to find authors that have contributed to the repository.

Open VS Code in sub-directory of a project Git Mob does not show co-authors

Prerequisites

  • [Checked that your issue isn't already filed][git-mob-vs-code issues]
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

Opening VS Code in a subdirectory from where the root .git file is defined, the list of co-authors do not show.

Steps to Reproduce

  1. Open VS Code in sub-directory e.g. vs-code-git-mob/src
  2. Select the source control tab
  3. Git Mob co-authors empty

Expected behaviour: Show select and unselected co-authors

Actual behaviour: Git Mob co- authors empty

Reproduces how often: 100%

Versions

  • operating system and version: Windows 10
  • git-mob-vs-code version 1.2
  • git-mob version (git-mob --version): 1.0.1
  • git version (git --version): 2.18.0.windows.1

Additional Information

Sub-directory

Open vs code in a src folder of vs-code-git-mob directory

Cannot read property 'inputBox' of undefined

Description

When selecting a co-author an error appears "Cannot read property 'inputBox' of undefined".

This is an issue in the latest release of VS Code 1.51

Related bugs in VS Code logged which might fix the issue

Steps to Reproduce

  1. Click the plus button to select a co-author
  2. Error appears and unselected co-authors disappear

Expected behaviour:

Update SCM input box with the selected co-author, selected co-authors stay and no error alert shows.

Actual behaviour:

The error appears and unselected co-authors disappear.

Reproduces how often:

For one Git repositories 95% of the time.

Multiple repositories, as long as you have one selected the issue does not appear. However, when you click in the input box it becomes unselected and the error appears.

Mitigation

Reloading the whole of VS Code mitigates the issue as long as you don't interact with the SCM at all.

Versions

  • mac OS Catalina
  • git-mob-vs-code version 1.10.0
  • git-mob version 1.1.0
  • git version 2.24.3

Empty co-authors panel / Cannot read property 'email' of undefined

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

The GIT MOB CO-AUTHORS box in the git panel of VS Code is completely empty, and I get the following error whenever I click the commit message field or run the other git mob commands (like Git Mob: Add co-author): Cannot read property 'email' of undefined

Steps to Reproduce

  1. My .git-coauthors file looks like this (but the same happens when I make coauthors an empty object):
{
  "coauthors": {
    "alias": {
      "name": "My Buddy",
      "email": "[email protected]"
    }
  }
}
  1. Open VS Code's git panel
  2. Click in the commit message text box or run a command (like Git Mob: Add co-author)

Expected behaviour: I should see a list of project coauthors in the GIT MOB CO-AUTHORS box on the git panel of VS Code. I should be able to select co-authors, remove co-authors, etc.
Actual behaviour: The GIT MOB CO-AUTHORS box is completely empty and I get a Cannot read property 'email' of undefined error when editing my commit message or running any git mob commands.

Reproduces how often: 100% (for the last week or two... it was working well before that)

Versions

  • operating system and version: macOS Mojave 10.14.6
  • git-mob-vs-code version (can be found in the Extensions tab): 1.2.0
  • git-mob version (git-mob --version): 1.0.1
  • git version (git --version): 2.20.1 (Apple Git-117)

Additional Information

Show if using git-template or prepare-commit-msg hook

Git mob supports inline commits using the git hook prepare-commit-msg which also means that the co-authors don't print in the SCM input box because they are applied on committing.

Some sort of visual icon on the Git Mob title bar can be used to toggle and show the status git-template or prepare-commit-msg hook.

Update multiple Git message fields in source control view

Summary

A VS Code user could have multiple projects open which have their own Git repositories in a workspace.

Currently adding a co-author will only write to one of the Git message fields. What should happen is all the Git message fields are updated the selected/unselected co-authors.

Motivation

Improve the user experience when selecting co-authors across multiple projects.

Additional information

Git Mob CLI is local to each project rather than global meaning the co-author command will need to be run on each project. It's not as simple as updating each input field in the view as that would put the UI and CLI out of sync.

UI: Change in List dialog

  • options for search field:
    • add a drop down with two choices: All Github or Current Repo. If that is too difficult, add a title to the dialog box indicating which list.
    • add a checkbox, Current Repository Only
    • improve hint text: Seach for users in current repository or Search all github users
  • add two buttons to each user:
    • a + to add a person to the Co-authors section
    • a heart to add a person to the favorites section
  • consider not closing list when a user is selected to allow for selecting multiple or to add to both favorites and co-authors. I don't know if that would improve the UI or not.

Search for commits by co-author

Summary

Enable a search facility to look for commits by co-author meta data

git log --format="%h %s %(trailers:key=Co-authored-by)" list commits with co-authors.

Search git trailer options for more information

Motivation

Might be worth looking at past commits by a co-author.

Entering text directly in SCM input will removed on new VS Code focus

Entering text directly after coming back to VS Code in SCM input will remove that text

Steps to reproduce

  • Have SCM tab open
  • Focus on another window - e.g. to copy some text
  • Come back to VS code and paste directly into SCM input

Actual: Pasted text is removed
Expect: Text is not deleted

Error: could not determine executable to run

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

When using npm v7.0.5 seems like with the new version and the replacement of npx to run the git mob isn't working properly.

0 verbose cli [
0 verbose cli   '/Users/user/.asdf/installs/nodejs/12.18.3/bin/node',
0 verbose cli   '/Users/user/.asdf/installs/nodejs/12.18.3/.npm/lib/node_modules/npm/bin/npm-cli.js',
0 verbose cli   'exec',
0 verbose cli   '--',
0 verbose cli   'git',
0 verbose cli   'mob'
0 verbose cli ]
1 info using [email protected]
2 info using [email protected]
3 timing config:load:defaults Completed in 1ms
4 timing config:load:file:/Users/user/.asdf/installs/nodejs/12.18.3/.npm/lib/node_modules/npm/npmrc Completed in 1ms
5 timing config:load:builtin Completed in 1ms
6 timing config:load:cli Completed in 1ms
7 timing config:load:env Completed in 0ms
8 timing config:load:file:/Volumes/Workspace/project/.npmrc Completed in 0ms
9 timing config:load:project Completed in 1ms
10 timing config:load:file:/Users/user/.npmrc Completed in 0ms
11 timing config:load:user Completed in 0ms
12 timing config:load:file:/Users/user/.asdf/installs/nodejs/12.18.3/.npm/etc/npmrc Completed in 0ms
13 timing config:load:global Completed in 0ms
14 timing config:load:cafile Completed in 1ms
15 timing config:load:validate Completed in 0ms
16 timing config:load:setUserAgent Completed in 0ms
17 timing config:load:setEnvs Completed in 1ms
18 timing config:load Completed in 6ms
19 verbose npm-session 701ad7404671dde4
20 timing npm:load Completed in 11ms
21 http fetch GET 200 https://registry.npmjs.org/git 10ms (from cache)
22 timing command:exec Completed in 22ms
23 verbose stack Error: could not determine executable to run
23 verbose stack     at getBinFromManifest (/Users/user/.asdf/installs/nodejs/12.18.3/.npm/lib/node_modules/npm/lib/exec.js:243:23)
23 verbose stack     at exec (/Users/user/.asdf/installs/nodejs/12.18.3/.npm/lib/node_modules/npm/lib/exec.js:129:15)
24 verbose cwd /Volumes/Workspace/project
25 verbose Darwin 19.6.0
26 verbose argv "/Users/user/.asdf/installs/nodejs/12.18.3/bin/node" "/Users/user/.asdf/installs/nodejs/12.18.3/.npm/lib/node_modules/npm/bin/npm-cli.js" "exec" "--" "git" "mob"
27 verbose node v12.18.3
28 verbose npm  v7.0.5
29 error could not determine executable to run
30 verbose exit 1

Steps to Reproduce

  1. Install npm 7
  2. Use latest version of git-mob-vs-code
  3. try to open gitmob on vscode

Versions

  • operating system and version: MacOS 10.15.7
  • git-mob-vs-code version: 1.9.0
  • git-mob version (git-mob --version): 1.1.0
  • git version (git --version): 2.29.1

Additional Information

Git mob as command line tool is working properly, it's just the vscode plugin failing.

Provide main options when Git Mob CLI errors

Summary

Sometimes when Git Mob CLI errors in someway like JSON format error then all Git Mob vscode commands fail to load which would be useful to have to reload for example.

Useful commands to have available:

  • reload (reload when issue is fixed)
  • edit co-authors file (fix JSON format issue)

Motivation

This is to help make recovery less frustrating especially when setting up on the first install.

Add a primary author

Summary

A new user to Git and Git Mob might not have a primary author set globally or locally. Help the user set a primary author with a name and email using the Git Mob UI.

Currently, the extension breaks, shows no UI of co-authors making it difficult to know what to do next.

Motivation

Make it easier and reduce the frustration for the user to get started.

Describe alternatives you've considered

Currently, there is a link and instructions in the readme to set up correctly

Search for co-authors does not return results

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

No github users appear when I try to search for them

Steps to Reproduce

  1. Select "Search for co-authors on Github"
  2. Type in any letters (Ben)
  3. Nobody appears, even if I press Enter

Expected behaviour: A list of github users that match the letters typed in should appear

Actual behaviour: Nothing

Reproduces how often: [What percentage of the time does it reproduce?] Always

A related issue I cannot reproduce now: Initially, even search using the search icon under more co-authors returned nothing.

Versions

  • operating system and version:
  • git-mob-vs-code version (can be found in the Extensions tab)
  • git-mob version (git-mob --version):
  • git version (git --version):

Additional Information

GitMob silentRun: "git mob --list" Cannot read property 'rootUri' of undefined (in a multi-repo workspace)

Prerequisites

  • Checked that your issue isn't already filed
  • Tried upgrading to the latest git-mob-vs-code and git-mob version (npm i -g git-mob)
  • Tried upgrading to the latest git version (brew upgrade git if installed with Homebrew/Linuxbrew)

Description

The following error is raised repeatedly while working in a VS Code workspace with multiple folders, each it's own git repo independent of the others:

GitMob silentRun: "git mob --list" Cannot read property 'rootUri' of undefined

Steps to Reproduce

  1. Install the git-mob-vs-code extension
  2. Open a new VS Code window
  3. Add three independent folders into the workspace, each of which is it's own git repo, independent of the others

Expected behaviour: [What you expect to happen]

  • the git mob vscode extension works as expected, carrying my mob configuration into each repo as we work together in the workspace

Actual behaviour: [What actually happens]

  • the git mob vscode extension works as expected, carrying my mob configuration into each repo as we work together in the workspace

Reproduces how often: [What percentage of the time does it reproduce?]

  • every time I open the workspace
  • again when I first switch to the Source Control: Git view

Once having clicked on one of the repos in the Source Control Providers panel I see that repo properly reflected in the Git Mob Co-Authors panel.

After one repo is selected, selecting other repos seems to work as expected, and I see each selected repo change reflect as expected in the Git Mob Co-Authors panel.

Versions

  • operating system and version: macOS Catalina Version 10.15.5
  • git-mob-vs-code version: 1.5.3
  • git-mob version (git-mob --version): 1.1.0
  • git version (git --version): git version 2.27.0 (installed via Brew and updated this morning)

Additional Information

I suspect this error comes from this line of code when first opening VS Code and no repository has been selected in the Source Control Providers panel:

  get rootPath() {
    if (this.repositories.length > 0)
      return this.selectedRepository.rootUri.fsPath;

    return "";
  }

Perhaps this method could be updated to return the first repository in this.repositories when this.selectedRepository is null?

If this bug is reproducible by others and my suggestion is valid I am happy to submit a PR.

Add co-author from GitHub

Summary

Query the GitHub API to find an author and add them to the users co-author file.

Motivation

If a user is new to the repository, team or company and therefore can't be found in the local git repository, a simple command to find the user on GitHub could be very useful.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.