UI Proposal: Replace Unselected and More with Favorites about git-mob-vs-code HOT 10 OPEN

Okay - I will create a separate issue for the list. I changed proposal so that instead of greying out, you just don't see an icon if it is not applicable. The buttons hopefully make it more obvious how to take an action and what it does. Having a + on the Repository Users section makes adding to the Co-authors a single step. IMO you should be able to add people to the Co-authors list without adding them to favorites, which explains the buttons in the other two sections.

from git-mob-vs-code.

Hi @rkotze I don't know when I will be able to get this so unassigned myself. I would love to work on i, but I have other things in the pipeline. If anyone wants to pair with me on this, I would make time.

from git-mob-vs-code.

Needs more information please.

from git-mob-vs-code.

@rkotze - Updated

from git-mob-vs-code.

@rkotze What do you think of the proposed UI?

from git-mob-vs-code.

You can assign to me - I won't be able to get to it right away, can start in 3-5 weeks.

from git-mob-vs-code.

@ethanstrominger Not sure I completely follow your proposal.

What I think would be helpful is being clear on the problem you are solving, with a problem statement. Could you add it to the issue, you can edit the issue under the ellipsis on the right.

I do like the idea of changing the wording for "unselected" and "more author" lists but I would be concerned with merging them as they do represent different groups of data.

"Unselected" is a list of people a user typical pairs with and is essentially "global" making it accessible across multiple repos. So to me, it makes sense what you are suggesting to call it favourites and using the heart symbol. Also changing the plus to a heart in the "more authors" to add to favourites would be good. This could be a nice contained issue to make.

"More authors" is a list of contributors to that repo and I think it's worth making that distinction.

Let's start with being clear on what you're solving and we can take it from there.

from git-mob-vs-code.

@rkotze I modified the description to hopefully clarify both my intentions and the proposed UI changes.

from git-mob-vs-code.

@ethanstrominger thanks for that. I see you have updated your second comment but could you move to your first comment.

In Co-author section, add two buttons next to each name

• a heart to add a person to Favorites. Greyed out if already in favorites
• an x to remove a co-author without adding to Favorites
• add a search icon at the top which brings up the List dialog

The way Git Mob works for co-authoring you need to be a "favourite" before hand. You won't need the favourite button here. The co-authoring section will typically be a small list so I also don't think there is a need for a search.

Regarding where a user shows in a list, I've stuck with they only appear once across all the list. To avoid confusion and duplication. Greying out might not be very clear depending on their theme and it's quite limited adjusting colours in vs code.

In list dialog

This might be worth breaking out into a new issue and keep the focus around the UI list. It might help as this would be your first ticket and all this might be quite a big task. Let be know your thoughts.

from git-mob-vs-code.

Great thanks. I will put this into the "todo" list and you can work on it when you're ready.

I've designed this extension to be in sync with Git Mob CLI and that does not support a "temp" co-author option. There would need to be some thinking around how to approach that, also debate the value of making the change.

from git-mob-vs-code.