rfprod / nx-ng-starter Goto Github PK

Describe the proposal
Storybook stories are broken, revise it and fix.

Additional context
Storybook compiles successfully, but stories are broken.
Use https://www.npmjs.com/package/@storybook/addon-essentials instead of @storybook/addon-docs, @storybook/addon-controls, @storybook/addon-actions.

Use this manual https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#correct-globs-in-mainjs

Contact Details

No response

Problem description

Codeql action v1 will be deprecated soon.

CodeQL Action v1 will be deprecated on December 7th, 2022. Please upgrade to v2. For more information, see https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/

Preferred solution description

Update codeql action to v2.

Alternative solutions description

No response

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug
Currently cypress tests vs storybook hang after starting storybook.

To Reproduce

npx nx e2e client-components-e2e

Expected behavior
Cypress tests vs storybook do not hang.

Describe the proposal
Fix firebase deplyment, .env provisioning. Provide it via service.

Tracking issue for:

• https://github.com/rfprod/nx-ng-starter/security/code-scanning/4

Is your feature request related to a problem? Please describe.
Generate documentation for gRPC using protoc-gen-doc

Alternative
gendocu

Describe the bug
Configure documentation app deployment. Currently configured model does not work.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://nx-ng-starter.web.app/documentation/

Expected behavior
Documentation app loads when url is requested.

Migrate api app from jwt-simple to @nestjs/jwt
Remove jwt-simple dependency after migration.

What should be migrated
JWT simple is used in auth-utils.service.ts

Dependencies reference

• jwt-simple
• @nestjs/jwt

Angular 9 upgrade guide

Nx releases

Current Nx release candidate with breaking changes

Describe the proposal

• test recently added docker scripts;
• review and update CI jobs, add docker workflow;

Additional context
Check this PR as a reference of what was added.

Currently api starts with gql errors

Tracking issue for:

• https://github.com/rfprod/nx-ng-starter/security/code-scanning/2

Add sample Ionic app with code sharing between mobile app and webapp.

Instead on adding Ionic to the project, compare and add either Capacitor or Cordova to the project as a dev dependency, and configure a shell script tools/shell/build-mobile.sh that will accept an argument with possible values android | ios | windows, and use Cordova to build web application wrapped in a container for specific mobile platform:

• Android (building for this platform is in scope of this ticket)
• iOS (building for iOS via shell script should output a string TODO: build for iOS)
• Windows (building for iOS via shell script should output a string TODO: build for Window)

Describe the bug
When documentation app storybook is started locally, components are not rendered.

To Reproduce
Steps to reproduce the behavior:

1. Execute locally ng run documentation:storybook
2. Follow instructions in the terminal

Expected behavior
When documentation app storybook is started locally, components are rendered.

Desktop (please complete the following information):

• OS: Linux

Describe the bug
Currently functions are not deployed to firebase both from local setup and from CI.

To Reproduce

1. Execute command

firebase deploy --only functions:graphql,functions:login,functions:logout,functions:signup

Expected behavior
Functions are deployed to firebase.

Additional context
Terminal log

i  functions: updating Node.js 10 (Beta) function logout(us-central1)...
i  functions: updating Node.js 10 (Beta) function signup(us-central1)...
i  functions: updating Node.js 10 (Beta) function graphql(us-central1)...
⚠  functions[graphql(us-central1)]: Deployment error.
Error setting up the execution environment for your function. Please try deploying again after a few minutes.
⚠  functions[login(us-central1)]: Deployment error.
Error setting up the execution environment for your function. Please try deploying again after a few minutes.
⚠  functions[logout(us-central1)]: Deployment error.
Error setting up the execution environment for your function. Please try deploying again after a few minutes.
⚠  functions[signup(us-central1)]: Deployment error.
Error setting up the execution environment for your function. Please try deploying again after a few minutes.


Functions deploy had errors with the following functions:
	graphql
	login
	logout
	signup


To try redeploying those functions, run:
    firebase deploy --only functions:graphql,functions:login,functions:logout,functions:signup

Check this files which have commented code regarding firebase environment and grpc:

• apps/api/src/main.ts
• apps/api/src/app/modules/grpc/grpc-api-client.options.ts

Install required dependencies for grpc support in /functions directory.

Revise .devops directory contents.

Describe the bug
E2E reports are not generated or properly copied to the documentation app dist.

To Reproduce
Links in the following README.md section are not working https://github.com/rfprod/nx-ng-starter#e2e-report

Expected behavior
Links in the following README.md section are accessible https://github.com/rfprod/nx-ng-starter#e2e-report

Additional context

• https://github.com/rfprod/nx-ng-starter/blob/master/.github/workflows/master.yml#L129
• https://github.com/rfprod/nx-ng-starter/blob/master/tools/shell/e2e.sh

Describe the bug
./tools/shell/build.sh without arguments exits with usage error. Usage information contains - bash tools/shell/build.sh - build all apps.

To Reproduce
Steps to reproduce the behavior:

1. Execute command ./tools/shell/build.sh
2. See error

Expected behavior
All apps are built.

Additional context
Terminal log

nx-ng-starter > ./tools/shell/build.sh 

    << USAGE >>

     -  bash tools/shell/build.sh - build all apps
     -  bash tools/shell/build.sh prod - build all apps in production mode
     -  bash tools/shell/build.sh prod api - build API app in production mode
     -  bash tools/shell/build.sh prod nx-ng-starter - build Nx Ng Starter app in production mode

This error does not prevent api application from starting

(node:17156) UnhandledPromiseRejectionWarning: Error: Schema must contain uniquely named types but contains multiple types named "MatcompModel".
    at new GraphQLSchema (/media/suser/DATA/git/rfprod/nx-ng-starter/node_modules/graphql/type/schema.js:194:15)
    at GraphQLSchemaFactory.<anonymous> (/media/suser/DATA/git/rfprod/nx-ng-starter/node_modules/@nestjs/graphql/dist/schema-builder/graphql-schema.factory.js:28:28)
    at Generator.next (<anonymous>)
    at /media/suser/DATA/git/rfprod/nx-ng-starter/node_modules/tslib/tslib.js:113:75
    at new Promise (<anonymous>)
    at Object.__awaiter (/media/suser/DATA/git/rfprod/nx-ng-starter/node_modules/tslib/tslib.js:109:16)
    at GraphQLSchemaFactory.create (/media/suser/DATA/git/rfprod/nx-ng-starter/node_modules/@nestjs/graphql/dist/schema-builder/graphql-schema.factory.js:23:24)
    at GraphQLSchemaBuilder.<anonymous> (/media/suser/DATA/git/rfprod/nx-ng-starter/node_modules/@nestjs/graphql/dist/graphql-schema.builder.js:55:56)
    at Generator.next (<anonymous>)
    at /media/suser/DATA/git/rfprod/nx-ng-starter/node_modules/tslib/tslib.js:113:75

Don't provide services which are provided in root.

https://angular.io/guide/dependency-injection-providers#tree-shakable-providers

Currently only ng lint fixes files.

Describe the bug
Currently shell scripts are missing permissions which requires calling a script like, e.g.

bash tools/shell/install.sh

It is impossible to call a script using its name only

tools/shell/install

To Reproduce
Try calling a script by its name only

tools/shell/install

Expected behavior
It is possible to call a script by its name only

tools/shell/install

Desktop (please complete the following information):

• OS: Linux

Describe the bug
Workspace uses tsconfig.json files while nx has tsconfig.base.json hardcoded.

To Reproduce

Steps to reproduce the behavior:

1. execute

yarn workspace:schematic client-feature test-client-feature

Expected behavior
It should not be required to change tsconfig.json -> tsconfig.base.json, and tools/tsconfig.json to run workspace schematics.

Tracking issue for:

• https://github.com/rfprod/nx-ng-starter/security/code-scanning/1