revolutionary-games / thrive-launcher Goto Github PK

To no longer need user to install 32 bit libs. This is not going to be noticeable as there's never been 32 bit thrive releases for linux.
Also would be nice if the launcher preferred system installed 7zip on linux as that would likely have less issues (possibly).

• launcher uses system 7zip if available
• bundled 7zip is 64 bit

Otherwise github automatically changes the space to a dot.
But the project name (which seems to affect executable name also despite --executable-name) needs to have the space to look good on windows.

So the non-hackiest solution is to have the packaging script rename things how we like them.

Version numbers should also be included

Happened after the move. Might correct itself, but if this doesn't should be looked into.
Basically all the images are broken: emojis, user icons, embedded images in posts.

In order to show how big it is and to clear it. Individual files shouldn't be shown as there'll be a lot of them.

There might be an issue on where the executable is looked for.

sudo apt update throws this error every time now.

Setting up thrive-launcher (1.1.1) ...
ln: failed to create symbolic link '/usr/local/bin/thrive-launcher': No such file or directory
dpkg: error processing package thrive-launcher (--configure):
 installed thrive-launcher package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
 thrive-launcher
E: Sub-process /usr/bin/dpkg returned an error code (1)

Basically any file in git lfs shouldn't be included in a devbuild (that the launcher would access after linking to thrivedevcenter), and the launcher should instead download them after downloading a dehydrated build (and cache the files to make the downloads faster).

I think that converting the sizes shown in the download modal window (current and total file sizes) to a more human-readable format would be a good idea going forward, as the current solution of simply displaying the size in bytes does not seem very intuitive (is that the right word for it?).

For instance, when the download reaches 1,048,576 bytes transferred we should begin displaying it as "x.xx MB" instead of the raw byte count.

I feel that this, along with the percentage downloaded and (optionally) a display of the download speed (maybe estimated from the combined sizes of each chunk downloaded during the last second.) would make it a lot easier for users to estimate how long the download will take.

Some users might want to select a different folder than appdata for installing the thrive versions to.

Right now it seems that most people make crash reports with in adequate details.

The launcher should have a feature for automatically processing the crash dump and instructions for putting together a proper report.

Allow deleting installed versions and the zips that are downloaded to let users get back diskspace.
Also the installed versions should be installed to the user's home folder in some suitable location, perhaps some that can also be used for save data for thrive. This is already done.

Assuming that things like intro videos and most models won't change each release we can further improve the download times by making specific bundles for the launcher without all the assets (so assets could separately be delta compressed, which is something that could work automatically with full delta versions).

Right now on windows the default electron icon is used and on linux there's no icon.

That should be fixed.
Also if someone could create a .ico executable icon (and a .png for linux) of the thrive logo that would be great.

The command line options --no-sandbox and --single-process are needed to get Thrive to run on some Linux systems (and maybe some windows systems as well). These should be selectable in the launcher.

I opened the launcher for the first time in a while today and this happened:

The launch options are no longer valid for Godot versions, but for running historical versions it is nice to keep them, so some note or something needs to be added to tell people to not try to run the godot version with them.

Opening up the launcher throws TypeError: Cannot read property 'title' of null on both boxes when trying to parse the feeds.

In the right place this time, I apologize because I have no idea how to use giTHUB!!!! (of course, I'm still probably doing something wrong here!!!!)
I get this error whenever I try to launch Thrive 0.3.3 with the launcher. Last time I installed Thrive manually on Linux I had a similar issue with libraries and ended up having to place the missing ones in the bin folder in order for it to work.

Log:
Playing Thrive 0.3.3 Thrive is running. Log output: Process Started ERROR: /home/narotiza/Downloads/thrive-launcher-linux-x64/installed/LINUX_Thrive-v0.3.3/Thrive-0.3.3/bin/Thrive: error while loading shared libraries: librtmp.so.1: cannot open shared object file: No such file or directory child process exited with code 127

The launcher patch notes could be shown in the launcher somewhere. Thrive will show its own: Revolutionary-Games/Thrive#3868

If a version is made no longer available it is not possible to delete it anymore.
So the list of thrive versions view should have delete buttons for things that don't match a release but look like a thrive release (with a regex).

Now that the launcher is basically working it would be much more user friendly to delete the downloaded file if the hash is wrong. Currently the user has to manually find the file and delete it.

Thanks for making an AppImage. However, according to the AppImage philosophy, please bundle everthing that is needed to run, so that on an offline machine we don't get

Whatever it is trying to download here should be bundled inside the AppImage so that the AppImage does not need to download stuff.

Reference:
AppImage/appimage.github.io#1628

Right now it is a bit difficult to find as it is
C:/Users/YOURUSERNAMEHERE/AppData/Roaming/Revolutionary-Games/Launcher or ~/.config/Revolutionary-Games/Launcher

So there should be a button next to deleting installed versions to browse the files.

In order to allow the user to clear the temporary files.

Right now only the crash dump tells which OS the user was using when the game crashed. The launcher could include the platform when sending a report.

npm run start-dev runs the launcher with devtools open. Adding this to the readme would be nice.

To reduce the amount of bug reports about the game not starting it would be great if the launcher could detect what GPU the user has and tell them if they have too old Intel or AMD (the clouds issue) to reduce the number of reports.

I think this node package might be usable with the launcher: https://www.npmjs.com/package/systeminformation

For some reason the name of the program / window is "Electron" in the windows taskbar.

Right now it fails with error Refused to frame 'https://www.youtube.com/' because it violates the following Content Security Policy directive: "default-src 'self'". Note that 'frame-src' was not explicitly set, so 'default-src' is used as a fallback.

This needs to be fixed by adding a frame-src policy which allows self and youtube.

When building a cell if you clear the cell with the "c" key. Then you press back button to undo an action it crashes the game.

The currently happening Promise reject pause is likely caused by: openpgpjs/openpgpjs#784

Once that is resolved the dependencies should be updated.

The icon script uses bash style escapes which don't work on windows. At least I think that's the issue.

It needs to be fixed for windows.

Error:

Invalid Parameter - /launcher-icon.png
converting failed

add eslint rule for the => syntax spacing: https://eslint.org/docs/rules/arrow-spacing
with needing a space on both sides of the arrow

With godot the note is no longer relevant. or at least I hope so. At least the wording should be changed.

Log here: https://pastebin.com/Gr3zvviG

As it currently is multiline output from thrive doesn't get broken into multiple lines. The output needs to be split on \n or \r\n and added as separate elements to make them split to multiple lines correctly.

When i Run the game it waits a bit then shows up that
api-ms-win-crt-runtime-l1-1-0.dll was not found please try again or reinstall the game.
or something like that.
how can i solve it?

Basically the log part size is a bit too big to make the button completely fit in the window.
This is only on Windows on Linux it fits just fine.

One of the main points of having a launcher (besides automatic updates) was to make the updates smaller.

This is probably quite difficult to set up as I haven't found any existing format we could adapt for this purpose so we need a packing script that makes delta updates between 7z files generated for each release.

It would be cool to provide an installer at some point.

Requirements:

• all installers can be created on linux or on windows (no need to be on both to create all installers)
• should work on linux and windows
• can install new versions easily on top of existing ones (keeping thrive installs, this will probably require some directory like Documents/Games/Thrive to be used for installing thrive versions)
• the launcher can be used without installing (should have still zip files in addition to the installer)

Right now the main.js file needs to be edited to enable the debugging console. It would be handly if there was a command line flag that electron could read and set the option. Then there could be a npm start alternative that passes that command line parameter.

A download was corrupted and launcher gave me an error, some thing like "corrupted file and incorrect hash, please try again", i don't remember the exact message.

I had to go to

C:\Users\[USER_NAME]\AppData\Local\Temp\Revolutionary-Games-Launcher

and i saw Thrive-0.4.1.0-WINDOWS-64bit.7z file that had 0 size. i had to manually remove this file so the launcher could download it again.

I think this can be fixed fairly easily, just remove the temp file if download can not continue.

Launcher version: Thrive.Launcher-1.0.3-win.7z

Because Amazon S3 (GitHub's hosting provider for releases) supports the use of the HTTP Range header, I suggest that we could possibly make use of this to allow for continuing where a download left off, if the download process terminates unexpectedly (such as due to a network error, or something like that.)

The unzip part can fail with some really verbose error if the target is unwritable or the executable is open or something. The user should be at least given a better error message if the launcher can't automatically fix itself.

Looks like the log output in the launcher buffers the output until the thrive process quits. Maybe has to do with the way the process output is piped.

Something like ~/.local/Revolutionary-Games/Launcher might be good and on windows maybe appdata is fine or something like creating a folder in "My Documents" is fine.

Maybe by using openpgp in javascript: https://gist.github.com/deian/f2de2f1c33580ed1b3fd
and someone signs all the official version files with a pgp key

Once the installer versions (in addition to the zips) are made I think we can use this for updates:
https://www.electron.build/auto-update

If that can't be used then we'll just need to roll our own.

To make }else{ an error
add eslint rule for spaces on else https://eslint.org/docs/rules/keyword-spacing