Incorrect behavior of TypedPropertyFromStrictConstructorRector about rector HOT 6 CLOSED

I am not sure if this should be handled as that part of ArrayDimFetch definition, which by lookup of the whole class, should be used, and probably very rare of not follow the definition.

from rector.

I am not sure I got your point.

my thinking was, that getTokens() returns a native array and we can't know its key or value types. therefore I think the $activeTokens[$this->tokenid] dim fetch returns a mixed (in native type world) and therefore we have 2 property assignments in __construct. one with string and one with mixed which should lead to skipping instead of adding a type.

from rector.

The getTokens(): array define @return array<string, string> which it return typed array, so, array data should be string, yes, that can be wrong, but likely rare imo.

If that not always an array of string, the $_SESSION[self::$sessionName] can be not an array as well, so the definition should follow.

from rector.

I think the lesson learned from a year ago was, that phpdoc are oftentimes wrong and we shouldn't trust them?

from rector.

I see, but still, an array<> and array{} something that obvious, define by hand, and less copy paste error i guess, as that check by another assign and definition.

If the definition is overlapped between property and assignment, phpstan already catch early.

Yes, that's not perfect, but imo, that seems a way to make it typed.

from rector.

I am going to close it, the type is obvious looking by the whole class, with if else native data assigned.

PHP Array doesn't have native structured type, and writing correct array{} definition is another effort to be correct iterate definition in PHPStan, little wrong and it already catched by PHPStan, that after that, should be followed.

from rector.