Giter Club home page Giter Club logo

Comments (3)

samsonasik avatar samsonasik commented on June 26, 2024

That's expected, you can't use NodeTraverser::REMOVE_NODE directly under refactor() on Expr, you need to remove the whole Expression stmt, something like:

	public function getNodeTypes(): array {
		return [
			Node\Stmt\Expression::class
		];
	}

	public function refactor(Node $node) {
            if ($node->expr instanceof Node\Expr\ErrorSuppress && $node->expr->expr instanceof Include_) {
    		return NodeTraverser::REMOVE_NODE;
            }

            if ($node->expr instanceof Include_) {
    		return NodeTraverser::REMOVE_NODE;
            }
        
            return null;
	}

that already answered at #8172

from rector.

stein197 avatar stein197 commented on June 26, 2024

Thank you! Is it defined somewhere in the documentation? I cannot find this

from rector.

TomasVotruba avatar TomasVotruba commented on June 26, 2024

It's inherited treat of AST tree, so I'd look for it somewhere in:
https://github.com/nikic/PHP-Parser/tree/4.x/doc

Still, we might add a "AST Gotchas" page to our docs, as this is something hard to find.
Where would you expect this to find?

from rector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.